Spring/spring-security
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Document Reactive Method security requires Publisher return types

Browse Source 
Fixes: gh-4988
This commit is contained in:
Rob Winch
2018-02-07 16:31:41 -06:00
parent ea3dd336aa
commit 964a14b224
5 changed files with 26 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
config/src/test/java/org/springframework/security/config/annotation/method/configuration/DelegatingReactiveMessageService.java
View File

@@ -28,6 +28,12 @@ public class DelegatingReactiveMessageService implements ReactiveMessageService
this.delegate = delegate;
}
@Override
@PreAuthorize("denyAll")
public String notPublisherPreAuthorizeFindById(long id) {
return this.delegate.notPublisherPreAuthorizeFindById(id);
}
@Override
public Mono<String> monoFindById(long id) {
return delegate.monoFindById(id);

9
config/src/test/java/org/springframework/security/config/annotation/method/configuration/EnableReactiveMethodSecurityTests.java
View File

@@ -34,6 +34,7 @@ import reactor.test.StepVerifier;
import reactor.test.publisher.TestPublisher;
import reactor.util.context.Context;
import static org.assertj.core.api.Assertions.assertThatThrownBy;
import static org.mockito.Mockito.*;
/**
@@ -60,6 +61,14 @@ public class EnableReactiveMethodSecurityTests {
this.delegate = config.delegate;
}
@Test
public void notPublisherPreAuthorizeFindByIdThenThrowsIllegalStateException() {
assertThatThrownBy(() -> this.messageService.notPublisherPreAuthorizeFindById(1L))
.isInstanceOf(IllegalStateException.class)
.extracting(Throwable::getMessage)
.contains("The returnType class java.lang.String on public abstract java.lang.String org.springframework.security.config.annotation.method.configuration.ReactiveMessageService.notPublisherPreAuthorizeFindById(long) must return an instance of org.reactivestreams.Publisher (i.e. Mono / Flux) in order to support Reactor Context");
}
@Test
public void monoWhenPermitAllThenAopDoesNotSubscribe() {
when(this.delegate.monoFindById(1L)).thenReturn(Mono.from(result));

2
config/src/test/java/org/springframework/security/config/annotation/method/configuration/ReactiveMessageService.java
View File

@@ -20,6 +20,8 @@ import reactor.core.publisher.Flux;
import reactor.core.publisher.Mono;
public interface ReactiveMessageService {
String notPublisherPreAuthorizeFindById(long id);
Mono<String> monoFindById(long id);
Mono<String> monoPreAuthorizeHasRoleFindById(long id);
Mono<String> monoPostAuthorizeFindById(long id);