From 96d82ecbf2e4ba6ce38eb110a5e0462bd44c41ed Mon Sep 17 00:00:00 2001 From: Rafael Renan Pacheco Date: Thu, 2 Jan 2020 13:29:05 -0300 Subject: [PATCH] Fix docs that cause unchecked assignment and NPE --- .../asciidoc/_includes/reactive/oauth2/resource-server.adoc | 5 +++-- .../_includes/servlet/oauth2/oauth2-resourceserver.adoc | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/docs/manual/src/docs/asciidoc/_includes/reactive/oauth2/resource-server.adoc b/docs/manual/src/docs/asciidoc/_includes/reactive/oauth2/resource-server.adoc index 529f526eae..25a3060d05 100644 --- a/docs/manual/src/docs/asciidoc/_includes/reactive/oauth2/resource-server.adoc +++ b/docs/manual/src/docs/asciidoc/_includes/reactive/oauth2/resource-server.adoc @@ -464,10 +464,11 @@ static class GrantedAuthoritiesExtractor implements Converter> { public Collection convert(Jwt jwt) { - Collection authorities = (Collection) - jwt.getClaims().get("mycustomclaim"); + Collection authorities = (Collection) + jwt.getClaims().getOrDefault("mycustomclaim", Collections.emptyList()); return authorities.stream() + .map(Object::toString) .map(SimpleGrantedAuthority::new) .collect(Collectors.toList()); } diff --git a/docs/manual/src/docs/asciidoc/_includes/servlet/oauth2/oauth2-resourceserver.adoc b/docs/manual/src/docs/asciidoc/_includes/servlet/oauth2/oauth2-resourceserver.adoc index d540827334..fc9452a979 100644 --- a/docs/manual/src/docs/asciidoc/_includes/servlet/oauth2/oauth2-resourceserver.adoc +++ b/docs/manual/src/docs/asciidoc/_includes/servlet/oauth2/oauth2-resourceserver.adoc @@ -496,10 +496,11 @@ static class GrantedAuthoritiesExtractor implements Converter> { public Collection convert(Jwt jwt) { - Collection authorities = (Collection) - jwt.getClaims().get("mycustomclaim"); + Collection authorities = (Collection) + jwt.getClaims().getOrDefault("mycustomclaim", Collections.emptyList()); return authorities.stream() + .map(Object::toString) .map(SimpleGrantedAuthority::new) .collect(Collectors.toList()); }