From a4fd191499c8d5770d521f810cd24145f67bc8b8 Mon Sep 17 00:00:00 2001
From: Luke Taylor <luke.taylor@springsource.com>
Date: Tue, 20 Jul 2010 14:31:52 +0100
Subject: [PATCH] Added check for use of "ref" with other attributes in
 <authentication-provider>.

---
 .../AuthenticationManagerBeanDefinitionParser.java            | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/config/src/main/java/org/springframework/security/config/authentication/AuthenticationManagerBeanDefinitionParser.java b/config/src/main/java/org/springframework/security/config/authentication/AuthenticationManagerBeanDefinitionParser.java
index 1b700a14b1..271ef7d090 100644
--- a/config/src/main/java/org/springframework/security/config/authentication/AuthenticationManagerBeanDefinitionParser.java
+++ b/config/src/main/java/org/springframework/security/config/authentication/AuthenticationManagerBeanDefinitionParser.java
@@ -57,6 +57,10 @@ public class AuthenticationManagerBeanDefinitionParser implements BeanDefinition
             if (node instanceof Element) {
                 Element providerElt = (Element)node;
                 if (StringUtils.hasText(providerElt.getAttribute(ATT_REF))) {
+                    if (providerElt.getAttributes().getLength() > 1) {
+                        pc.getReaderContext().error("authentication-provider element cannot be used with other attributes " +
+                                "when using 'ref' attribute", pc.extractSource(element));
+                    }
                     NodeList providerChildren = providerElt.getChildNodes();
                     for (int j = 0; j < providerChildren.getLength(); j++) {
                         if (providerChildren.item(j) instanceof Element) {