Spring/spring-security
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

SEC-2119: Polish remember-me@rememberme-parameter

Browse Source 
- Change form-parameter to rememerme-parameter
  - Use rnc file for generating the xsd
  - Add test for deafult value of rememberme parameter
This commit is contained in:
Rob Winch
2013-03-01 16:31:39 -06:00
parent 9eb34fe51c
commit b014020955
5 changed files with 31 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
config/src/test/groovy/org/springframework/security/config/http/RememberMeConfigTests.groovy
View File

@@ -26,6 +26,7 @@ import org.springframework.security.util.FieldUtils
import org.springframework.security.web.authentication.SimpleUrlAuthenticationSuccessHandler
import org.springframework.security.web.authentication.logout.LogoutFilter
import org.springframework.security.web.authentication.logout.SecurityContextLogoutHandler
import org.springframework.security.web.authentication.rememberme.AbstractRememberMeServices;
import org.springframework.security.web.authentication.rememberme.InMemoryTokenRepositoryImpl
import org.springframework.security.web.authentication.rememberme.JdbcTokenRepositoryImpl
import org.springframework.security.web.authentication.rememberme.PersistentTokenBasedRememberMeServices
@@ -213,10 +214,20 @@ class RememberMeConfigTests extends AbstractHttpConfigTests {
notThrown BeanDefinitionParsingException
}
def 'Default form-parameter is correct'() {
httpAutoConfig () {
'remember-me'()
}
createAppContext(AUTH_PROVIDER_XML)
expect:
rememberMeServices().parameter == AbstractRememberMeServices.DEFAULT_PARAMETER
}
// SEC-2119
def 'Custom form-parameter is supported'() {
httpAutoConfig () {
'remember-me'('form-parameter': 'ourParam')
'remember-me'('rememberme-parameter': 'ourParam')
}
createAppContext(AUTH_PROVIDER_XML)
@@ -227,7 +238,7 @@ class RememberMeConfigTests extends AbstractHttpConfigTests {
def 'form-parameter cannot be used together with services-ref'() {
when:
httpAutoConfig () {
'remember-me'('form-parameter': 'ourParam', 'services-ref': 'ourService')
'remember-me'('rememberme-parameter': 'ourParam', 'services-ref': 'ourService')
}
createAppContext(AUTH_PROVIDER_XML)
then: