Spring/spring-security
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove unnecessary default constructors which throw IllegalArgumentException. Favours compile time over runtime errors.

Browse Source
This commit is contained in:
Luke Taylor
2006-02-16 16:44:35 +00:00
parent 4b4d4d3332
commit e12c8310eb
17 changed files with 61 additions and 90 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
core/src/test/java/org/acegisecurity/SecurityConfigTests.java
View File

@@ -49,12 +49,14 @@ public class SecurityConfigTests extends TestCase {
SecurityConfig config = new SecurityConfig("TEST");
assertEquals("TEST".hashCode(), config.hashCode());
}
public void testNoArgConstructorDoesntExist() {
Class clazz = SecurityConfig.class;
public void testNoArgsConstructor() {
try {
new SecurityConfig();
fail("Should have thrown IllegalArgumentException");
} catch (IllegalArgumentException expected) {
clazz.getDeclaredConstructor((Class[])null);
fail("Should have thrown NoSuchMethodException");
} catch (NoSuchMethodException expected) {
assertTrue(true);
}
}

10
core/src/test/java/org/acegisecurity/acl/basic/NamedEntityObjectIdentityTests.java
View File

@@ -75,11 +75,13 @@ public class NamedEntityObjectIdentityTests extends TestCase {
}
}
public void testDefaultConstructorRejected() {
public void testNoArgConstructorDoesntExist() {
Class clazz = NamedEntityObjectIdentity.class;
try {
new NamedEntityObjectIdentity();
fail("Should have thrown IllegalArgumentException");
} catch (IllegalArgumentException expected) {
clazz.getDeclaredConstructor((Class[])null);
fail("Should have thrown NoSuchMethodException");
} catch (NoSuchMethodException expected) {
assertTrue(true);
}
}

13
core/src/test/java/org/acegisecurity/adapters/AbstractAdapterAuthenticationTokenTests.java
View File

@@ -71,15 +71,6 @@ public class AbstractAdapterAuthenticationTokenTests extends TestCase {
assertTrue(!token.isUserInRole("ROLE_XXXX"));
}
public void testNoArgsConstructor() {
try {
new MockDecisionManagerImpl();
fail("Should have thrown IllegalArgumentException");
} catch (IllegalArgumentException expected) {
assertTrue(true);
}
}
public void testObjectsEquals() throws Exception {
MockDecisionManagerImpl token1 = new MockDecisionManagerImpl("my_password",
"Test", "Password",
@@ -148,10 +139,6 @@ public class AbstractAdapterAuthenticationTokenTests extends TestCase {
this.password = password;
}
private MockDecisionManagerImpl() {
throw new IllegalArgumentException();
}
public Object getCredentials() {
return this.password;
}

12
core/src/test/java/org/acegisecurity/adapters/PrincipalAcegiUserTokenTests.java
View File

@@ -59,12 +59,14 @@ public class PrincipalAcegiUserTokenTests extends TestCase {
assertEquals("Test", token.getName());
}
public void testNoArgsConstructor() {
public void testNoArgConstructorDoesntExist() {
Class clazz = PrincipalAcegiUserToken.class;
try {
new PrincipalAcegiUserToken();
fail("Should have thrown IllegalArgumentException");
} catch (IllegalArgumentException expected) {
clazz.getDeclaredConstructor((Class[])null);
fail("Should have thrown NoSuchMethodException");
} catch (NoSuchMethodException expected) {
assertTrue(true);
}
}
}
}

10
core/src/test/java/org/acegisecurity/intercept/InterceptorStatusTokenTests.java
View File

@@ -48,11 +48,13 @@ public class InterceptorStatusTokenTests extends TestCase {
junit.textui.TestRunner.run(InterceptorStatusTokenTests.class);
}
public void testDefaultConstructor() {
public void testNoArgConstructorDoesntExist() {
Class clazz = InterceptorStatusToken.class;
try {
new InterceptorStatusToken();
fail("Should have thrown IllegalArgumentException");
} catch (IllegalArgumentException expected) {
clazz.getDeclaredConstructor((Class[])null);
fail("Should have thrown NoSuchMethodException");
} catch (NoSuchMethodException expected) {
assertTrue(true);
}
}

10
core/src/test/java/org/acegisecurity/intercept/web/FilterInvocationDefinitionSourceEditorTests.java
View File

@@ -154,11 +154,13 @@ public class FilterInvocationDefinitionSourceEditorTests extends TestCase {
assertEquals(2, map.getMapSize());
}
public void testNoArgsConstructor() {
public void testNoArgConstructorDoesntExist() {
Class clazz = RegExpBasedFilterInvocationDefinitionMap.EntryHolder.class;
try {
new RegExpBasedFilterInvocationDefinitionMap().new EntryHolder();
fail("Should have thrown IllegalArgumentException");
} catch (IllegalArgumentException expected) {
clazz.getDeclaredConstructor((Class[])null);
fail("Should have thrown NoSuchMethodException");
} catch (NoSuchMethodException expected) {
assertTrue(true);
}
}

10
core/src/test/java/org/acegisecurity/intercept/web/FilterInvocationDefinitionSourceEditorWithPathsTests.java
View File

@@ -135,11 +135,13 @@ public class FilterInvocationDefinitionSourceEditorWithPathsTests
assertEquals(2, map.getMapSize());
}
public void testNoArgsConstructor() {
public void testNoArgConstructorDoesntExist() {
Class clazz = PathBasedFilterInvocationDefinitionMap.EntryHolder.class;
try {
new PathBasedFilterInvocationDefinitionMap().new EntryHolder();
fail("Should have thrown IllegalArgumentException");
} catch (IllegalArgumentException expected) {
clazz.getDeclaredConstructor((Class[])null);
fail("Should have thrown NoSuchMethodException");
} catch (NoSuchMethodException expected) {
assertTrue(true);
}
}

10
core/src/test/java/org/acegisecurity/intercept/web/FilterInvocationTests.java
View File

@@ -77,11 +77,13 @@ public class FilterInvocationTests extends MockObjectTestCase {
fi.getFullRequestUrl());
}
public void testNoArgsConstructor() {
public void testNoArgConstructorDoesntExist() {
Class clazz = FilterInvocation.class;
try {
new FilterInvocation();
fail("Should have thrown IllegalArgumentException");
} catch (IllegalArgumentException expected) {
clazz.getDeclaredConstructor((Class[])null);
fail("Should have thrown NoSuchMethodException");
} catch (NoSuchMethodException expected) {
assertTrue(true);
}
}

10
core/src/test/java/org/acegisecurity/providers/cas/TicketResponseTests.java
View File

@@ -82,11 +82,13 @@ public class TicketResponseTests extends TestCase {
ticket.getProxyGrantingTicketIou());
}
public void testNoArgConstructor() {
public void testNoArgConstructorDoesntExist() {
Class clazz = TicketResponse.class;
try {
new TicketResponse();
fail("Should have thrown IllegalArgumentException");
} catch (IllegalArgumentException expected) {
clazz.getDeclaredConstructor((Class[])null);
fail("Should have thrown NoSuchMethodException");
} catch (NoSuchMethodException expected) {
assertTrue(true);
}
}

10
core/src/test/java/org/acegisecurity/userdetails/UserTests.java
View File

@@ -101,11 +101,13 @@ public class UserTests extends TestCase {
new GrantedAuthority[] {new GrantedAuthorityImpl("ROLE_ONE")})));
}
public void testNoArgConstructor() {
public void testNoArgConstructorDoesntExist() {
Class clazz = User.class;
try {
new User();
fail("Should have thrown IllegalArgumentException");
} catch (IllegalArgumentException expected) {
clazz.getDeclaredConstructor((Class[])null);
fail("Should have thrown NoSuchMethodException");
} catch (NoSuchMethodException expected) {
assertTrue(true);
}
}