Spring/spring-security
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Reject the NULL character in paths in StrictHttpFirewall

Browse Source 
Adds `setAllowNull`
By default, denies null in paths
This commit is contained in:
Craig Andrews
2020-06-03 14:11:55 -04:00
committed by Josh Cummings
parent 406cde8798
commit efb6953017
2 changed files with 39 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
web/src/test/java/org/springframework/security/web/firewall/StrictHttpFirewallTests.java
View File

@@ -1,5 +1,5 @@
/*
* Copyright 2012-2019 the original author or authors.
* Copyright 2012-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -377,6 +377,18 @@ public class StrictHttpFirewallTests {
this.firewall.getFirewalledRequest(this.request);
}
@Test(expected = RequestRejectedException.class)
public void getFirewalledRequestWhenContainsNullThenException() {
this.request.setRequestURI("/\0");
this.firewall.getFirewalledRequest(this.request);
}
@Test(expected = RequestRejectedException.class)
public void getFirewalledRequestWhenContainsEncodedNullThenException() {
this.request.setRequestURI("/something%00/");
this.firewall.getFirewalledRequest(this.request);
}
// --- from DefaultHttpFirewallTests ---
/**