Spring/spring-security
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
8,913 Commits 26 Branches 0 Tags
18f3d13363a3f74ef75ee3e7b80e2546ba5d8b5f
Commit Graph

1183 Commits

Author SHA1 Message Date
Phillip Webb
18f3d13363 Fix parenthesis padding issues 
Fix a few parenthesis padding issues caused by the formatter.

Issue gh-8945
 2020-08-24 17:33:08 -05:00
Phillip Webb
f1cee9500f Ensure classes are defined in their own files 
Ensure that all classes are defined in their own files. Mostly classes
have been changed to inner-types.

Issue gh-8945
 2020-08-24 17:33:08 -05:00
Phillip Webb
4d487e8dc3 Ensure all files end with a new line 
Update all files to ensure that they always end with a new-line
character.

Issue gh-8945
 2020-08-24 17:33:07 -05:00
Phillip Webb
a0b9442265 Use consistent modifier order 
Update code to use a consistent modifier order that aligns with that
used in the "Java Language specification".

Issue gh-8945
 2020-08-24 17:33:07 -05:00
Phillip Webb
a2f2e9ac8d Move inner-types so that they are always last 
Move all inner-types so that they are consistently the last item
defined. This aligns with the style used by Spring Framework and
the consistency generally makes it easier to scan the source.

Issue gh-8945
 2020-08-24 17:33:07 -05:00
Phillip Webb
9e08b51ed3 Apply code cleanup rules to projects 
Apply automated cleanup rules to add `@Override` and `@Deprecated`
annotations and to fix class references used with static methods.

Issue gh-8945
 2020-08-24 17:33:07 -05:00
Phillip Webb
8866fa6fb0 Always use 'this.' when accessing fields 
Apply an Eclipse cleanup rules to ensure that fields are always accessed
using `this.`. This aligns with the style used by Spring Framework and
helps users quickly see the difference between a local and member
variable.

Issue gh-8945
 2020-08-24 17:33:07 -05:00
Phillip Webb
6894ff5d12 Make classes final where possible 
Update classes that have private constructors so that they are also
declared final. In a few cases, inner-classes used private constructors
but were subclassed. These have now been changed to have package-private
constructors.

Issue gh-8945
 2020-08-24 17:33:07 -05:00
Phillip Webb
37fa94fafc Organize imports 
Use "organize imports" from Eclipse to cleanup import statements so
that they appear in a consistent and well defined order.

Issue gh-8945
 2020-08-24 17:33:07 -05:00
Phillip Webb
5f64f53c3f Use consistent "@" tag order in Javadoc 
Ensure that Javadoc "@" tags appear in a consistent and well defined
order.

Issue gh-8945
 2020-08-24 17:33:07 -05:00
Phillip Webb
71bc145ae4 Remove superfluous comments 
Use '^\s+//\ \~\ .*$' and '^\s+//\ ============+$' regular expression
searches to remove superfluous comments.

Prior to this commit, many classes would have comments to indicate
blocks of code (such as constructors/methods/instance fields). These
added a lot of noise and weren't all that helpful, especially given
the outline views available in most modern IDEs.

Issue gh-8945
 2020-08-24 17:33:07 -05:00
Phillip Webb
b7fc18262d Reformat code using spring-javaformat 
Run `./gradlew format` to reformat all java files.

Issue gh-8945
 2020-08-24 17:32:56 -05:00
Phillip Webb
6979125ccf Add noformat blocks around User.withUsername 
Find `User.withUsername` calls and protect them against formatting.

Issue gh-8945
 2020-08-10 16:24:44 -05:00
Phillip Webb
27ac046d8a Rename *Test.java -> *Tests.java 
Rename a few test classes that accidentally ended in `Test` instead of
`Tests`.

Issue gh-8945
 2020-08-10 16:24:44 -05:00
yukihane
c177b391d4 Polish ProviderManagerTests 
- Renamed test to follow naming convention
- Simplified mock with Mockito
- Added note regarding related ticket

Issue gh-8689
 2020-06-16 15:56:04 -06:00
yukihane
5302fb776c ProviderManager Uses CollectionUtils#contains 
Closes gh-8689
 2020-06-16 15:56:04 -06:00
Rob Winch
ca1252be94 Replace whitelist with allowlist 
Issue gh-8676
 2020-06-10 11:49:21 -05:00
Maksim Mednik
eacd212a5a Adding Map support to DefaultMethodSecurityExpressionHandler 2020-04-04 15:46:07 -04:00
Venkata Jaswanth
5fc6414377 SessionRegistryImpl is now aware of SessionIdChangedEvent 2020-03-06 12:04:01 -05:00
Josh Cummings
1b68cdb650 Polish DefaultAuthenticationEventPublisherTests 
Fixed checkstyle violation

Issue gh-7824
 2020-02-21 12:59:44 -07:00
Attoumane AHAMADI
bfc2832c6c Authentication Event Publisher Mappings 
Fixes gh-7824
 2020-02-21 12:49:04 -07:00
Zeeshan Adnan
51b9b2f693 DefaultAuthenticationEventPublisher Default Event 
Fixes gh-7825
 2020-02-06 14:13:04 -07:00
Thomas Vitale
ace89e12f2 Make code cleaner in ProviderManagerTests 2020-01-30 16:07:24 -07:00
Thomas Vitale
5ce60022d3 ProviderManager should have a varargs constructor 
- Added varargs constructor to ProviderManager.
- Added check for null values in AuthenticationProvider list.
- Updated ProviderManagerTests to test for null values using both constructors.

Fixes gh-7713
 2020-01-30 16:07:24 -07:00
Daniel Bustamante Ospina
150b66824d Make MethodSecurityEvaluationContext Delegate to MethodBasedEvaluationContext 
Spring Security's MethodSecurityEvaluationContext should delegate to Spring Framework's
MethodBasedEvaluationContext

Fixes: gh-6224
 2020-01-03 19:49:41 -05:00
Tao Sun
f18d0fd1a7 Test details using isEqualTo 2019-12-18 17:35:51 +01:00
Tao Sun
6b0981549b Add test for details deserialization 2019-12-18 17:35:51 +01:00
Rob Winch
1bf0e70bd0 Revert "Dispose default Scheduler" 
This reverts commit 39600b901f.
 2019-09-30 15:19:31 -05:00
Roman Matiushchenko
39600b901f Dispose default Scheduler 
AbstractUserDetailsReactiveAuthenticationManager creates parallel
Scheduler with daemon=false Threads. It is recommended to dispose such
Schedulers to be able exit the VM

Fixes gh-7492
 2019-09-29 20:23:05 +03:00
Rob Winch
00f8991fac Merge Remove Redudant Throws 
Fixes gh-7301
 2019-09-19 11:04:53 -05:00
kostya05983
f6c650db47 Replace Streams with Loops 
First version of replacing streams

fix wwwAuthenticate and codestyle

fix errors in implementation to pass tests

Fix review notes

Remove uneccessary final to align with cb

Short circuit way to authorize

Simplify error message, make code readably

Return error while duplicate key found

Delete check for duplicate, checkstyle issues

Return duplicate error

Fixes gh-7154
 2019-09-02 15:30:48 -06:00
Lars Grefer
95511331fa fix checkstyle 2019-08-26 22:42:26 +02:00
Lars Grefer
34dd5fea30 Remove redundant throws clauses 
Removes exceptions that are declared in a method's signature but never thrown by the method itself or its implementations/derivatives.
 2019-08-23 01:03:54 +02:00
Lars Grefer
ec6ca97226 Fix tests 2019-08-11 21:09:10 +02:00
Lars Grefer
ff1070df36 remove redundant modifiers found by checkstyle 2019-08-10 00:18:56 +02:00
Lars Grefer
fb39d9c255 Anonymous type can be replaced with lambda 2019-08-08 17:09:09 -04:00
Lars Grefer
f5cd0ec302 Use try-with-resources instead of try-finally 2019-08-06 15:33:04 -05:00
Lars Grefer
2306d987e9 Cleanup unnecessary boxing 2019-08-06 10:17:38 -04:00
Lars Grefer
776a4c3760 Use org.mockito.ArgumentMatchers in favor of org.mockito.Matchers 2019-08-03 12:28:37 -04:00
Eddú Meléndez Gonzales
8e6e975e86 Prevent authentication when user is inactive for reactive apps 
Currently, reactive applications doesn't perform validation when user
is locked, disabled or expired. This commit introduces these validations.

Fixes gh-7113
 2019-07-29 11:03:05 -04:00
Karel Maxa
d3eaef66fc Fix infinite loop in role hierarchy resolving 
Issue: gh-7035
 2019-07-11 15:43:26 +02:00
Lars Grefer
3ea9d376b2 Cleanup explicit type arguments 2019-07-10 09:32:41 -05:00
Lars Grefer
c5b5cc507c Cleanup redundant type casts 2019-07-10 09:31:09 -05:00
Lars Grefer
43737a56bd Use foreach where possible 2019-07-09 06:11:45 -06:00
Lars Grefer
7dc28ff376 Use contains() instead of indexOf() != -1 2019-07-09 06:07:42 -06:00
Tadaya Tsuyukubo
71dc4f39be Allow configuring scheduler on ReactiveAuthenticationManagerAdapter 
Currently, authentication logic will be performed on hardcoded elastic
scheduler in ReactiveAuthenticationManagerAdapter.
This commit makes the authentication logic scheduler configureable.
 2019-06-12 09:54:32 -05:00
Rob Winch
1f7ba47ce9 Test Javadoc for RoleHiearchy 
Issue gh-6954
 2019-06-07 10:59:42 -05:00
Clement Ng
e66369f6c6 Added null checks and tests to constructors 
RequestKey, JaasGrantedAuthority, and SwitchUserGrantedAuthority
assume certain final members are non-null.

Issue: gh-6892
 2019-05-29 16:10:36 -06:00
Maksim Vinogradov
59acda04cf Fix NPE ExpressionBasedPreInvocationAdviceTests 
Getting NPE if @PreFilter argument filterType is not provided
and method accept more then one argument.

Add related exception message.

fixes gh-6803
 2019-04-26 14:40:19 -06:00
Josh Cummings
1c25fe26c9 Introduce Support for Reading RSA Keys 
Fixes: gh-6494
 2019-04-13 19:39:11 -06:00