From dde76f02f101b8ca225dbd014d9000a175196157 Mon Sep 17 00:00:00 2001 From: John Blum Date: Wed, 20 Oct 2021 16:37:19 -0700 Subject: [PATCH] Remove 'org.apache.geode:geode-membership' and 'org.apache.geode:geode-tcp-server' provided dependency declarations. Add Javadoc to the GemFireUtilsTests to remove use of internal Apache Geode APIs (AbstractRegion). --- spring-session-data-geode/spring-session-data-geode.gradle | 5 ++--- .../session/data/gemfire/support/GemFireUtilsTests.java | 3 +++ 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/spring-session-data-geode/spring-session-data-geode.gradle b/spring-session-data-geode/spring-session-data-geode.gradle index bf11b16..4ade32a 100644 --- a/spring-session-data-geode/spring-session-data-geode.gradle +++ b/spring-session-data-geode/spring-session-data-geode.gradle @@ -22,11 +22,10 @@ dependencies { provided "javax.servlet:javax.servlet-api" - // TODO: Remove dependency declarations when all internal Apache Geode API usage is removed; Only required by tests! + // TODO: Remove dependency declarations when all internal Apache Geode API usage is removed; Only required by test, + // and specifically, the GemFireUtilsTests! :P provided "org.apache.geode:geode-logging:$apacheGeodeVersion" - provided "org.apache.geode:geode-membership:$apacheGeodeVersion" // Need for Geode Serialization provided "org.apache.geode:geode-serialization:$apacheGeodeVersion" // Need for Geode Serialization - provided "org.apache.geode:geode-tcp-server:$apacheGeodeVersion" // Need for Geode Serialization testCompile "org.assertj:assertj-core" testCompile "junit:junit" diff --git a/spring-session-data-geode/src/test/java/org/springframework/session/data/gemfire/support/GemFireUtilsTests.java b/spring-session-data-geode/src/test/java/org/springframework/session/data/gemfire/support/GemFireUtilsTests.java index 5f4fd1b..e7a69e1 100644 --- a/spring-session-data-geode/src/test/java/org/springframework/session/data/gemfire/support/GemFireUtilsTests.java +++ b/spring-session-data-geode/src/test/java/org/springframework/session/data/gemfire/support/GemFireUtilsTests.java @@ -175,6 +175,7 @@ public class GemFireUtilsTests { @Test @SuppressWarnings("rawtypes") + // TODO: Remove use of Apache Geode internal API (AbstractRegion). public void clientRegionWithServerProxyIsNonLocalClientRegion() { ClientCache mockClientCache = mock(ClientCache.class); @@ -198,6 +199,7 @@ public class GemFireUtilsTests { @Test @SuppressWarnings("rawtypes") + // TODO: Remove use of Apache Geode internal API (AbstractRegion). public void clientRegionWithNoPoolAndNoServerProxyIsNotNonLocalClientRegion() { ClientCache mockClientCache = mock(ClientCache.class); @@ -242,6 +244,7 @@ public class GemFireUtilsTests { @Test @SuppressWarnings("rawtypes") + // TODO: Remove use of Apache Geode internal API (AbstractRegion). public void peerRegionWithServerProxyIsNotNonLocalClientRegion() { Cache mockPeerCache = mock(Cache.class);