From e1f03a71da59015be0aaeb0aea00575ffb49e760 Mon Sep 17 00:00:00 2001 From: John Blum Date: Mon, 1 Jun 2020 14:30:04 -0700 Subject: [PATCH] Fix and/or suppress compilation warnings. Edit Javadoc. --- ...ionsSessionRepositoryIntegrationTests.java | 3 +-- ...ionsSessionRepositoryIntegrationTests.java | 5 ++--- ...essionAttributesDeltaIntegrationTests.java | 7 +++---- ...essionAttributesDeltaIntegrationTests.java | 7 +++---- ...ionsSessionRepositoryIntegrationTests.java | 3 +-- ...pSessionConfigurationIntegrationTests.java | 4 ++-- ...nGemFireConfigurationIntegrationTests.java | 21 +++++++++++++++---- ...pSessionConfigurationIntegrationTests.java | 3 +++ ...pSessionConfigurationIntegrationTests.java | 5 ++--- ...pirationConfigurationIntegrationTests.java | 3 +-- ...eoutSessionExpirationIntegrationTests.java | 5 ++--- ...ustomIsDirtyPredicateIntegrationTests.java | 8 ++++--- ...FireHttpSessionConfigurationUnitTests.java | 9 ++++---- ...essionAttributesIndexFactoryBeanTests.java | 10 ++++++--- ...nCacheTypeAwareRegionFactoryBeanTests.java | 7 +++---- ...ringSessionGemFireConfigurerUnitTests.java | 6 ++---- 16 files changed, 58 insertions(+), 48 deletions(-) diff --git a/spring-session-data-geode/src/integration-test/java/org/springframework/session/data/gemfire/ClientServerGemFireOperationsSessionRepositoryIntegrationTests.java b/spring-session-data-geode/src/integration-test/java/org/springframework/session/data/gemfire/ClientServerGemFireOperationsSessionRepositoryIntegrationTests.java index 4f872ee..5ed3f10 100644 --- a/spring-session-data-geode/src/integration-test/java/org/springframework/session/data/gemfire/ClientServerGemFireOperationsSessionRepositoryIntegrationTests.java +++ b/spring-session-data-geode/src/integration-test/java/org/springframework/session/data/gemfire/ClientServerGemFireOperationsSessionRepositoryIntegrationTests.java @@ -93,7 +93,6 @@ public class ClientServerGemFireOperationsSessionRepositoryIntegrationTests exte private static final String TEST_SESSION_REGION_NAME = "TestClientServerSessions"; @Autowired - @SuppressWarnings("all") private SessionEventListener sessionEventListener; @BeforeClass @@ -242,7 +241,7 @@ public class ClientServerGemFireOperationsSessionRepositoryIntegrationTests exte static class TestGemFireServerConfiguration { @SuppressWarnings("resource") - public static void main(String[] args) throws IOException { + public static void main(String[] args) { AnnotationConfigApplicationContext applicationContext = new AnnotationConfigApplicationContext(TestGemFireServerConfiguration.class); diff --git a/spring-session-data-geode/src/integration-test/java/org/springframework/session/data/gemfire/MultiPoolClientServerGemFireOperationsSessionRepositoryIntegrationTests.java b/spring-session-data-geode/src/integration-test/java/org/springframework/session/data/gemfire/MultiPoolClientServerGemFireOperationsSessionRepositoryIntegrationTests.java index 36c753e..162c775 100644 --- a/spring-session-data-geode/src/integration-test/java/org/springframework/session/data/gemfire/MultiPoolClientServerGemFireOperationsSessionRepositoryIntegrationTests.java +++ b/spring-session-data-geode/src/integration-test/java/org/springframework/session/data/gemfire/MultiPoolClientServerGemFireOperationsSessionRepositoryIntegrationTests.java @@ -13,7 +13,6 @@ * See the License for the specific language governing permissions and * limitations under the License. */ - package org.springframework.session.data.gemfire; import static org.assertj.core.api.Assertions.assertThat; @@ -84,7 +83,7 @@ public class MultiPoolClientServerGemFireOperationsSessionRepositoryIntegrationT private static final String SPRING_SESSION_GEMFIRE_REGION_NAME = "TestMultiPoolClientServerSessions"; - @Autowired @SuppressWarnings("all") + @Autowired private SessionEventListener sessionEventListener; @BeforeClass @@ -208,7 +207,7 @@ public class MultiPoolClientServerGemFireOperationsSessionRepositoryIntegrationT static class SpringSessionDataGemFireServerConfiguration { @SuppressWarnings("resource") - public static void main(final String[] args) throws IOException { + public static void main(final String[] args) { AnnotationConfigApplicationContext context = new AnnotationConfigApplicationContext( SpringSessionDataGemFireServerConfiguration.class); diff --git a/spring-session-data-geode/src/integration-test/java/org/springframework/session/data/gemfire/MultiThreadedClientServerHttpSessionAttributesDeltaIntegrationTests.java b/spring-session-data-geode/src/integration-test/java/org/springframework/session/data/gemfire/MultiThreadedClientServerHttpSessionAttributesDeltaIntegrationTests.java index 58e83f1..bd5c9c5 100644 --- a/spring-session-data-geode/src/integration-test/java/org/springframework/session/data/gemfire/MultiThreadedClientServerHttpSessionAttributesDeltaIntegrationTests.java +++ b/spring-session-data-geode/src/integration-test/java/org/springframework/session/data/gemfire/MultiThreadedClientServerHttpSessionAttributesDeltaIntegrationTests.java @@ -13,7 +13,6 @@ * See the License for the specific language governing permissions and * limitations under the License. */ - package org.springframework.session.data.gemfire; import static org.assertj.core.api.Assertions.assertThat; @@ -24,13 +23,13 @@ import java.io.IOException; import java.util.Optional; import java.util.concurrent.atomic.AtomicReference; +import edu.umd.cs.mtc.MultithreadedTestCase; +import edu.umd.cs.mtc.TestFramework; + import org.junit.BeforeClass; import org.junit.Test; import org.junit.runner.RunWith; -import edu.umd.cs.mtc.MultithreadedTestCase; -import edu.umd.cs.mtc.TestFramework; - import org.apache.geode.cache.client.ClientRegionShortcut; import org.springframework.context.annotation.AnnotationConfigApplicationContext; diff --git a/spring-session-data-geode/src/integration-test/java/org/springframework/session/data/gemfire/MultiThreadedLocalClientHttpSessionAttributesDeltaIntegrationTests.java b/spring-session-data-geode/src/integration-test/java/org/springframework/session/data/gemfire/MultiThreadedLocalClientHttpSessionAttributesDeltaIntegrationTests.java index e7e6022..8d57c36 100644 --- a/spring-session-data-geode/src/integration-test/java/org/springframework/session/data/gemfire/MultiThreadedLocalClientHttpSessionAttributesDeltaIntegrationTests.java +++ b/spring-session-data-geode/src/integration-test/java/org/springframework/session/data/gemfire/MultiThreadedLocalClientHttpSessionAttributesDeltaIntegrationTests.java @@ -13,19 +13,18 @@ * See the License for the specific language governing permissions and * limitations under the License. */ - package org.springframework.session.data.gemfire; import static org.assertj.core.api.Assertions.assertThat; import java.util.concurrent.atomic.AtomicReference; -import org.junit.Test; -import org.junit.runner.RunWith; - import edu.umd.cs.mtc.MultithreadedTestCase; import edu.umd.cs.mtc.TestFramework; +import org.junit.Test; +import org.junit.runner.RunWith; + import org.apache.geode.cache.client.ClientRegionShortcut; import org.springframework.data.gemfire.config.annotation.ClientCacheApplication; diff --git a/spring-session-data-geode/src/integration-test/java/org/springframework/session/data/gemfire/PeerCacheGemFireOperationsSessionRepositoryIntegrationTests.java b/spring-session-data-geode/src/integration-test/java/org/springframework/session/data/gemfire/PeerCacheGemFireOperationsSessionRepositoryIntegrationTests.java index eb80c25..06dc231 100644 --- a/spring-session-data-geode/src/integration-test/java/org/springframework/session/data/gemfire/PeerCacheGemFireOperationsSessionRepositoryIntegrationTests.java +++ b/spring-session-data-geode/src/integration-test/java/org/springframework/session/data/gemfire/PeerCacheGemFireOperationsSessionRepositoryIntegrationTests.java @@ -13,7 +13,6 @@ * See the License for the specific language governing permissions and * limitations under the License. */ - package org.springframework.session.data.gemfire; import static org.assertj.core.api.Assertions.assertThat; @@ -324,6 +323,7 @@ public class PeerCacheGemFireOperationsSessionRepositoryIntegrationTests extends } @Test + @SuppressWarnings("rawtypes") public void saveAndReadSessionWithAttributes() { Session expectedSession = this.gemfireSessionRepository.createSession(); @@ -415,7 +415,6 @@ public class PeerCacheGemFireOperationsSessionRepositoryIntegrationTests extends this.lastName = pdxReader.readString("lastName"); } - @SuppressWarnings("all") public int compareTo(Person person) { int compareValue = getLastName().compareTo(person.getLastName()); diff --git a/spring-session-data-geode/src/integration-test/java/org/springframework/session/data/gemfire/config/annotation/web/http/ConfigurerBasedGemFireHttpSessionConfigurationIntegrationTests.java b/spring-session-data-geode/src/integration-test/java/org/springframework/session/data/gemfire/config/annotation/web/http/ConfigurerBasedGemFireHttpSessionConfigurationIntegrationTests.java index d2e6dfe..53089cc 100644 --- a/spring-session-data-geode/src/integration-test/java/org/springframework/session/data/gemfire/config/annotation/web/http/ConfigurerBasedGemFireHttpSessionConfigurationIntegrationTests.java +++ b/spring-session-data-geode/src/integration-test/java/org/springframework/session/data/gemfire/config/annotation/web/http/ConfigurerBasedGemFireHttpSessionConfigurationIntegrationTests.java @@ -46,7 +46,7 @@ import org.springframework.session.data.gemfire.expiration.SessionExpirationPoli import org.springframework.session.data.gemfire.serialization.SessionSerializer; /** - * Integration tests testing {@link SpringSessionGemFireConfigurer} based configuration of either Apache Geode + * Integration Tests testing {@link SpringSessionGemFireConfigurer} based configuration of either Apache Geode * or Pivotal GemFire as the (HTTP) {@link Session} state management provider in Spring Session. * * @author John Blum @@ -173,7 +173,6 @@ public class ConfigurerBasedGemFireHttpSessionConfigurationIntegrationTests exte } @ClientCacheApplication - @EnableGemFireMockObjects @EnableGemFireHttpSession( clientRegionShortcut = ClientRegionShortcut.LOCAL, indexableSessionAttributes = { "one", "two" }, @@ -184,6 +183,7 @@ public class ConfigurerBasedGemFireHttpSessionConfigurationIntegrationTests exte sessionExpirationPolicyBeanName = "TestSessionExpirationPolicy", sessionSerializerBeanName = "TestSessionSerializer" ) + @EnableGemFireMockObjects static class TestConfiguration { @Bean("Car") diff --git a/spring-session-data-geode/src/integration-test/java/org/springframework/session/data/gemfire/config/annotation/web/http/ExposingSpringSessionGemFireConfigurationIntegrationTests.java b/spring-session-data-geode/src/integration-test/java/org/springframework/session/data/gemfire/config/annotation/web/http/ExposingSpringSessionGemFireConfigurationIntegrationTests.java index be87a48..60549d0 100644 --- a/spring-session-data-geode/src/integration-test/java/org/springframework/session/data/gemfire/config/annotation/web/http/ExposingSpringSessionGemFireConfigurationIntegrationTests.java +++ b/spring-session-data-geode/src/integration-test/java/org/springframework/session/data/gemfire/config/annotation/web/http/ExposingSpringSessionGemFireConfigurationIntegrationTests.java @@ -13,7 +13,6 @@ * See the License for the specific language governing permissions and * limitations under the License. */ - package org.springframework.session.data.gemfire.config.annotation.web.http; import static org.assertj.core.api.Assertions.assertThat; @@ -44,9 +43,19 @@ import org.springframework.session.data.gemfire.expiration.SessionExpirationPoli import org.springframework.session.data.gemfire.serialization.SessionSerializer; /** - * The ExposingSpringSessionGemFireConfigurationIntegrationTests class... + * Integration Tests asserting the correct behavior when exposing Spring Session configuration metadata at runtime. * * @author John Blum + * @see org.junit.Test + * @see org.springframework.context.ConfigurableApplicationContext + * @see org.springframework.context.annotation.Bean + * @see org.springframework.context.annotation.Configuration + * @see org.springframework.core.env.Environment + * @see org.springframework.core.env.PropertySource + * @see org.springframework.data.gemfire.config.annotation.ClientCacheApplication + * @see org.springframework.data.gemfire.tests.mock.annotation.EnableGemFireMockObjects + * @see org.springframework.session.data.gemfire.AbstractGemFireIntegrationTests + * @see org.springframework.session.data.gemfire.config.annotation.web.http.support.SpringSessionGemFireConfigurer * @since 1.0.0 */ @SuppressWarnings("unused") @@ -251,7 +260,6 @@ public class ExposingSpringSessionGemFireConfigurationIntegrationTests extends A } @ClientCacheApplication - @EnableGemFireMockObjects @EnableGemFireHttpSession( clientRegionShortcut = ClientRegionShortcut.LOCAL, exposeConfigurationAsProperties = true, @@ -263,7 +271,7 @@ public class ExposingSpringSessionGemFireConfigurationIntegrationTests extends A sessionExpirationPolicyBeanName = "AttributeSessionExpirationPolicy", sessionSerializerBeanName = "AttributeSessionSerializer" ) - @SuppressWarnings("unused") + @EnableGemFireMockObjects static class TestGemFireHttpSessionConfiguration { @Bean("Car") @@ -292,11 +300,13 @@ public class ExposingSpringSessionGemFireConfigurationIntegrationTests extends A } @Bean("AttributeSessionSerializer") + @SuppressWarnings("rawtypes") SessionSerializer attributeSessionSerializer() { return mock(SessionSerializer.class); } @Bean("PropertySessionSerializer") + @SuppressWarnings("rawtypes") SessionSerializer propertySessionSerializer() { return mock(SessionSerializer.class); } @@ -316,6 +326,7 @@ public class ExposingSpringSessionGemFireConfigurationIntegrationTests extends A } @Bean("ConfigurerSessionSerializer") + @SuppressWarnings("rawtypes") SessionSerializer configurerSessionSerializer() { return mock(SessionSerializer.class); } @@ -378,6 +389,7 @@ public class ExposingSpringSessionGemFireConfigurationIntegrationTests extends A static class MockSpringSessionGemFirerConfigurerConfiguration { @Bean("ConfigurerSessionSerializer") + @SuppressWarnings("rawtypes") SessionSerializer configurerSessionSerializer() { return mock(SessionSerializer.class); } @@ -399,6 +411,7 @@ public class ExposingSpringSessionGemFireConfigurationIntegrationTests extends A } @Bean("ConfigurerSessionSerializer") + @SuppressWarnings("rawtypes") SessionSerializer configurerSessionSerializer() { return mock(SessionSerializer.class); } diff --git a/spring-session-data-geode/src/integration-test/java/org/springframework/session/data/gemfire/config/annotation/web/http/GemFireHttpSessionConfigurationIntegrationTests.java b/spring-session-data-geode/src/integration-test/java/org/springframework/session/data/gemfire/config/annotation/web/http/GemFireHttpSessionConfigurationIntegrationTests.java index bd20281..187abca 100644 --- a/spring-session-data-geode/src/integration-test/java/org/springframework/session/data/gemfire/config/annotation/web/http/GemFireHttpSessionConfigurationIntegrationTests.java +++ b/spring-session-data-geode/src/integration-test/java/org/springframework/session/data/gemfire/config/annotation/web/http/GemFireHttpSessionConfigurationIntegrationTests.java @@ -168,6 +168,7 @@ public class GemFireHttpSessionConfigurationIntegrationTests extends SpringAppli } @Test + @SuppressWarnings("rawtypes") public void notUsingDataSerializationWhenPdxConfigured() { newApplicationContext(TestSessionSerializerConfiguration.class); @@ -240,6 +241,7 @@ public class GemFireHttpSessionConfigurationIntegrationTests extends SpringAppli } @Bean("MockSessionSerializer") + @SuppressWarnings("rawtypes") SessionSerializer mockSessionSerializer() { return mock(SessionSerializer.class); } @@ -325,6 +327,7 @@ public class GemFireHttpSessionConfigurationIntegrationTests extends SpringAppli static class TestSessionSerializerConfiguration { @Bean("TestSessionSerializer") + @SuppressWarnings("rawtypes") SessionSerializer testSessionSerializer() { return mock(SessionSerializer.class); } diff --git a/spring-session-data-geode/src/integration-test/java/org/springframework/session/data/gemfire/config/annotation/web/http/PropertyBasedGemFireHttpSessionConfigurationIntegrationTests.java b/spring-session-data-geode/src/integration-test/java/org/springframework/session/data/gemfire/config/annotation/web/http/PropertyBasedGemFireHttpSessionConfigurationIntegrationTests.java index 29867e8..d73e3e2 100644 --- a/spring-session-data-geode/src/integration-test/java/org/springframework/session/data/gemfire/config/annotation/web/http/PropertyBasedGemFireHttpSessionConfigurationIntegrationTests.java +++ b/spring-session-data-geode/src/integration-test/java/org/springframework/session/data/gemfire/config/annotation/web/http/PropertyBasedGemFireHttpSessionConfigurationIntegrationTests.java @@ -13,7 +13,6 @@ * See the License for the specific language governing permissions and * limitations under the License. */ - package org.springframework.session.data.gemfire.config.annotation.web.http; import static org.assertj.core.api.Assertions.assertThat; @@ -41,7 +40,7 @@ import org.springframework.session.data.gemfire.expiration.SessionExpirationPoli import org.springframework.session.data.gemfire.serialization.SessionSerializer; /** - * Integration tests testing property-based configuration of either Apache Geode or Pivotal GemFire + * Integration Tests testing property-based configuration of either Apache Geode or Pivotal GemFire * as the (HTTP) {@link Session} state management provider in Spring Session. * * @author John Blum @@ -156,7 +155,6 @@ public class PropertyBasedGemFireHttpSessionConfigurationIntegrationTests extend } @ClientCacheApplication - @EnableGemFireMockObjects @EnableGemFireHttpSession( clientRegionShortcut = ClientRegionShortcut.LOCAL, indexableSessionAttributes = { "one", "two" }, @@ -167,6 +165,7 @@ public class PropertyBasedGemFireHttpSessionConfigurationIntegrationTests extend sessionExpirationPolicyBeanName = "TestSessionExpirationPolicy", sessionSerializerBeanName = "TestSessionSerializer" ) + @EnableGemFireMockObjects static class TestConfiguration { @Bean("Dead") diff --git a/spring-session-data-geode/src/integration-test/java/org/springframework/session/data/gemfire/expiration/CustomSessionExpirationConfigurationIntegrationTests.java b/spring-session-data-geode/src/integration-test/java/org/springframework/session/data/gemfire/expiration/CustomSessionExpirationConfigurationIntegrationTests.java index 91e14ba..590361d 100644 --- a/spring-session-data-geode/src/integration-test/java/org/springframework/session/data/gemfire/expiration/CustomSessionExpirationConfigurationIntegrationTests.java +++ b/spring-session-data-geode/src/integration-test/java/org/springframework/session/data/gemfire/expiration/CustomSessionExpirationConfigurationIntegrationTests.java @@ -13,7 +13,6 @@ * See the License for the specific language governing permissions and * limitations under the License. */ - package org.springframework.session.data.gemfire.expiration; import static org.assertj.core.api.Assertions.assertThat; @@ -47,7 +46,7 @@ import org.springframework.test.context.junit4.SpringRunner; import org.springframework.util.ReflectionUtils; /** - * Integration tests for {@link EnableGemFireHttpSession} and {@link GemFireHttpSessionConfiguration} + * Integration Tests for {@link EnableGemFireHttpSession} and {@link GemFireHttpSessionConfiguration} * involving {@link Session} expiration configuration. * * @author John Blum diff --git a/spring-session-data-geode/src/integration-test/java/org/springframework/session/data/gemfire/expiration/LazyTimeoutSessionExpirationIntegrationTests.java b/spring-session-data-geode/src/integration-test/java/org/springframework/session/data/gemfire/expiration/LazyTimeoutSessionExpirationIntegrationTests.java index 4e0f772..00c5691 100644 --- a/spring-session-data-geode/src/integration-test/java/org/springframework/session/data/gemfire/expiration/LazyTimeoutSessionExpirationIntegrationTests.java +++ b/spring-session-data-geode/src/integration-test/java/org/springframework/session/data/gemfire/expiration/LazyTimeoutSessionExpirationIntegrationTests.java @@ -13,7 +13,6 @@ * See the License for the specific language governing permissions and * limitations under the License. */ - package org.springframework.session.data.gemfire.expiration; import static org.assertj.core.api.Assertions.assertThat; @@ -36,7 +35,7 @@ import org.springframework.test.context.ContextConfiguration; import org.springframework.test.context.junit4.SpringRunner; /** - * Integration tests asserting lazy expiration timeouts on {@link Session} access + * Integration Tests asserting lazy expiration timeouts on {@link Session} access * using {@link FixedDurationExpirationSessionRepository}. * * @author John Blum @@ -58,7 +57,7 @@ import org.springframework.test.context.junit4.SpringRunner; public class LazyTimeoutSessionExpirationIntegrationTests extends AbstractGemFireIntegrationTests { @Test - @SuppressWarnings("unchecked") + @SuppressWarnings({ "rawtypes", "unchecked" }) public void sessionRepositoryIsAFixedDurationExpirationSessionRepository() { assertThat(this.getSessionRepository()) diff --git a/spring-session-data-geode/src/integration-test/java/org/springframework/session/data/gemfire/support/CustomIsDirtyPredicateIntegrationTests.java b/spring-session-data-geode/src/integration-test/java/org/springframework/session/data/gemfire/support/CustomIsDirtyPredicateIntegrationTests.java index 4d125f4..e822683 100644 --- a/spring-session-data-geode/src/integration-test/java/org/springframework/session/data/gemfire/support/CustomIsDirtyPredicateIntegrationTests.java +++ b/spring-session-data-geode/src/integration-test/java/org/springframework/session/data/gemfire/support/CustomIsDirtyPredicateIntegrationTests.java @@ -13,7 +13,6 @@ * See the License for the specific language governing permissions and * limitations under the License. */ - package org.springframework.session.data.gemfire.support; import static org.assertj.core.api.Assertions.assertThat; @@ -34,10 +33,13 @@ import org.springframework.test.context.ContextConfiguration; import org.springframework.test.context.junit4.SpringRunner; /** - * The CustomIsDirtyPredicateIntegrationTests class... + * Integration Tests for custom {@link IsDirtyPredicate}. * * @author John Blum - * @since 1.0.0 + * @see org.junit.Test + * @see org.springframework.session.data.gemfire.support.IsDirtyPredicate + * @see org.springframework.session.data.gemfire.AbstractGemFireIntegrationTests + * @since 2.1.2 */ @RunWith(SpringRunner.class) @ContextConfiguration diff --git a/spring-session-data-geode/src/test/java/org/springframework/session/data/gemfire/config/annotation/web/http/GemFireHttpSessionConfigurationUnitTests.java b/spring-session-data-geode/src/test/java/org/springframework/session/data/gemfire/config/annotation/web/http/GemFireHttpSessionConfigurationUnitTests.java index 8b2ecba..990ca5c 100644 --- a/spring-session-data-geode/src/test/java/org/springframework/session/data/gemfire/config/annotation/web/http/GemFireHttpSessionConfigurationUnitTests.java +++ b/spring-session-data-geode/src/test/java/org/springframework/session/data/gemfire/config/annotation/web/http/GemFireHttpSessionConfigurationUnitTests.java @@ -121,7 +121,7 @@ public class GemFireHttpSessionConfigurationUnitTests { return resolveField(obj.getClass(), fieldName); } - private static Field resolveField(Class type, String fieldName) throws NoSuchFieldException { + private static Field resolveField(Class type, String fieldName) throws NoSuchFieldException { Field field = ReflectionUtils.findField(type, fieldName); @@ -149,7 +149,6 @@ public class GemFireHttpSessionConfigurationUnitTests { } @Test - @SuppressWarnings("all") public void setAndGetBeanClassLoader() { assertThat(this.gemfireConfiguration.getBeanClassLoader()).isNull(); @@ -548,6 +547,7 @@ public class GemFireHttpSessionConfigurationUnitTests { } @Test + @SuppressWarnings({ "rawtypes" }) public void exposeSpringSessionGemFireConfigurationAsPropertiesMutatesSpringEnvironment() { ConfigurableEnvironment environment = new StandardEnvironment(); @@ -613,7 +613,6 @@ public class GemFireHttpSessionConfigurationUnitTests { } @Test - @SuppressWarnings("all") public void exposeSpringSessionGemFireConfigurationAsPropertiesIsNullSafe() { this.gemfireConfiguration.setEnvironment(null); @@ -771,7 +770,7 @@ public class GemFireHttpSessionConfigurationUnitTests { } @Test - @SuppressWarnings("unchecked") + @SuppressWarnings({ "rawtypes", "unchecked" }) public void createsAndInitializesSessionRegionAttributesWithExpiration() throws Exception { Cache mockCache = mock(Cache.class); @@ -802,7 +801,7 @@ public class GemFireHttpSessionConfigurationUnitTests { } @Test - @SuppressWarnings("unchecked") + @SuppressWarnings({ "rawtypes", "unchecked" }) public void createsAndInitializesSessionRegionAttributesWithoutExpiration() throws Exception { ClientCache mockClientCache = mock(ClientCache.class); diff --git a/spring-session-data-geode/src/test/java/org/springframework/session/data/gemfire/config/annotation/web/http/support/SessionAttributesIndexFactoryBeanTests.java b/spring-session-data-geode/src/test/java/org/springframework/session/data/gemfire/config/annotation/web/http/support/SessionAttributesIndexFactoryBeanTests.java index 898ddf2..107587b 100644 --- a/spring-session-data-geode/src/test/java/org/springframework/session/data/gemfire/config/annotation/web/http/support/SessionAttributesIndexFactoryBeanTests.java +++ b/spring-session-data-geode/src/test/java/org/springframework/session/data/gemfire/config/annotation/web/http/support/SessionAttributesIndexFactoryBeanTests.java @@ -13,7 +13,6 @@ * See the License for the specific language governing permissions and * limitations under the License. */ - package org.springframework.session.data.gemfire.config.annotation.web.http.support; import static org.assertj.core.api.Assertions.assertThat; @@ -38,6 +37,7 @@ import org.springframework.session.data.gemfire.config.annotation.web.http.GemFi */ public class SessionAttributesIndexFactoryBeanTests { + @SuppressWarnings("unchecked") static T[] toArray(T... array) { return array; } @@ -51,11 +51,13 @@ public class SessionAttributesIndexFactoryBeanTests { @Test public void indexIsNotInitializedWhenNoIndexableSessionAttributesAreConfigured() throws Exception { + final Index mockIndex = mock(Index.class); SessionAttributesIndexFactoryBean indexFactoryBean = new SessionAttributesIndexFactoryBean() { + @Override - protected Index newIndex() throws Exception { + protected Index newIndex() { return mockIndex; } }; @@ -68,11 +70,13 @@ public class SessionAttributesIndexFactoryBeanTests { @Test public void initializesIndexWhenIndexableSessionAttributesAreConfigured() throws Exception { + final Index mockIndex = mock(Index.class); SessionAttributesIndexFactoryBean indexFactoryBean = new SessionAttributesIndexFactoryBean() { + @Override - protected Index newIndex() throws Exception { + protected Index newIndex() { return mockIndex; } }; diff --git a/spring-session-data-geode/src/test/java/org/springframework/session/data/gemfire/config/annotation/web/http/support/SessionCacheTypeAwareRegionFactoryBeanTests.java b/spring-session-data-geode/src/test/java/org/springframework/session/data/gemfire/config/annotation/web/http/support/SessionCacheTypeAwareRegionFactoryBeanTests.java index 81ff353..a4682b0 100644 --- a/spring-session-data-geode/src/test/java/org/springframework/session/data/gemfire/config/annotation/web/http/support/SessionCacheTypeAwareRegionFactoryBeanTests.java +++ b/spring-session-data-geode/src/test/java/org/springframework/session/data/gemfire/config/annotation/web/http/support/SessionCacheTypeAwareRegionFactoryBeanTests.java @@ -13,7 +13,6 @@ * See the License for the specific language governing permissions and * limitations under the License. */ - package org.springframework.session.data.gemfire.config.annotation.web.http.support; import static org.assertj.core.api.Assertions.assertThat; @@ -36,7 +35,7 @@ import org.springframework.beans.factory.BeanFactory; import org.springframework.session.Session; /** - * Unit tests for {@link SessionCacheTypeAwareRegionFactoryBean}. + * Unit Tests for {@link SessionCacheTypeAwareRegionFactoryBean}. * * @author John Blum * @see org.junit.Test @@ -79,13 +78,13 @@ public class SessionCacheTypeAwareRegionFactoryBeanTests { this.regionFactoryBean = new SessionCacheTypeAwareRegionFactoryBean() { @Override - protected Region newClientRegion(GemFireCache gemfireCache, String name) throws Exception { + protected Region newClientRegion(GemFireCache gemfireCache, String name) { assertThat(gemfireCache).isSameAs(expectedCache); return SessionCacheTypeAwareRegionFactoryBeanTests.this.mockClientRegion; } @Override - protected Region newServerRegion(GemFireCache gemfireCache, String name) throws Exception { + protected Region newServerRegion(GemFireCache gemfireCache, String name) { assertThat(gemfireCache).isSameAs(expectedCache); return SessionCacheTypeAwareRegionFactoryBeanTests.this.mockServerRegion; } diff --git a/spring-session-data-geode/src/test/java/org/springframework/session/data/gemfire/config/annotation/web/http/support/SpringSessionGemFireConfigurerUnitTests.java b/spring-session-data-geode/src/test/java/org/springframework/session/data/gemfire/config/annotation/web/http/support/SpringSessionGemFireConfigurerUnitTests.java index 95aa673..704d7eb 100644 --- a/spring-session-data-geode/src/test/java/org/springframework/session/data/gemfire/config/annotation/web/http/support/SpringSessionGemFireConfigurerUnitTests.java +++ b/spring-session-data-geode/src/test/java/org/springframework/session/data/gemfire/config/annotation/web/http/support/SpringSessionGemFireConfigurerUnitTests.java @@ -13,7 +13,6 @@ * See the License for the specific language governing permissions and * limitations under the License. */ - package org.springframework.session.data.gemfire.config.annotation.web.http.support; import static org.assertj.core.api.Assertions.assertThat; @@ -32,7 +31,7 @@ import org.apache.geode.cache.client.ClientRegionShortcut; import org.springframework.session.data.gemfire.config.annotation.web.http.GemFireHttpSessionConfiguration; /** - * Unit tests for {@link SpringSessionGemFireConfigurer}. + * Unit Tests for {@link SpringSessionGemFireConfigurer}. * * @author John Blum * @see org.junit.Test @@ -126,8 +125,7 @@ public class SpringSessionGemFireConfigurerUnitTests { return Arrays.stream(nullSafeArray(methods, Method.class)) .filter(method -> targetMethodNames.contains(method.getName())) - .collect(Collectors.toList()) - .toArray(new Method[0]); + .toArray(Method[]::new); } @Test