diff --git a/spring-session/src/main/java/org/springframework/session/config/annotation/web/http/SpringHttpSessionConfiguration.java b/spring-session/src/main/java/org/springframework/session/config/annotation/web/http/SpringHttpSessionConfiguration.java index b263460..bade59a 100644 --- a/spring-session/src/main/java/org/springframework/session/config/annotation/web/http/SpringHttpSessionConfiguration.java +++ b/spring-session/src/main/java/org/springframework/session/config/annotation/web/http/SpringHttpSessionConfiguration.java @@ -32,6 +32,7 @@ import org.springframework.session.events.SessionDestroyedEvent; import org.springframework.session.web.http.CookieHttpSessionStrategy; import org.springframework.session.web.http.CookieSerializer; import org.springframework.session.web.http.HttpSessionStrategy; +import org.springframework.session.web.http.MultiHttpSessionStrategy; import org.springframework.session.web.http.SessionEventHttpSessionListenerAdapter; import org.springframework.session.web.http.SessionRepositoryFilter; @@ -100,7 +101,11 @@ public class SpringHttpSessionConfiguration { public SessionRepositoryFilter springSessionRepositoryFilter(SessionRepository sessionRepository, ServletContext servletContext) { SessionRepositoryFilter sessionRepositoryFilter = new SessionRepositoryFilter(sessionRepository); sessionRepositoryFilter.setServletContext(servletContext); - sessionRepositoryFilter.setHttpSessionStrategy(httpSessionStrategy); + if(httpSessionStrategy instanceof MultiHttpSessionStrategy) { + sessionRepositoryFilter.setHttpSessionStrategy((MultiHttpSessionStrategy) httpSessionStrategy); + } else { + sessionRepositoryFilter.setHttpSessionStrategy(httpSessionStrategy); + } return sessionRepositoryFilter; } diff --git a/spring-session/src/test/java/org/springframework/session/config/annotation/web/http/EnableSpringHttpSessionCustomMultiHttpSessionStrategyTests.java b/spring-session/src/test/java/org/springframework/session/config/annotation/web/http/EnableSpringHttpSessionCustomMultiHttpSessionStrategyTests.java new file mode 100644 index 0000000..5d92c0e --- /dev/null +++ b/spring-session/src/test/java/org/springframework/session/config/annotation/web/http/EnableSpringHttpSessionCustomMultiHttpSessionStrategyTests.java @@ -0,0 +1,93 @@ +/* + * Copyright 2002-2015 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.springframework.session.config.annotation.web.http; + +import static org.mockito.Matchers.any; +import static org.mockito.Mockito.mock; +import static org.mockito.Mockito.verify; +import static org.mockito.Mockito.when; + +import javax.servlet.http.HttpServletRequest; +import javax.servlet.http.HttpServletResponse; + +import org.junit.Before; +import org.junit.Test; +import org.junit.runner.RunWith; +import org.springframework.beans.factory.annotation.Autowired; +import org.springframework.context.annotation.Bean; +import org.springframework.context.annotation.Configuration; +import org.springframework.mock.web.MockFilterChain; +import org.springframework.mock.web.MockHttpServletRequest; +import org.springframework.mock.web.MockHttpServletResponse; +import org.springframework.session.ExpiringSession; +import org.springframework.session.MapSessionRepository; +import org.springframework.session.web.http.MultiHttpSessionStrategy; +import org.springframework.session.web.http.SessionRepositoryFilter; +import org.springframework.test.context.ContextConfiguration; +import org.springframework.test.context.junit4.SpringJUnit4ClassRunner; +import org.springframework.test.context.web.WebAppConfiguration; + +/** + * @author Rob Winch + * + */ +@RunWith(SpringJUnit4ClassRunner.class) +@ContextConfiguration +@WebAppConfiguration +public class EnableSpringHttpSessionCustomMultiHttpSessionStrategyTests { + @Autowired + MockHttpServletRequest request; + @Autowired + MockHttpServletResponse response; + + MockFilterChain chain; + + @Autowired + SessionRepositoryFilter sessionRepositoryFilter; + + @Autowired + MultiHttpSessionStrategy strategy; + + @Before + public void setup() { + chain = new MockFilterChain(); + } + + @Test + public void wrapRequestAndResponseUsed() throws Exception { + when(strategy.wrapRequest(any(HttpServletRequest.class), any(HttpServletResponse.class))).thenReturn(request); + when(strategy.wrapResponse(any(HttpServletRequest.class), any(HttpServletResponse.class))).thenReturn(response); + + sessionRepositoryFilter.doFilter(request, response, chain); + + verify(strategy).wrapRequest(any(HttpServletRequest.class), any(HttpServletResponse.class)); + verify(strategy).wrapResponse(any(HttpServletRequest.class), any(HttpServletResponse.class)); + } + + @EnableSpringHttpSession + @Configuration + static class Config { + @Bean + public MapSessionRepository mapSessionRepository() { + return new MapSessionRepository(); + } + + @Bean + public MultiHttpSessionStrategy strategy() { + return mock(MultiHttpSessionStrategy.class); + } + } +}