From 802e0e714b55fad570a4ba7d96f9cea5105343d9 Mon Sep 17 00:00:00 2001 From: Alex Panchenko Date: Sat, 29 Oct 2016 13:32:36 +0700 Subject: [PATCH] close RedisConnection in EnableRedisKeyspaceNotificationsInitializer Issue gh-626 --- .../web/http/RedisHttpSessionConfiguration.java | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/spring-session/src/main/java/org/springframework/session/data/redis/config/annotation/web/http/RedisHttpSessionConfiguration.java b/spring-session/src/main/java/org/springframework/session/data/redis/config/annotation/web/http/RedisHttpSessionConfiguration.java index 98c2ef1..1c612da 100644 --- a/spring-session/src/main/java/org/springframework/session/data/redis/config/annotation/web/http/RedisHttpSessionConfiguration.java +++ b/spring-session/src/main/java/org/springframework/session/data/redis/config/annotation/web/http/RedisHttpSessionConfiguration.java @@ -20,6 +20,8 @@ import java.util.Arrays; import java.util.Map; import java.util.concurrent.Executor; +import org.apache.commons.logging.LogFactory; + import org.springframework.beans.factory.InitializingBean; import org.springframework.beans.factory.annotation.Autowired; import org.springframework.beans.factory.annotation.Qualifier; @@ -234,7 +236,17 @@ public class RedisHttpSessionConfiguration extends SpringHttpSessionConfiguratio return; } RedisConnection connection = this.connectionFactory.getConnection(); - this.configure.configure(connection); + try { + this.configure.configure(connection); + } + finally { + try { + connection.close(); + } + catch (Exception e) { + LogFactory.getLog(getClass()).error("Error closing RedisConnection", e); + } + } } }