From 9df05945732b282fdb3d9b9c0b78871db9bec58f Mon Sep 17 00:00:00 2001
From: Rob Winch <rwinch@gopivotal.com>
Date: Fri, 14 Nov 2014 21:00:01 -0600
Subject: [PATCH] Polish RedisOperationsSessionRepository ConnectionFactory
 Constructor

Add test and remove unnecessary comment.

Relates to gh-61
---
 .../redis/RedisOperationsSessionRepository.java |  2 +-
 .../RedisOperationsSessionRepositoryTests.java  | 17 +++++++++++++++++
 2 files changed, 18 insertions(+), 1 deletion(-)

diff --git a/spring-session/src/main/java/org/springframework/session/data/redis/RedisOperationsSessionRepository.java b/spring-session/src/main/java/org/springframework/session/data/redis/RedisOperationsSessionRepository.java
index 8b49619..8a6c032 100644
--- a/spring-session/src/main/java/org/springframework/session/data/redis/RedisOperationsSessionRepository.java
+++ b/spring-session/src/main/java/org/springframework/session/data/redis/RedisOperationsSessionRepository.java
@@ -298,7 +298,7 @@ public class RedisOperationsSessionRepository implements SessionRepository<Redis
         template.setKeySerializer(new StringRedisSerializer());
         template.setHashKeySerializer(new StringRedisSerializer());
         template.setConnectionFactory(connectionFactory);
-        template.afterPropertiesSet(); //Force initialization of default values
+        template.afterPropertiesSet();
         return template;
     }
 
diff --git a/spring-session/src/test/java/org/springframework/session/data/redis/RedisOperationsSessionRepositoryTests.java b/spring-session/src/test/java/org/springframework/session/data/redis/RedisOperationsSessionRepositoryTests.java
index 0815954..ae3822b 100644
--- a/spring-session/src/test/java/org/springframework/session/data/redis/RedisOperationsSessionRepositoryTests.java
+++ b/spring-session/src/test/java/org/springframework/session/data/redis/RedisOperationsSessionRepositoryTests.java
@@ -23,6 +23,8 @@ import org.mockito.ArgumentCaptor;
 import org.mockito.Captor;
 import org.mockito.Mock;
 import org.mockito.runners.MockitoJUnitRunner;
+import org.springframework.data.redis.connection.RedisConnection;
+import org.springframework.data.redis.connection.RedisConnectionFactory;
 import org.springframework.data.redis.core.BoundHashOperations;
 import org.springframework.data.redis.core.BoundSetOperations;
 import org.springframework.data.redis.core.RedisOperations;
@@ -33,6 +35,10 @@ import org.springframework.session.data.redis.RedisOperationsSessionRepository.R
 
 @RunWith(MockitoJUnitRunner.class)
 public class RedisOperationsSessionRepositoryTests {
+    @Mock
+    RedisConnectionFactory factory;
+    @Mock
+    RedisConnection connection;
     @Mock
     RedisOperations<String,ExpiringSession> redisOperations;
     @Mock
@@ -58,6 +64,17 @@ public class RedisOperationsSessionRepositoryTests {
         new RedisOperationsSessionRepository(null);
     }
 
+    // gh-61
+    @Test
+    public void constructorConnectionFactory() {
+        redisRepository = new RedisOperationsSessionRepository(factory);
+        RedisSession session = redisRepository.createSession();
+
+        when(factory.getConnection()).thenReturn(connection);
+
+        redisRepository.save(session);
+    }
+
     @Test
     public void createSessionDefaultMaxInactiveInterval() throws Exception {
         ExpiringSession session = redisRepository.createSession();