From dc553104c63af9b8c1d28c15b11ab7b60c95151a Mon Sep 17 00:00:00 2001 From: Rob Winch Date: Wed, 29 Jun 2016 16:24:52 -0500 Subject: [PATCH] Fix SessionRepositoryFilterTests doFilterLastAccessedTime assertion Relax the assertion so that it is not exact to avoid timing issues. Fixes gh-519 --- .../session/web/http/SessionRepositoryFilterTests.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/spring-session/src/test/java/org/springframework/session/web/http/SessionRepositoryFilterTests.java b/spring-session/src/test/java/org/springframework/session/web/http/SessionRepositoryFilterTests.java index ce3075c..d105cbf 100644 --- a/spring-session/src/test/java/org/springframework/session/web/http/SessionRepositoryFilterTests.java +++ b/spring-session/src/test/java/org/springframework/session/web/http/SessionRepositoryFilterTests.java @@ -35,6 +35,7 @@ import javax.servlet.http.HttpServletResponse; import javax.servlet.http.HttpSession; import javax.servlet.http.HttpSessionContext; +import org.assertj.core.data.Offset; import org.junit.Before; import org.junit.Test; import org.junit.runner.RunWith; @@ -150,8 +151,8 @@ public class SessionRepositoryFilterTests { @Override public void doFilter(HttpServletRequest wrappedRequest) { long lastAccessed = wrappedRequest.getSession().getLastAccessedTime(); - assertThat(lastAccessed) - .isEqualTo(wrappedRequest.getSession().getCreationTime()); + assertThat(lastAccessed).isCloseTo( + wrappedRequest.getSession().getCreationTime(), Offset.offset(5L)); SessionRepositoryFilterTests.this.request.setAttribute(ACCESS_ATTR, lastAccessed); }