Spring/spring-session
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Polish RuntimeHintsRegistrar

Browse Source 
Add RuntimeHints suffix to classes
Make classes package-private
Use ReflectionUtilsPredicates#serialization

Closes gh-2111
Closes gh-2112
This commit is contained in:
Marcus Da Coregio
2022-07-13 10:30:46 -03:00
parent 374ea4a432
commit 65b994cad1
11 changed files with 40 additions and 112 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
spring-session-jdbc/src/main/java/org/springframework/session/jdbc/aot/hint/SessionJdbcSecurityHints.java → spring-session-jdbc/src/main/java/org/springframework/session/jdbc/aot/hint/SessionJdbcRuntimeHints.java
View File

@@ -26,7 +26,7 @@ import org.springframework.aot.hint.TypeReference;
*
* @author Marcus Da Coregio
*/
public class SessionJdbcSecurityHints implements RuntimeHintsRegistrar {
class SessionJdbcRuntimeHints implements RuntimeHintsRegistrar {
@Override
public void registerHints(RuntimeHints hints, ClassLoader classLoader) {

2
spring-session-jdbc/src/main/resources/META-INF/spring/aot.factories
View File

@@ -1,2 +1,2 @@
org.springframework.aot.hint.RuntimeHintsRegistrar=\
org.springframework.session.jdbc.aot.hint.SessionJdbcSecurityHints
org.springframework.session.jdbc.aot.hint.SessionJdbcRuntimeHints

14
spring-session-jdbc/src/test/java/org/springframework/session/jdbc/aot/hint/SessionJdbcSecurityHintsTests.java → spring-session-jdbc/src/test/java/org/springframework/session/jdbc/aot/hint/SessionJdbcRuntimeHintsTests.java
View File

@@ -19,42 +19,42 @@ package org.springframework.session.jdbc.aot.hint;
import org.junit.jupiter.api.Test;
import org.springframework.aot.hint.RuntimeHints;
import org.springframework.aot.hint.RuntimeHintsPredicates;
import org.springframework.aot.hint.RuntimeHintsRegistrar;
import org.springframework.aot.hint.TypeReference;
import org.springframework.aot.hint.predicate.RuntimeHintsPredicates;
import org.springframework.core.io.support.SpringFactoriesLoader;
import static org.assertj.core.api.Assertions.assertThat;
/**
* Tests for {@link SessionJdbcSecurityHints}
* Tests for {@link SessionJdbcRuntimeHints}
*
* @author Marcus Da Coregio
*/
class SessionJdbcSecurityHintsTests {
class SessionJdbcRuntimeHintsTests {
private final RuntimeHints hints = new RuntimeHints();
private final SessionJdbcSecurityHints sessionJdbcSecurityHints = new SessionJdbcSecurityHints();
private final SessionJdbcRuntimeHints sessionJdbcRuntimeHints = new SessionJdbcRuntimeHints();
@Test
void aotFactoriesContainsRegistrar() {
boolean match = SpringFactoriesLoader.forResourceLocation("META-INF/spring/aot.factories")
.load(RuntimeHintsRegistrar.class).stream()
.anyMatch((registrar) -> registrar instanceof SessionJdbcSecurityHints);
.anyMatch((registrar) -> registrar instanceof SessionJdbcRuntimeHints);
assertThat(match).isTrue();
}
@Test
void jdbcSchemasHasHints() {
this.sessionJdbcSecurityHints.registerHints(this.hints, getClass().getClassLoader());
this.sessionJdbcRuntimeHints.registerHints(this.hints, getClass().getClassLoader());
assertThat(RuntimeHintsPredicates.resource().forResource("org/springframework/session/jdbc/schema.sql"))
.accepts(this.hints);
}
@Test
void dataSourceHasHints() {
this.sessionJdbcSecurityHints.registerHints(this.hints, getClass().getClassLoader());
this.sessionJdbcRuntimeHints.registerHints(this.hints, getClass().getClassLoader());
assertThat(RuntimeHintsPredicates.reflection().onType(TypeReference.of("javax.sql.DataSource")))
.accepts(this.hints);
}