From 7123df8656fc73f5b9172d75225f998de4b3e2c3 Mon Sep 17 00:00:00 2001 From: Vedran Pavic Date: Wed, 25 Jul 2018 22:03:19 +0200 Subject: [PATCH] Remove MapSession#setOriginalId Closes gh-1100 --- .../src/main/java/org/springframework/session/MapSession.java | 4 ---- .../org/springframework/session/MapSessionRepository.java | 1 - .../springframework/session/ReactiveMapSessionRepository.java | 1 - 3 files changed, 6 deletions(-) diff --git a/spring-session-core/src/main/java/org/springframework/session/MapSession.java b/spring-session-core/src/main/java/org/springframework/session/MapSession.java index bcfee250..dd5fde8a 100644 --- a/spring-session-core/src/main/java/org/springframework/session/MapSession.java +++ b/spring-session-core/src/main/java/org/springframework/session/MapSession.java @@ -132,10 +132,6 @@ public final class MapSession implements Session, Serializable { return this.originalId; } - void setOriginalId(String originalId) { - this.originalId = originalId; - } - @Override public String changeSessionId() { String changedId = generateId(); diff --git a/spring-session-core/src/main/java/org/springframework/session/MapSessionRepository.java b/spring-session-core/src/main/java/org/springframework/session/MapSessionRepository.java index 03762735..c18332c0 100644 --- a/spring-session-core/src/main/java/org/springframework/session/MapSessionRepository.java +++ b/spring-session-core/src/main/java/org/springframework/session/MapSessionRepository.java @@ -73,7 +73,6 @@ public class MapSessionRepository implements SessionRepository { public void save(MapSession session) { if (!session.getId().equals(session.getOriginalId())) { this.sessions.remove(session.getOriginalId()); - session.setOriginalId(session.getId()); } this.sessions.put(session.getId(), new MapSession(session)); } diff --git a/spring-session-core/src/main/java/org/springframework/session/ReactiveMapSessionRepository.java b/spring-session-core/src/main/java/org/springframework/session/ReactiveMapSessionRepository.java index d7287ae8..eb551051 100644 --- a/spring-session-core/src/main/java/org/springframework/session/ReactiveMapSessionRepository.java +++ b/spring-session-core/src/main/java/org/springframework/session/ReactiveMapSessionRepository.java @@ -76,7 +76,6 @@ public class ReactiveMapSessionRepository implements ReactiveSessionRepository { if (!session.getId().equals(session.getOriginalId())) { this.sessions.remove(session.getOriginalId()); - session.setOriginalId(session.getId()); } this.sessions.put(session.getId(), new MapSession(session)); });