From db31527c8c318aa4152aac879559144fa1d515db Mon Sep 17 00:00:00 2001 From: Vedran Pavic Date: Tue, 24 Jul 2018 23:36:16 +0200 Subject: [PATCH] Add logging for errors decoding Base64 cookies Closes gh-1117 --- .../session/web/http/DefaultCookieSerializer.java | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/spring-session-core/src/main/java/org/springframework/session/web/http/DefaultCookieSerializer.java b/spring-session-core/src/main/java/org/springframework/session/web/http/DefaultCookieSerializer.java index 127be87f..427a4129 100644 --- a/spring-session-core/src/main/java/org/springframework/session/web/http/DefaultCookieSerializer.java +++ b/spring-session-core/src/main/java/org/springframework/session/web/http/DefaultCookieSerializer.java @@ -26,6 +26,9 @@ import javax.servlet.http.Cookie; import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletResponse; +import org.apache.commons.logging.Log; +import org.apache.commons.logging.LogFactory; + /** * The default implementation of {@link CookieSerializer}. * @@ -36,6 +39,8 @@ import javax.servlet.http.HttpServletResponse; */ public class DefaultCookieSerializer implements CookieSerializer { + private static final Log logger = LogFactory.getLog(DefaultCookieSerializer.class); + private String cookieName = "SESSION"; private Boolean useSecureCookie; @@ -141,6 +146,7 @@ public class DefaultCookieSerializer implements CookieSerializer { return new String(decodedCookieBytes); } catch (Exception ex) { + logger.debug("Unable to Base64 decode value: " + base64Value); return null; } }