From e3c6fb67f20eded1cbfbb02fcfe4a6082e4bdd46 Mon Sep 17 00:00:00 2001 From: Vedran Pavic Date: Tue, 30 May 2017 22:40:28 +0200 Subject: [PATCH] Replace `StringBuffer` usages with `StringBuilder` Fixes gh-718 --- .../web/http/CookieHttpSessionStrategy.java | 14 +++++++------- .../web/http/CookieHttpSessionStrategyTests.java | 12 ++++++------ 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/spring-session/src/main/java/org/springframework/session/web/http/CookieHttpSessionStrategy.java b/spring-session/src/main/java/org/springframework/session/web/http/CookieHttpSessionStrategy.java index b3a57b36..a3593c83 100644 --- a/spring-session/src/main/java/org/springframework/session/web/http/CookieHttpSessionStrategy.java +++ b/spring-session/src/main/java/org/springframework/session/web/http/CookieHttpSessionStrategy.java @@ -251,18 +251,18 @@ public final class CookieHttpSessionStrategy return sessionIds.values().iterator().next(); } - StringBuffer buffer = new StringBuffer(); + StringBuilder sb = new StringBuilder(); for (Map.Entry entry : sessionIds.entrySet()) { String alias = entry.getKey(); String id = entry.getValue(); - buffer.append(alias); - buffer.append(this.serializationDelimiter); - buffer.append(id); - buffer.append(this.serializationDelimiter); + sb.append(alias); + sb.append(this.serializationDelimiter); + sb.append(id); + sb.append(this.serializationDelimiter); } - buffer.deleteCharAt(buffer.length() - 1); - return buffer.toString(); + sb.deleteCharAt(sb.length() - 1); + return sb.toString(); } public void onInvalidateSession(HttpServletRequest request, diff --git a/spring-session/src/test/java/org/springframework/session/web/http/CookieHttpSessionStrategyTests.java b/spring-session/src/test/java/org/springframework/session/web/http/CookieHttpSessionStrategyTests.java index 3a84c04d..46f8e02c 100644 --- a/spring-session/src/test/java/org/springframework/session/web/http/CookieHttpSessionStrategyTests.java +++ b/spring-session/src/test/java/org/springframework/session/web/http/CookieHttpSessionStrategyTests.java @@ -705,19 +705,19 @@ public class CookieHttpSessionStrategyTests { } private String createSessionCookieValue(long size) { - StringBuffer buffer = new StringBuffer(); + StringBuilder sb = new StringBuilder(); for (long i = 0; i < size; i++) { String hex = Long.toHexString(i); - buffer.append(hex); - buffer.append(" "); - buffer.append(i); + sb.append(hex); + sb.append(" "); + sb.append(i); if (i < size - 1) { - buffer.append(" "); + sb.append(" "); } } - return buffer.toString(); + return sb.toString(); } public void setCookieName(String cookieName) {