code cleanup

remove non-Javadoc
eliminate useless constants interface
add some javadocs
This commit is contained in:
Costin Leau
2012-07-11 14:36:45 +03:00
parent 162a19fcc5
commit 011b614c63
13 changed files with 66 additions and 120 deletions

View File

@@ -15,13 +15,11 @@
*/
package org.springframework.shell.plugin.support;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertNotNull;
import org.junit.Test;
import org.springframework.shell.Constant;
import org.springframework.shell.plugin.HistoryFileNameProvider;
import static org.junit.Assert.*;
/**
* @author Jarred Li
*
@@ -36,7 +34,7 @@ public class DefaultHistoryFileProviderTest {
@Test
public void testGetHistoryFileName() {
assertNotNull(historyFile.getHistoryFileName());
assertEquals(Constant.HISTORY_FILE_NAME, historyFile.getHistoryFileName());
assertEquals("spring-shell.log", historyFile.getHistoryFileName());
}
}

View File

@@ -15,14 +15,13 @@
*/
package org.springframework.shell.plugin.support;
import static org.junit.Assert.assertEquals;
import org.junit.AfterClass;
import org.junit.BeforeClass;
import org.junit.Test;
import org.springframework.shell.Constant;
import org.springframework.shell.plugin.PromptProvider;
import static org.junit.Assert.*;
/**
* @author Jarred Li
*
@@ -49,11 +48,10 @@ public class DefaultPromptProviderTest {
/**
* Test method for {@link org.springframework.shell.plugin.support.DefaultPromptProvider#getPromptText()}.
* Test method for {@link org.springframework.shell.plugin.support.DefaultPromptProvider#getPrompt()}.
*/
@Test
public void testGetPromptText() {
assertEquals(Constant.COMMAND_LINE_PROMPT, prompt.getPromptText());
assertEquals("spring-shell>", prompt.getPrompt());
}
}