From 419f6a8aa40fa95c5e1b65d3a0b971e3d3230554 Mon Sep 17 00:00:00 2001 From: Janne Valkealahti Date: Fri, 3 May 2024 08:12:31 +0100 Subject: [PATCH] Fix DefaultShellApplicationRunner error handling - Let error from ShellRunner to pass through as that's needed for other error handling and used by exit code mappings - Relates #1057 --- .../shell/DefaultShellApplicationRunner.java | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/spring-shell-core/src/main/java/org/springframework/shell/DefaultShellApplicationRunner.java b/spring-shell-core/src/main/java/org/springframework/shell/DefaultShellApplicationRunner.java index 7d8dac91..e22d740c 100644 --- a/spring-shell-core/src/main/java/org/springframework/shell/DefaultShellApplicationRunner.java +++ b/spring-shell-core/src/main/java/org/springframework/shell/DefaultShellApplicationRunner.java @@ -61,11 +61,9 @@ public class DefaultShellApplicationRunner implements ShellApplicationRunner { String[] sourceArgs = args.getSourceArgs(); boolean canRun = false; for (ShellRunner runner : shellRunners) { - try { - canRun = runner.run(sourceArgs); - } catch (Exception e) { - break; - } + // let exception to get thrown as needed i.e. for + // exit code mappings + canRun = runner.run(sourceArgs); if (canRun) { break; }