From d38d0d46e03e64c768810a002e2b81bb93abac1c Mon Sep 17 00:00:00 2001 From: Janne Valkealahti Date: Fri, 16 Feb 2024 09:27:00 +0000 Subject: [PATCH] Fix wrong ProgressView ctor use - Fixes a bug so that given items are actually used - Relates #995 --- .../shell/component/view/control/ProgressView.java | 3 +-- .../shell/component/view/control/ProgressViewTests.java | 6 ++++++ 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/spring-shell-core/src/main/java/org/springframework/shell/component/view/control/ProgressView.java b/spring-shell-core/src/main/java/org/springframework/shell/component/view/control/ProgressView.java index 985ca103..4e405ba5 100644 --- a/spring-shell-core/src/main/java/org/springframework/shell/component/view/control/ProgressView.java +++ b/spring-shell-core/src/main/java/org/springframework/shell/component/view/control/ProgressView.java @@ -137,8 +137,7 @@ public class ProgressView extends BoxView { * @param items the progress view items */ public ProgressView(ProgressViewItem... items) { - this(0, 100, new ProgressViewItem[] { ProgressViewItem.ofText(), ProgressViewItem.ofSpinner(), - ProgressViewItem.ofPercent() }); + this(0, 100, items); } /** diff --git a/spring-shell-core/src/test/java/org/springframework/shell/component/view/control/ProgressViewTests.java b/spring-shell-core/src/test/java/org/springframework/shell/component/view/control/ProgressViewTests.java index 95a5fdf5..1c5f45da 100644 --- a/spring-shell-core/src/test/java/org/springframework/shell/component/view/control/ProgressViewTests.java +++ b/spring-shell-core/src/test/java/org/springframework/shell/component/view/control/ProgressViewTests.java @@ -61,6 +61,12 @@ public class ProgressViewTests extends AbstractViewTests { assertThat(getViewItems(view)).hasSize(1); } + @Test + void constructJustTextJustItems() { + view = new ProgressView(ProgressViewItem.ofText()); + assertThat(getViewItems(view)).hasSize(1); + } + } @Nested