From 06df05cd2786525b8356465e6a7852daffb499e2 Mon Sep 17 00:00:00 2001 From: Janne Valkealahti Date: Sat, 17 Oct 2020 10:29:13 +0100 Subject: [PATCH] Remove persisting double invocation - As it's currently expected that pre/post interceptor are called for both preStateChange and postStateChange, fix AbstractPersistingStateMachineInterceptor so that actual persist doesn't happen twice. - Eventually original preStateChange and postStateChange methods will get removed after deprecation(which should have happened a long time ago). - Fixes #871 --- .../AbstractPersistingStateMachineInterceptor.java | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/spring-statemachine-core/src/main/java/org/springframework/statemachine/persist/AbstractPersistingStateMachineInterceptor.java b/spring-statemachine-core/src/main/java/org/springframework/statemachine/persist/AbstractPersistingStateMachineInterceptor.java index 6d59a31b..489c29d2 100644 --- a/spring-statemachine-core/src/main/java/org/springframework/statemachine/persist/AbstractPersistingStateMachineInterceptor.java +++ b/spring-statemachine-core/src/main/java/org/springframework/statemachine/persist/AbstractPersistingStateMachineInterceptor.java @@ -1,5 +1,5 @@ /* - * Copyright 2017-2019 the original author or authors. + * Copyright 2017-2020 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -81,12 +81,6 @@ public abstract class AbstractPersistingStateMachineInterceptor extends } } - @Override - public void preStateChange(State state, Message message, Transition transition, - StateMachine stateMachine) { - preStateChange(state, message, transition, stateMachine, stateMachine); - } - @SuppressWarnings("unchecked") @Override public void postStateChange(State state, Message message, Transition transition, @@ -108,12 +102,6 @@ public abstract class AbstractPersistingStateMachineInterceptor extends } } - @Override - public void postStateChange(State state, Message message, Transition transition, - StateMachine stateMachine) { - postStateChange(state, message, transition, stateMachine, stateMachine); - } - /** * Write {@link StateMachineContext} into persistent store. *