From 04d2fc5cff7583d501e8e71c88ea128b2a4c46be Mon Sep 17 00:00:00 2001 From: aboyko Date: Fri, 26 Apr 2024 13:54:27 -0400 Subject: [PATCH] Adopt latest rewrite releases. Bump up boot-parent --- headless-services/commons/commons-rewrite/pom.xml | 5 +++++ .../ide/vscode/commons/rewrite/JGitUtils.java | 8 ++++---- .../ide/vscode/commons/rewrite/ORDocUtils.java | 4 ++-- headless-services/commons/pom.xml | 11 ++++++----- .../vscode/boot/java/rewrite/SpringBootUpgrade.java | 2 +- .../java/rewrite/RewriteRecipeRepositoryTest.java | 2 +- 6 files changed, 19 insertions(+), 13 deletions(-) diff --git a/headless-services/commons/commons-rewrite/pom.xml b/headless-services/commons/commons-rewrite/pom.xml index 632d7f0ee..9be0f4853 100644 --- a/headless-services/commons/commons-rewrite/pom.xml +++ b/headless-services/commons/commons-rewrite/pom.xml @@ -91,6 +91,11 @@ rewrite-java-17 ${rewrite-version} + + org.eclipse.jgit + org.eclipse.jgit + ${jgit-version} + javax.xml.bind jaxb-api diff --git a/headless-services/commons/commons-rewrite/src/main/java/org/springframework/ide/vscode/commons/rewrite/JGitUtils.java b/headless-services/commons/commons-rewrite/src/main/java/org/springframework/ide/vscode/commons/rewrite/JGitUtils.java index 6e2ecbffe..1b0046528 100644 --- a/headless-services/commons/commons-rewrite/src/main/java/org/springframework/ide/vscode/commons/rewrite/JGitUtils.java +++ b/headless-services/commons/commons-rewrite/src/main/java/org/springframework/ide/vscode/commons/rewrite/JGitUtils.java @@ -2,10 +2,10 @@ package org.springframework.ide.vscode.commons.rewrite; import java.nio.charset.StandardCharsets; -import org.openrewrite.shaded.jgit.diff.EditList; -import org.openrewrite.shaded.jgit.diff.HistogramDiff; -import org.openrewrite.shaded.jgit.diff.RawText; -import org.openrewrite.shaded.jgit.diff.RawTextComparator; +import org.eclipse.jgit.diff.EditList; +import org.eclipse.jgit.diff.HistogramDiff; +import org.eclipse.jgit.diff.RawText; +import org.eclipse.jgit.diff.RawTextComparator; class JGitUtils { diff --git a/headless-services/commons/commons-rewrite/src/main/java/org/springframework/ide/vscode/commons/rewrite/ORDocUtils.java b/headless-services/commons/commons-rewrite/src/main/java/org/springframework/ide/vscode/commons/rewrite/ORDocUtils.java index 4ae2c8115..e046d23d3 100644 --- a/headless-services/commons/commons-rewrite/src/main/java/org/springframework/ide/vscode/commons/rewrite/ORDocUtils.java +++ b/headless-services/commons/commons-rewrite/src/main/java/org/springframework/ide/vscode/commons/rewrite/ORDocUtils.java @@ -25,8 +25,8 @@ import org.eclipse.lsp4j.VersionedTextDocumentIdentifier; import org.eclipse.lsp4j.WorkspaceEdit; import org.eclipse.lsp4j.jsonrpc.messages.Either; import org.openrewrite.Result; -import org.openrewrite.shaded.jgit.diff.Edit; -import org.openrewrite.shaded.jgit.diff.EditList; +import org.eclipse.jgit.diff.Edit; +import org.eclipse.jgit.diff.EditList; import org.slf4j.Logger; import org.slf4j.LoggerFactory; import org.springframework.ide.vscode.commons.languageserver.completion.DocumentEdits; diff --git a/headless-services/commons/pom.xml b/headless-services/commons/pom.xml index c1a294dcb..f49a1def8 100644 --- a/headless-services/commons/pom.xml +++ b/headless-services/commons/pom.xml @@ -13,7 +13,7 @@ org.springframework.boot spring-boot-starter-parent - 3.2.3 + 3.2.5 @@ -119,10 +119,11 @@ 1.9.20 - 8.19.0 - 1.11.4 - 5.5.0 - 2.0.0 + 8.24.0 + 1.14.0 + 5.8.0 + 2.2.0 + 6.9.0.202403050737-r 8.5 6.1.1 diff --git a/headless-services/spring-boot-language-server/src/main/java/org/springframework/ide/vscode/boot/java/rewrite/SpringBootUpgrade.java b/headless-services/spring-boot-language-server/src/main/java/org/springframework/ide/vscode/boot/java/rewrite/SpringBootUpgrade.java index 6cf880b7d..fa0d7f842 100644 --- a/headless-services/spring-boot-language-server/src/main/java/org/springframework/ide/vscode/boot/java/rewrite/SpringBootUpgrade.java +++ b/headless-services/spring-boot-language-server/src/main/java/org/springframework/ide/vscode/boot/java/rewrite/SpringBootUpgrade.java @@ -104,7 +104,7 @@ public class SpringBootUpgrade { if (version.getMajor() == targetVersion.getMajor() && version.getMinor() == targetVersion.getMinor()) { // patch version upgrade - treat as pom versions only upgrade recipe.getRecipeList().add(new UpgradeDependencyVersion("org.springframework.boot", "*", version.getMajor() + "." + version.getMinor() + ".x", null, null, null)); - recipe.getRecipeList().add(new UpgradeParentVersion("org.springframework.boot", "spring-boot-starter-parent", version.getMajor() + "." + version.getMinor() + ".x", null, null)); + recipe.getRecipeList().add(new UpgradeParentVersion("org.springframework.boot", "spring-boot-starter-parent", version.getMajor() + "." + version.getMinor() + ".x", null)); } else /*if (version.getMajor() == targetVersion.getMajor())*/ { List recipedIds = createRecipeIdsChain(version.getMajor(), version.getMinor() + 1, targetVersion.getMajor(), targetVersion.getMinor(), versionsToRecipeId); if (!recipedIds.isEmpty()) { diff --git a/headless-services/spring-boot-language-server/src/test/java/org/springframework/ide/vscode/boot/java/rewrite/RewriteRecipeRepositoryTest.java b/headless-services/spring-boot-language-server/src/test/java/org/springframework/ide/vscode/boot/java/rewrite/RewriteRecipeRepositoryTest.java index 1bef0843d..4f0be6cd3 100644 --- a/headless-services/spring-boot-language-server/src/test/java/org/springframework/ide/vscode/boot/java/rewrite/RewriteRecipeRepositoryTest.java +++ b/headless-services/spring-boot-language-server/src/test/java/org/springframework/ide/vscode/boot/java/rewrite/RewriteRecipeRepositoryTest.java @@ -38,7 +38,7 @@ public class RewriteRecipeRepositoryTest { assertEquals(8, recipes.size()); recipes = recipeRepo.getSubRecipes("org.openrewrite.java.spring.boot3.UpgradeSpringBoot_3_1", List.of(0, 2)).get(); - assertEquals(14, recipes.size()); + assertEquals(20, recipes.size()); recipes = recipeRepo.getSubRecipes("org.openrewrite.java.spring.boot3.UpgradeSpringBoot_3_1",List.of(0, 345)).get(); assertEquals(0, recipes.size());