From 0beea180fe617d6104d00d32a946795e5cfe024c Mon Sep 17 00:00:00 2001 From: Martin Lippert Date: Fri, 13 Oct 2017 10:38:09 +0200 Subject: [PATCH] PT #151440528: live hints for request mappings now do exact matching instead of apps and mappings --- .../requestmapping/RequestMappingHoverProvider.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/headless-services/boot-java-language-server/src/main/java/org/springframework/ide/vscode/boot/java/requestmapping/RequestMappingHoverProvider.java b/headless-services/boot-java-language-server/src/main/java/org/springframework/ide/vscode/boot/java/requestmapping/RequestMappingHoverProvider.java index 3f9dc1d50..98fc6d860 100644 --- a/headless-services/boot-java-language-server/src/main/java/org/springframework/ide/vscode/boot/java/requestmapping/RequestMappingHoverProvider.java +++ b/headless-services/boot-java-language-server/src/main/java/org/springframework/ide/vscode/boot/java/requestmapping/RequestMappingHoverProvider.java @@ -55,11 +55,11 @@ public class RequestMappingHoverProvider implements HoverProvider { public Range getLiveHoverHint(Annotation annotation, TextDocument doc, SpringBootApp[] runningApps) { try { if (runningApps.length > 0) { - // TODO: this check is too simple, we need to do a lot more here - // -> check if the running app has a matching request mapping for this annotation - - Range hoverRange = doc.toRange(annotation.getStartPosition(), annotation.getLength()); - return hoverRange; + Optional val = getRequestMappingMethodFromRunningApp(annotation, runningApps); + if (val.isPresent()) { + Range hoverRange = doc.toRange(annotation.getStartPosition(), annotation.getLength()); + return hoverRange; + } } } catch (BadLocationException e) {