From 1ce3f1b90d8cde68a08da4947cc764ddca6d4aba Mon Sep 17 00:00:00 2001 From: Martin Lippert Date: Tue, 8 Apr 2025 12:40:56 +0200 Subject: [PATCH] remove info messages from error log view in eclipse --- .../boot/ls/DelegatingStreamConnectionProvider.java | 1 - .../org/springframework/tooling/boot/ls/Startup.java | 4 +--- .../STS4LanguageServerProcessStreamConnector.java | 10 +++------- .../tooling/jdt/ls/commons/BootProjectTracker.java | 6 ++---- 4 files changed, 6 insertions(+), 15 deletions(-) diff --git a/eclipse-language-servers/org.springframework.tooling.boot.ls/src/org/springframework/tooling/boot/ls/DelegatingStreamConnectionProvider.java b/eclipse-language-servers/org.springframework.tooling.boot.ls/src/org/springframework/tooling/boot/ls/DelegatingStreamConnectionProvider.java index bc925f4b0..8358a8eff 100644 --- a/eclipse-language-servers/org.springframework.tooling.boot.ls/src/org/springframework/tooling/boot/ls/DelegatingStreamConnectionProvider.java +++ b/eclipse-language-servers/org.springframework.tooling.boot.ls/src/org/springframework/tooling/boot/ls/DelegatingStreamConnectionProvider.java @@ -99,7 +99,6 @@ public class DelegatingStreamConnectionProvider implements StreamConnectionProvi @Override public void start() throws IOException { - BootLanguageServerPlugin.getDefault().getLog().info("DelegatingStreamConnectionProvider - Starting Boot LS"); this.provider.start(); IProxyService proxyService = PlatformUI.getWorkbench().getService(IProxyService.class); if (proxyService != null) { diff --git a/eclipse-language-servers/org.springframework.tooling.boot.ls/src/org/springframework/tooling/boot/ls/Startup.java b/eclipse-language-servers/org.springframework.tooling.boot.ls/src/org/springframework/tooling/boot/ls/Startup.java index 75fc5afe1..bf0960b86 100644 --- a/eclipse-language-servers/org.springframework.tooling.boot.ls/src/org/springframework/tooling/boot/ls/Startup.java +++ b/eclipse-language-servers/org.springframework.tooling.boot.ls/src/org/springframework/tooling/boot/ls/Startup.java @@ -1,5 +1,5 @@ /******************************************************************************* - * Copyright (c) 2022, 2023 VMware, Inc. + * Copyright (c) 2022, 2025 VMware, Inc. * All rights reserved. This program and the accompanying materials * are made available under the terms of the Eclipse Public License v1.0 * which accompanies this distribution, and is available at @@ -37,13 +37,11 @@ public class Startup implements IStartup { private synchronized void handleProjectsFound(Set springProjects) { if (!started && !springProjects.isEmpty()) { - BootLanguageServerPlugin.getDefault().getLog().info("Starting Boot LS..."); LanguageServerDefinition serverDefinition = LanguageServersRegistry.getInstance() .getDefinition(BootLanguageServerPlugin.BOOT_LS_DEFINITION_ID); try { LanguageServiceAccessor.startLanguageServer(serverDefinition); - BootLanguageServerPlugin.getDefault().getLog().info("Started Boot LS process"); started = true; } catch (Throwable e1) { BootLanguageServerPlugin.getDefault().getLog().error("Failed to launch Boot Language Server", e1); diff --git a/eclipse-language-servers/org.springframework.tooling.ls.eclipse.commons/src/org/springframework/tooling/ls/eclipse/commons/STS4LanguageServerProcessStreamConnector.java b/eclipse-language-servers/org.springframework.tooling.ls.eclipse.commons/src/org/springframework/tooling/ls/eclipse/commons/STS4LanguageServerProcessStreamConnector.java index 685f29d89..9ad060a38 100644 --- a/eclipse-language-servers/org.springframework.tooling.ls.eclipse.commons/src/org/springframework/tooling/ls/eclipse/commons/STS4LanguageServerProcessStreamConnector.java +++ b/eclipse-language-servers/org.springframework.tooling.ls.eclipse.commons/src/org/springframework/tooling/ls/eclipse/commons/STS4LanguageServerProcessStreamConnector.java @@ -1,5 +1,5 @@ /******************************************************************************* - * Copyright (c) 2017, 2024 Pivotal, Inc. + * Copyright (c) 2017, 2025 Pivotal, Inc. * All rights reserved. This program and the accompanying materials * are made available under the terms of the Eclipse Public License v1.0 * which accompanies this distribution, and is available at @@ -56,9 +56,10 @@ public abstract class STS4LanguageServerProcessStreamConnector extends ProcessSt @Override public void start() throws IOException { super.start(); + Process process = LanguageServerProcessReaper.getProcess(this); - LanguageServerCommonsActivator.getInstance().getLog().info("Started " + connectorId + " LS process " + process.pid()); processReaper.addProcess(connectorId, process); + if (consoles!=null) { Console console = consoles.get(); if (console!=null) { @@ -117,8 +118,6 @@ public abstract class STS4LanguageServerProcessStreamConnector extends ProcessSt command.add(languageServerRoot.resolve(jarFile).toFile().toString()); setCommands(command); - - LanguageServerCommonsActivator.getInstance().getLog().info("Command list starting LS: " + connectorId + "\nSTART:\n" + String.join("\n", command) + "\nEND"); } catch (Throwable t) { LanguageServerCommonsActivator.logError(t, "Failed to assemble executable LS JAR launch command"); } @@ -191,8 +190,6 @@ public abstract class STS4LanguageServerProcessStreamConnector extends ProcessSt command.add(mainClass); setCommands(command); - - LanguageServerCommonsActivator.getInstance().getLog().info("Command list starting LS: " + connectorId + "\nSTART:\n" + String.join("\n", command) + "\nEND"); } catch (Throwable t) { LanguageServerCommonsActivator.logError(t, "Failed to assemble exploded LS JAR launch command"); @@ -265,7 +262,6 @@ public abstract class STS4LanguageServerProcessStreamConnector extends ProcessSt public void stop() { super.stop(); Process process = LanguageServerProcessReaper.getProcess(this); - LanguageServerCommonsActivator.getInstance().getLog().info("Stopped " + connectorId + " LS process " + process.pid()); processReaper.removeProcess(process); } diff --git a/headless-services/jdt-ls-extension/org.springframework.tooling.jdt.ls.commons/src/org/springframework/tooling/jdt/ls/commons/BootProjectTracker.java b/headless-services/jdt-ls-extension/org.springframework.tooling.jdt.ls.commons/src/org/springframework/tooling/jdt/ls/commons/BootProjectTracker.java index dbfa3f367..82b97ba90 100644 --- a/headless-services/jdt-ls-extension/org.springframework.tooling.jdt.ls.commons/src/org/springframework/tooling/jdt/ls/commons/BootProjectTracker.java +++ b/headless-services/jdt-ls-extension/org.springframework.tooling.jdt.ls.commons/src/org/springframework/tooling/jdt/ls/commons/BootProjectTracker.java @@ -1,5 +1,5 @@ /******************************************************************************* - * Copyright (c) 2022, 2023 VMware, Inc. + * Copyright (c) 2022, 2025 VMware, Inc. * All rights reserved. This program and the accompanying materials * are made available under the terms of the Eclipse Public License v1.0 * which accompanies this distribution, and is available at @@ -30,6 +30,7 @@ import org.springframework.tooling.jdt.ls.commons.classpath.ClasspathListenerMan public class BootProjectTracker { private Logger logger; + private Set springProjects = new HashSet<>(); private List>> listeners = Collections.synchronizedList(new ArrayList<>()); @@ -40,7 +41,6 @@ public class BootProjectTracker { @Override public void classpathChanged(IJavaProject jp) { - logger.log("Classpath changed for project: " + jp.getElementName()); processProject(jp); } }); @@ -57,12 +57,10 @@ public class BootProjectTracker { private void processProject(IJavaProject jp) { if (isSpringProject(jp)) { if (springProjects.add(jp)) { - logger.log("Boot project ADDED: " + jp.getElementName()); fireEvent(); } } else { if (springProjects.remove(jp)) { - logger.log("Boot project REMOVED: " + jp.getElementName()); fireEvent(); } }