From 45b634e467bf60f0b32d8164b416981a0a86c9b1 Mon Sep 17 00:00:00 2001 From: "nsingh@pivotal.io" Date: Mon, 11 Feb 2019 13:51:56 -0800 Subject: [PATCH] User logger to log errors in Value hover provider --- .../ide/vscode/boot/java/value/ValueHoverProvider.java | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/headless-services/spring-boot-language-server/src/main/java/org/springframework/ide/vscode/boot/java/value/ValueHoverProvider.java b/headless-services/spring-boot-language-server/src/main/java/org/springframework/ide/vscode/boot/java/value/ValueHoverProvider.java index dde17bfc8..3935e597f 100644 --- a/headless-services/spring-boot-language-server/src/main/java/org/springframework/ide/vscode/boot/java/value/ValueHoverProvider.java +++ b/headless-services/spring-boot-language-server/src/main/java/org/springframework/ide/vscode/boot/java/value/ValueHoverProvider.java @@ -24,6 +24,8 @@ import org.eclipse.jdt.core.dom.TypeDeclaration; import org.eclipse.lsp4j.Hover; import org.eclipse.lsp4j.Range; import org.eclipse.lsp4j.jsonrpc.messages.Either; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; import org.springframework.ide.vscode.boot.java.handlers.HoverProvider; import org.springframework.ide.vscode.boot.java.livehover.LiveHoverUtils; import org.springframework.ide.vscode.commons.boot.app.cli.SpringBootApp; @@ -39,6 +41,8 @@ import com.google.common.collect.ImmutableList; */ public class ValueHoverProvider implements HoverProvider { + protected static Logger logger = LoggerFactory.getLogger(ValueHoverProvider.class); + @Override public Hover provideHover(ASTNode node, Annotation annotation, ITypeBinding type, int offset, TextDocument doc, IJavaProject project, SpringBootApp[] runningApps) { @@ -61,7 +65,7 @@ public class ValueHoverProvider implements HoverProvider { } } catch (Exception e) { - e.printStackTrace(); + logger.error("Error while generating live hovers for @Value", e); } return null; @@ -103,7 +107,7 @@ public class ValueHoverProvider implements HoverProvider { } } catch (Exception e) { - e.printStackTrace(); + logger.error("Error while generating live hovers for @Value", e); } return null; @@ -121,7 +125,7 @@ public class ValueHoverProvider implements HoverProvider { } } catch (Exception e) { - e.printStackTrace(); + logger.error("", e); } return result;