From 86a9452de0f10a68457ecaa03279ea2289b0618d Mon Sep 17 00:00:00 2001 From: nsingh Date: Wed, 1 Feb 2017 11:17:22 -0800 Subject: [PATCH] Added minor documentation --- .../cloudfoundry/client/cftarget/CFCallableContext.java | 5 +++++ .../cloudfoundry/client/cftarget/CFTargetCache.java | 9 +++++++-- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/vscode-extensions/commons/commons-cf/src/main/java/org/springframework/ide/vscode/commons/cloudfoundry/client/cftarget/CFCallableContext.java b/vscode-extensions/commons/commons-cf/src/main/java/org/springframework/ide/vscode/commons/cloudfoundry/client/cftarget/CFCallableContext.java index 969ac867e..977d921e8 100644 --- a/vscode-extensions/commons/commons-cf/src/main/java/org/springframework/ide/vscode/commons/cloudfoundry/client/cftarget/CFCallableContext.java +++ b/vscode-extensions/commons/commons-cf/src/main/java/org/springframework/ide/vscode/commons/cloudfoundry/client/cftarget/CFCallableContext.java @@ -19,6 +19,11 @@ import org.springframework.ide.vscode.commons.util.ExceptionUtil; import reactor.ipc.netty.channel.AbortedException; +/** + * This is a stateful callable context that is "aware" of CF errors, and is not + * suitable for reuse as it may cache errors + * + */ public class CFCallableContext { private final CFParamsProviderMessages paramsProviderMessages; diff --git a/vscode-extensions/commons/commons-cf/src/main/java/org/springframework/ide/vscode/commons/cloudfoundry/client/cftarget/CFTargetCache.java b/vscode-extensions/commons/commons-cf/src/main/java/org/springframework/ide/vscode/commons/cloudfoundry/client/cftarget/CFTargetCache.java index 65db645d9..109495ddd 100644 --- a/vscode-extensions/commons/commons-cf/src/main/java/org/springframework/ide/vscode/commons/cloudfoundry/client/cftarget/CFTargetCache.java +++ b/vscode-extensions/commons/commons-cf/src/main/java/org/springframework/ide/vscode/commons/cloudfoundry/client/cftarget/CFTargetCache.java @@ -75,8 +75,8 @@ public class CFTargetCache { if (target != null) { // If any CF errors occurred in the target, refresh once if (target.hasConnectionError()) { - cache.refresh(key); - target = cache.get(key); + cache.refresh(key); + target = cache.get(key); } targets.add(target); } @@ -87,6 +87,11 @@ public class CFTargetCache { } protected CFTarget create(CFClientParams params) throws Exception { + /* + * Must pass a NEW callable context. Cannot be + * the same as the target cache callable context, as + * contexts may contain error state + */ return new CFTarget(getTargetName(params), params, clientFactory.getClient(params, timeouts), new CFCallableContext(paramsProvider.getMessages())); }