diff --git a/headless-services/commons/commons-language-server/src/main/java/org/springframework/ide/vscode/commons/languageserver/hover/VscodeHoverEngineAdapter.java b/headless-services/commons/commons-language-server/src/main/java/org/springframework/ide/vscode/commons/languageserver/hover/VscodeHoverEngineAdapter.java index f944d4ca3..5891511a5 100644 --- a/headless-services/commons/commons-language-server/src/main/java/org/springframework/ide/vscode/commons/languageserver/hover/VscodeHoverEngineAdapter.java +++ b/headless-services/commons/commons-language-server/src/main/java/org/springframework/ide/vscode/commons/languageserver/hover/VscodeHoverEngineAdapter.java @@ -60,9 +60,6 @@ public class VscodeHoverEngineAdapter implements HoverHandler { @Override public Hover handle(TextDocumentPositionParams params) { - //TODO: This returns a CompletableFuture which suggests we should try to do expensive work asyncly. - // We are currently just doing all this in a blocking way and wrapping the already computed list into - // a trivial pre-resolved future. try { SimpleTextDocumentService documents = server.getTextDocumentService(); TextDocument doc = documents.get(params); diff --git a/headless-services/concourse-language-server/src/test/java/org/springframework/ide/vscode/concourse/ConcourseEditorTest.java b/headless-services/concourse-language-server/src/test/java/org/springframework/ide/vscode/concourse/ConcourseEditorTest.java index 50d8cf43e..893865e84 100644 --- a/headless-services/concourse-language-server/src/test/java/org/springframework/ide/vscode/concourse/ConcourseEditorTest.java +++ b/headless-services/concourse-language-server/src/test/java/org/springframework/ide/vscode/concourse/ConcourseEditorTest.java @@ -29,6 +29,7 @@ import org.eclipse.lsp4j.Diagnostic; import org.eclipse.lsp4j.DiagnosticSeverity; import org.junit.Before; import org.junit.Ignore; +import org.junit.Rule; import org.junit.Test; import org.junit.runner.RunWith; import org.springframework.beans.factory.annotation.Autowired; @@ -44,6 +45,7 @@ import org.springframework.ide.vscode.languageserver.testharness.CodeAction; import org.springframework.ide.vscode.languageserver.testharness.Editor; import org.springframework.ide.vscode.languageserver.testharness.LanguageServerHarness; import org.springframework.ide.vscode.languageserver.testharness.SynchronizationPoint; +import org.springframework.test.annotation.Repeat; import org.springframework.test.context.junit4.SpringRunner; import com.google.common.collect.ImmutableList; @@ -63,6 +65,9 @@ public class ConcourseEditorTest { @MockBean private GithubInfoProvider github; + + @Rule + public LogTestStartAndEnd startAndEndLogger = new LogTestStartAndEnd(); @Before public void setup() throws Exception { serverInitializer.setMaxCompletions(100); diff --git a/headless-services/concourse-language-server/src/test/java/org/springframework/ide/vscode/concourse/LogTestStartAndEnd.java b/headless-services/concourse-language-server/src/test/java/org/springframework/ide/vscode/concourse/LogTestStartAndEnd.java new file mode 100644 index 000000000..8de78ee49 --- /dev/null +++ b/headless-services/concourse-language-server/src/test/java/org/springframework/ide/vscode/concourse/LogTestStartAndEnd.java @@ -0,0 +1,17 @@ +package org.springframework.ide.vscode.concourse; + +import org.junit.rules.TestWatcher; +import org.junit.runner.Description; + +public class LogTestStartAndEnd extends TestWatcher { + + @Override + protected void starting(Description description) { + System.out.println(">>>> starting test: "+description.getClassName()+" . "+description.getMethodName()); + } + + @Override + protected void finished(Description description) { + System.out.println("<<<< finished test: "+description.getClassName()+" . "+description.getMethodName()); + } +}