From 7ba9c07bc6c9579ec2ebba1d785dc5a2bc46bb6e Mon Sep 17 00:00:00 2001 From: Kris De Volder Date: Thu, 21 May 2020 12:14:48 -0700 Subject: [PATCH] Fix failing test cases from PR 464 See https://github.com/spring-projects/sts4/pull/464 Problems found: - issues with formatting of the test case examples. Spaces vs tabs issues and weird indentation of the examples causing problems for editor to parse examples. - added 'set_pipeline' step caused some other tests fail because they should correctly expect this as a valid completion, but tests had not been updated to reflect that. --- .../ide/vscode/concourse/ConcourseEditorTest.java | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/headless-services/concourse-language-server/src/test/java/org/springframework/ide/vscode/concourse/ConcourseEditorTest.java b/headless-services/concourse-language-server/src/test/java/org/springframework/ide/vscode/concourse/ConcourseEditorTest.java index 39400605d..903dbef07 100644 --- a/headless-services/concourse-language-server/src/test/java/org/springframework/ide/vscode/concourse/ConcourseEditorTest.java +++ b/headless-services/concourse-language-server/src/test/java/org/springframework/ide/vscode/concourse/ConcourseEditorTest.java @@ -315,6 +315,8 @@ public class ConcourseEditorTest { , // ============== "put: <*>" , // ============== + "set_pipeline: <*>" + , // ============== "task: <*>" , // ============== "try:\n" + @@ -357,7 +359,7 @@ public class ConcourseEditorTest { " - try:\n" + " put: test-logs\n" + " - set_pipeline: configure-the-pipeline\n" + - " file: my-repo/ci/pipeline.yml\n" + " file: my-repo/ci/pipeline.yml\n" ); editor.assertHoverContains("get", "Fetches a resource"); @@ -399,11 +401,11 @@ public class ConcourseEditorTest { " plan:\n" + " - get: my-repo\n" + " - set_pipeline: configure-the-pipeline\n" + - " file: my-repo/ci/pipeline.yml\n" + + " file: my-repo/ci/pipeline.yml\n" + " var_files:\n" + - " - my-repo/ci/dev.yml\n" + - " vars:\n" + - " text: \"Hello World!\"\n" + " - my-repo/ci/dev.yml\n" + + " vars:\n" + + " text: \"Hello World!\"\n" ); editor.assertHoverContains("file", "The path to the pipeline's configuration file."); @@ -4197,6 +4199,7 @@ public class ConcourseEditorTest { "- get", "- in_parallel", "- put", + "- set_pipeline", "- task", "- try", "- aggregate",