GHA: upload linux files to s3 outside of maven build. Cleanups

.github/scripts/notarize-osx-distro-file.sh

@@ -6,12 +6,9 @@ notarize_profile=$2
 dmg_filename="$(basename -- $dmg_file)"
 dir="$(dirname "$dmg_file")"
 
-echo "****************************************************************"
-echo "*** Notarizing: ${dmg_filename}"
-echo "****************************************************************"
 cd $dir
 xcrun notarytool submit ./${dmg_filename} --keychain-profile $notarize_profile --wait
 echo "Staple and generate checksums for ${dmg_filename}"
 xcrun stapler staple $dmg_filename
 shasum -a 256 $dmg_filename > ${dmg_filename}.sha256
-md5 $dmg_filename > ${dmg_filename}.md5)
+md5 $dmg_filename > ${dmg_filename}.md5

.github/scripts/sign-osx-distro-file.sh

@@ -15,8 +15,7 @@ echo "Extracting archive ${filename} to ${dir}/${destination_folder_name}"
 mkdir ${dir}/${destination_folder_name}
 tar -zxf $file --directory ${dir}/${destination_folder_name}
 echo "Successfully extracted ${filename}"
-echo "About to sign OSX .app file: ${dir}/${destination_folder_name}/SpringToolSuite4.app"
-echo "keychain ${KEYCHAIN}"
+
 codesign --verbose --deep --force --timestamp --entitlements "${entitlements}" --options=runtime --keychain "${KEYCHAIN}" -s "${MACOS_CERTIFICATE_ID}" ${dir}/${destination_folder_name}/SpringToolSuite4.app
 
 cd ${dir}/${destination_folder_name}
@@ -34,6 +33,7 @@ echo '}' >> dmg-config.json
 cat ./dmg-config.json
 dmg_filename=${filename%.*.*}.dmg
 appdmg ./dmg-config.json ../${dmg_filename}
+
 cd ..
 rm -rf ./${destination_folder_name}
 rm -f $filename