From 880d308b498d1213eb4d22d39831c57044d12e7d Mon Sep 17 00:00:00 2001 From: Kris De Volder Date: Thu, 5 Jul 2018 10:41:55 -0700 Subject: [PATCH] Remove workaround for lsp4e sorting issue The issue has been fixed in lsp4e master --- .../completion/VscodeCompletionEngineAdapter.java | 4 ---- 1 file changed, 4 deletions(-) diff --git a/headless-services/commons/commons-language-server/src/main/java/org/springframework/ide/vscode/commons/languageserver/completion/VscodeCompletionEngineAdapter.java b/headless-services/commons/commons-language-server/src/main/java/org/springframework/ide/vscode/commons/languageserver/completion/VscodeCompletionEngineAdapter.java index 2dd8ac408..a661cbc2e 100644 --- a/headless-services/commons/commons-language-server/src/main/java/org/springframework/ide/vscode/commons/languageserver/completion/VscodeCompletionEngineAdapter.java +++ b/headless-services/commons/commons-language-server/src/main/java/org/springframework/ide/vscode/commons/languageserver/completion/VscodeCompletionEngineAdapter.java @@ -162,10 +162,6 @@ public class VscodeCompletionEngineAdapter implements VscodeCompletionEngine { } } list.setItems(items); - if (LspClient.currentClient()==Client.ECLIPSE) { - list.setIsIncomplete(true); //This is a hack. It bypasses lsp4e filtering / sorting because it - // it behaves totally bonkers. See: https://bugs.eclipse.org/bugs/show_bug.cgi?id=535823 - } return list; }) .subscribeOn(Schedulers.elastic()); //!!! without this the mono will just be computed on the same thread that calls it.