Spring/spring-tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add support for values of type java.time.Duration...

Browse Source 
So that both application.properties and application.yml

- recognize/treat these as atomic values
- can recognize 'garbage' values during reconcile and give a error.
This commit is contained in:
Kris De Volder
2018-08-21 12:01:37 -07:00
parent 93ec5e6fae
commit 8ef2e19fdf
5 changed files with 90 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
headless-services/spring-boot-language-server/src/test/java/org/springframework/ide/vscode/boot/test/ApplicationPropertiesEditorTest.java
View File

@@ -78,6 +78,33 @@ public class ApplicationPropertiesEditorTest extends AbstractPropsEditorTest {
editor.assertProblems("problem|extraneous input", "another|mismatched input");
}
@Test public void bug_158348104() throws Exception {
//See: https://www.pivotaltracker.com/story/show/158348104
data("spring.activemq.close-timeout", "java.time.Duration", null, null);
Editor editor;
editor = newEditor("");
editor.assertContextualCompletions("springactcloti",
"spring.activemq.close-timeout=<*>"
);
editor = newEditor(
"spring.activemq.close-timeout=garbage"
);
editor.assertProblems("garbage|not a valid duration");
editor = newEditor(
"spring.activemq.close-timeout: 15s"
);
editor.assertProblems(/*NONE*/);
editor = newEditor(
"spring.activemq.close-timeout: PT10S" //ISO duration format
);
editor.assertProblems(/*NONE*/);
}
@Test public void testServerPortCompletion() throws Exception {
data("server.port", INTEGER, 8080, "Port where server listens for http.");
assertCompletion("ser<*>", "server.port=<*>");

35
headless-services/spring-boot-language-server/src/test/java/org/springframework/ide/vscode/boot/test/ApplicationYamlEditorTest.java
View File

@@ -51,6 +51,41 @@ public class ApplicationYamlEditorTest extends AbstractPropsEditorTest {
////////////////////////////////////////////////////////////////////////////////////////
@Test public void bug_158348104() throws Exception {
//See: https://www.pivotaltracker.com/story/show/158348104
data("spring.activemq.close-timeout", "java.time.Duration", null, null);
Editor editor;
editor = newEditor("");
editor.assertContextualCompletions("springactcloti",
"spring:\n" +
" activemq:\n" +
" close-timeout: <*>"
);
editor = newEditor(
"spring:\n" +
" activemq:\n" +
" close-timeout: garbage"
);
editor.assertProblems("garbage|not a valid duration");
editor = newEditor(
"spring:\n" +
" activemq:\n" +
" close-timeout: 15s"
);
editor.assertProblems(/*NONE*/);
editor = newEditor(
"spring:\n" +
" activemq:\n" +
" close-timeout: PT10S" //ISO duration format
);
editor.assertProblems(/*NONE*/);
}
@Test public void bug_153144391() throws Exception {
//See: https://www.pivotaltracker.com/story/show/153144391
useProject(createPredefinedMavenProject("empty-boot-1.3.0-app"));