From 9bc7f3755485c7a74d40827e457d474814e640e3 Mon Sep 17 00:00:00 2001
From: Kris De Volder <kdevolder@pivotal.io>
Date: Fri, 27 Jan 2017 16:33:56 -0800
Subject: [PATCH] Small tweak to 'Please login to CF' message

---
 .../client/cftarget/CfCliParamsProvider.java         |  2 +-
 .../manifest/yaml/AbstractCFHintsProvider.java       |  2 +-
 .../vscode/manifest/yaml/ManifestYamlEditorTest.java | 12 ++++--------
 3 files changed, 6 insertions(+), 10 deletions(-)

diff --git a/vscode-extensions/commons/commons-cf/src/main/java/org/springframework/ide/vscode/commons/cloudfoundry/client/cftarget/CfCliParamsProvider.java b/vscode-extensions/commons/commons-cf/src/main/java/org/springframework/ide/vscode/commons/cloudfoundry/client/cftarget/CfCliParamsProvider.java
index 545abaab3..71aa6d1f8 100644
--- a/vscode-extensions/commons/commons-cf/src/main/java/org/springframework/ide/vscode/commons/cloudfoundry/client/cftarget/CfCliParamsProvider.java
+++ b/vscode-extensions/commons/commons-cf/src/main/java/org/springframework/ide/vscode/commons/cloudfoundry/client/cftarget/CfCliParamsProvider.java
@@ -29,7 +29,7 @@ import com.fasterxml.jackson.databind.ObjectMapper;
  */
 public class CfCliParamsProvider implements ClientParamsProvider {
 
-	public static final String NO_CLI_TARGETS_FOUND_MESSAGE = "Unable to fetch information from Cloud Foundry. Please use cf CLI to configure and login to Cloud Foundry.";
+	public static final String NO_CLI_TARGETS_FOUND_MESSAGE = "No Cloudfoundry Targets: Please use the cf CLI to login.";
 	public static final String TARGET = "Target";
 	public static final String REFRESH_TOKEN = "RefreshToken";
 	public static final String ORGANIZATION_FIELDS = "OrganizationFields";
diff --git a/vscode-extensions/vscode-manifest-yaml/src/main/java/org/springframework/ide/vscode/manifest/yaml/AbstractCFHintsProvider.java b/vscode-extensions/vscode-manifest-yaml/src/main/java/org/springframework/ide/vscode/manifest/yaml/AbstractCFHintsProvider.java
index cf28e20d8..27673b147 100644
--- a/vscode-extensions/vscode-manifest-yaml/src/main/java/org/springframework/ide/vscode/manifest/yaml/AbstractCFHintsProvider.java
+++ b/vscode-extensions/vscode-manifest-yaml/src/main/java/org/springframework/ide/vscode/manifest/yaml/AbstractCFHintsProvider.java
@@ -59,7 +59,7 @@ public abstract class AbstractCFHintsProvider implements Callable<Collection<YVa
 				// Do not log the no-targets exception as it may be encountered
 				// frequently
 				// if a user does not have a CF client installed
-				throw new ValueParseException("No Cloudfoundry Targets: "+ExceptionUtil.getMessageNoAppendedInformation(noTargetsError));
+				throw new ValueParseException(ExceptionUtil.getMessageNoAppendedInformation(noTargetsError));
 			} else {
 				// Log any other error
 				logger.log(Level.SEVERE, ExceptionUtil.getMessage(e), e);
diff --git a/vscode-extensions/vscode-manifest-yaml/src/test/java/org/springframework/ide/vscode/manifest/yaml/ManifestYamlEditorTest.java b/vscode-extensions/vscode-manifest-yaml/src/test/java/org/springframework/ide/vscode/manifest/yaml/ManifestYamlEditorTest.java
index 71b046169..c645971b5 100644
--- a/vscode-extensions/vscode-manifest-yaml/src/test/java/org/springframework/ide/vscode/manifest/yaml/ManifestYamlEditorTest.java
+++ b/vscode-extensions/vscode-manifest-yaml/src/test/java/org/springframework/ide/vscode/manifest/yaml/ManifestYamlEditorTest.java
@@ -854,9 +854,7 @@ public class ManifestYamlEditorTest {
 	public void servicesContentAssistShowErrorMessageWhenNotLoggedIn() throws Exception {
 		reset(cloudfoundry.paramsProvider);
 
-		String exceptionMessage = "Please login to cf";
-
-		when(cloudfoundry.paramsProvider.getParams()).thenThrow(new NoTargetsException(exceptionMessage));
+		when(cloudfoundry.paramsProvider.getParams()).thenThrow(new NoTargetsException("No Cloudfoundry Targets: Please login"));
 
 		String textBefore =
 				"applications:\n" +
@@ -871,7 +869,7 @@ public class ManifestYamlEditorTest {
 		editor.assertCompletions(textBefore);
 
 		//The message from the exception should appear in the 'doc string':
-		editor.assertCompletionDetails("No Cloudfoundry Targets", "Error", exceptionMessage);
+		editor.assertCompletionDetails("No Cloudfoundry Targets", "Error", "Please login");
 
 	}
 
@@ -879,9 +877,7 @@ public class ManifestYamlEditorTest {
 	public void servicesContentAssistShowErrorMessageWhenNotLoggedIn_nonEmptyQueryString() throws Exception {
 		reset(cloudfoundry.paramsProvider);
 
-		String exceptionMessage = "Please login to cf";
-
-		when(cloudfoundry.paramsProvider.getParams()).thenThrow(new NoTargetsException(exceptionMessage));
+		when(cloudfoundry.paramsProvider.getParams()).thenThrow(new NoTargetsException("No Cloudfoundry Targets: Please login"));
 
 		String textBefore =
 				"applications:\n" +
@@ -896,7 +892,7 @@ public class ManifestYamlEditorTest {
 		editor.assertCompletions(textBefore);
 
 		//The message from the exception should appear in the 'doc string':
-		CompletionItem completion = editor.assertCompletionDetails("No Cloudfoundry Targets", "Error", exceptionMessage);
+		CompletionItem completion = editor.assertCompletionDetails("No Cloudfoundry Targets", "Error", "Please login");
 		//query string should match the 'filter text' otherwise vscode will filter the item and it will be gone!
 		assertEquals("something", completion.getFilterText());
 	}