From a4ea1a474ca21cf2e97a589ff0d5f80abb8e8d12 Mon Sep 17 00:00:00 2001
From: Martin Lippert <mlippert@pivotal.io>
Date: Mon, 4 Jun 2018 08:30:53 +0200
Subject: [PATCH] specialize the generic editors for property editing with icon
 association

---
 .../META-INF/MANIFEST.MF                      |   3 +-
 .../build.properties                          |   3 +-
 .../icons/spring_obj.gif                      | Bin 0 -> 1695 bytes
 .../plugin.xml                                |  36 +++++++++++++++++-
 4 files changed, 39 insertions(+), 3 deletions(-)
 create mode 100644 eclipse-language-servers/org.springframework.tooling.boot.ls/icons/spring_obj.gif

diff --git a/eclipse-language-servers/org.springframework.tooling.boot.ls/META-INF/MANIFEST.MF b/eclipse-language-servers/org.springframework.tooling.boot.ls/META-INF/MANIFEST.MF
index 75a4a75f9..becff1b74 100644
--- a/eclipse-language-servers/org.springframework.tooling.boot.ls/META-INF/MANIFEST.MF
+++ b/eclipse-language-servers/org.springframework.tooling.boot.ls/META-INF/MANIFEST.MF
@@ -22,7 +22,8 @@ Require-Bundle: org.eclipse.jdt.launching;bundle-version="3.9.0",
  org.eclipse.core.resources,
  org.eclipse.ui,
  org.eclipse.ui.ide,
- org.eclipse.jdt.core
+ org.eclipse.jdt.core,
+ org.eclipse.ui.editors;bundle-version="3.11.100"
 Import-Package: com.google.gson;version="2.7.0",
  org.eclipse.jface.preference,
  org.osgi.framework
diff --git a/eclipse-language-servers/org.springframework.tooling.boot.ls/build.properties b/eclipse-language-servers/org.springframework.tooling.boot.ls/build.properties
index 8e982bda7..4016fb23e 100644
--- a/eclipse-language-servers/org.springframework.tooling.boot.ls/build.properties
+++ b/eclipse-language-servers/org.springframework.tooling.boot.ls/build.properties
@@ -4,4 +4,5 @@ bin.includes = META-INF/,\
                .,\
                plugin.xml,\
                servers/,\
-               syntaxes/
+               syntaxes/,\
+               icons/
diff --git a/eclipse-language-servers/org.springframework.tooling.boot.ls/icons/spring_obj.gif b/eclipse-language-servers/org.springframework.tooling.boot.ls/icons/spring_obj.gif
new file mode 100644
index 0000000000000000000000000000000000000000..70b850977509e17726346b7089d979654f53b88b
GIT binary patch
literal 1695
zcmZ?wbhEHb6krfw_|5<V4Pe{=rW$~}hK2(`aOc3XQy+jb)sqx^=4tlKvz)TZaLziX
zrMnE5?($l@D{Aeo;<bk@w;pfVdfI94EW^F$=j=VdcJF1cW7oGHyX|%Ce$ctw$Id<W
zI`=&4T9f6qX_nV!1zp?Jb8VZ`wbM@5-UnTKA9e5fy?f7}KY#rE`DchjfVPc-(GZ|=
z2>k#3VZnkW4Gj(dfd>C)_z$LlG>`=Zia%KxLBcv9TS0lE9Y{BT@o0_!2E!;Aej$KA
zM{v|I{O6SM*s$PWGY4<pihx8X))omBmyQLF%<Q}ZJV7jtiw<}8s~ZW`Ff3y3>XWyx
zNpRTE#5P6UB4!K2!-o#+8cDMPG$%VXPZRT-B9ORn1sfMPmz{y4Q_Godfk|R}1e{n{
h*!d)Menb|ybO=fuQsWV9a&c-(J-;e;x0wQiH2|i_?au%J

literal 0
HcmV?d00001

diff --git a/eclipse-language-servers/org.springframework.tooling.boot.ls/plugin.xml b/eclipse-language-servers/org.springframework.tooling.boot.ls/plugin.xml
index 204c567a1..682338291 100644
--- a/eclipse-language-servers/org.springframework.tooling.boot.ls/plugin.xml
+++ b/eclipse-language-servers/org.springframework.tooling.boot.ls/plugin.xml
@@ -133,7 +133,23 @@
       </command>
    </extension>
    
-
+   
+   <extension
+         point="org.eclipse.ui.editors">
+      <editor
+            class="org.eclipse.ui.internal.genericeditor.ExtensionBasedTextEditor"
+            contributorClass="org.eclipse.ui.editors.text.TextEditorActionContributor"
+            icon="icons/spring_obj.gif"
+            id="SpringBootPropertyEditor"
+            name="Generic Editor - Spring Properties"
+            symbolicFontName="org.eclipse.jdt.ui.PropertiesFileEditor.textfont">
+            <contentTypeBinding
+               contentTypeId="org.springframework.boot.ide.properties.application.properties"
+            /> 
+      </editor>
+   </extension>
+   
+<!--
    <extension
          point="org.eclipse.ui.editors">
       <editorContentTypeBinding
@@ -141,7 +157,24 @@
             editorId="org.eclipse.ui.genericeditor.GenericEditor">
       </editorContentTypeBinding>
    </extension>
+-->
 
+   <extension
+         point="org.eclipse.ui.editors">
+      <editor
+            class="org.eclipse.ui.internal.genericeditor.ExtensionBasedTextEditor"
+            contributorClass="org.eclipse.ui.editors.text.TextEditorActionContributor"
+            icon="icons/spring_obj.gif"
+            id="SpringBootYMLPropertyEditor"
+            name="Generic Editor - Spring YAML Properties"
+            symbolicFontName="org.eclipse.jdt.ui.PropertiesFileEditor.textfont">
+            <contentTypeBinding
+               contentTypeId="org.springframework.boot.ide.properties.application.yml"
+            /> 
+      </editor>
+   </extension>
+
+<!--
    <extension
          point="org.eclipse.ui.editors">
       <editorContentTypeBinding
@@ -149,6 +182,7 @@
             editorId="org.eclipse.ui.genericeditor.GenericEditor">
       </editorContentTypeBinding>
    </extension>
+-->
 
    <extension
          point="org.eclipse.ui.genericeditor.presentationReconcilers">