concourse: Allow redefinition of built in resource types

See: https://github.com/spring-projects/sts4/issues/196
This commit is contained in:
Kris De Volder
2019-02-04 15:30:13 -08:00
parent 0eb4645380
commit a516d2d9ee
4 changed files with 48 additions and 10 deletions

View File

@@ -732,6 +732,42 @@ public class ConcourseEditorTest {
);
}
@Test
public void reconcileDuplicateResourceTypeNames_exempt_Builtins() throws Exception {
//See https://github.com/spring-projects/sts4/issues/196
Editor editor;
//Redefintion of built-in resource-type: no errors!
editor = harness.newEditor(
"resource_types:\n" +
"- name: docker-image\n" +
" privileged: true\n" +
" type: docker-image\n" +
" source:\n" +
" repository: concourse/docker-image-resource"
);
editor.assertProblems(/*None*/);
//... unless they are redefined twice...
editor = harness.newEditor(
"resource_types:\n" +
"- name: docker-image\n" +
" privileged: true\n" +
" type: docker-image\n" +
" source:\n" +
" repository: concourse/docker-image-resource\n" +
"- name: docker-image\n" +
" privileged: true\n" +
" type: docker-image\n" +
" source:\n" +
" repository: concourse/docker-image-resource"
);
editor.assertProblems(
"docker-image|Duplicate",
"docker-image|Duplicate"
);
}
@Test
public void violatedPropertyConstraintsAreWarnings() throws Exception {
Editor editor;