From a77433d15c173827e944f53c791f506a0001b99e Mon Sep 17 00:00:00 2001 From: "nsingh@pivotal.io" Date: Fri, 4 Jan 2019 05:01:16 -0800 Subject: [PATCH] PT 162742296 - Remove per-section separators for RM and Conditionals For now, remove separation to make all live hovers consistent (for example, live beans do not have separation, and there is no separation between our live hovers and JDT) --- .../java/conditionals/ConditionalsLiveHoverProvider.java | 6 +----- .../java/requestmapping/RequestMappingHoverProvider.java | 7 +------ 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/headless-services/spring-boot-language-server/src/main/java/org/springframework/ide/vscode/boot/java/conditionals/ConditionalsLiveHoverProvider.java b/headless-services/spring-boot-language-server/src/main/java/org/springframework/ide/vscode/boot/java/conditionals/ConditionalsLiveHoverProvider.java index 0bfe70a54..957f9f01f 100644 --- a/headless-services/spring-boot-language-server/src/main/java/org/springframework/ide/vscode/boot/java/conditionals/ConditionalsLiveHoverProvider.java +++ b/headless-services/spring-boot-language-server/src/main/java/org/springframework/ide/vscode/boot/java/conditionals/ConditionalsLiveHoverProvider.java @@ -1,5 +1,5 @@ /******************************************************************************* - * Copyright (c) 2017, 2018 Pivotal, Inc. + * Copyright (c) 2017, 2019 Pivotal, Inc. * All rights reserved. This program and the accompanying materials * are made available under the terms of the Eclipse Public License v1.0 * which accompanies this distribution, and is available at @@ -119,10 +119,6 @@ public class ConditionalsLiveHoverProvider implements HoverProvider { LiveConditional conditional = conditionals.get(i); hoverContent.add(Either.forLeft(conditional.getMessage())); hoverContent.add(Either.forLeft(LiveHoverUtils.niceAppName(conditional.getProcessId(), conditional.getProcessName()))); - - if (i < conditionals.size() - 1) { - hoverContent.add(Either.forLeft("---")); - } } } diff --git a/headless-services/spring-boot-language-server/src/main/java/org/springframework/ide/vscode/boot/java/requestmapping/RequestMappingHoverProvider.java b/headless-services/spring-boot-language-server/src/main/java/org/springframework/ide/vscode/boot/java/requestmapping/RequestMappingHoverProvider.java index 2dfc67c59..facc6892a 100644 --- a/headless-services/spring-boot-language-server/src/main/java/org/springframework/ide/vscode/boot/java/requestmapping/RequestMappingHoverProvider.java +++ b/headless-services/spring-boot-language-server/src/main/java/org/springframework/ide/vscode/boot/java/requestmapping/RequestMappingHoverProvider.java @@ -1,5 +1,5 @@ /******************************************************************************* - * Copyright (c) 2017, 2018 Pivotal, Inc. + * Copyright (c) 2017, 2019 Pivotal, Inc. * All rights reserved. This program and the accompanying materials * are made available under the terms of the Eclipse Public License v1.0 * which accompanies this distribution, and is available at @@ -284,11 +284,6 @@ public class RequestMappingHoverProvider implements HoverProvider { Renderables.lineBreak(), Renderables.mdBlob(LiveHoverUtils.niceAppName(app)) ).toMarkdown())); - if (i < mappingMethods.size() - 1) { - // Three dashes == line separator in Markdown - hoverContent.add(Either.forLeft("---")); - } - } }