From aedab760d603a016be43bb758a00dc88ef6be13a Mon Sep 17 00:00:00 2001 From: Kris De Volder Date: Wed, 9 Aug 2017 17:00:07 -0700 Subject: [PATCH] Add missing hoverdoc for 'vm_extensions' property --- .../ide/vscode/bosh/BoshCloudConfigSchema.java | 1 - .../cloud-config/CloudConfig/vm_extensions.md | 10 ++++++++++ .../ide/vscode/bosh/BoshEditorTest.java | 2 ++ 3 files changed, 12 insertions(+), 1 deletion(-) create mode 100644 headless-services/bosh-language-server/src/main/resources/cloud-config/CloudConfig/vm_extensions.md diff --git a/headless-services/bosh-language-server/src/main/java/org/springframework/ide/vscode/bosh/BoshCloudConfigSchema.java b/headless-services/bosh-language-server/src/main/java/org/springframework/ide/vscode/bosh/BoshCloudConfigSchema.java index fad4edbe9..e06d3c4f7 100644 --- a/headless-services/bosh-language-server/src/main/java/org/springframework/ide/vscode/bosh/BoshCloudConfigSchema.java +++ b/headless-services/bosh-language-server/src/main/java/org/springframework/ide/vscode/bosh/BoshCloudConfigSchema.java @@ -132,7 +132,6 @@ public class BoshCloudConfigSchema extends SchemaSupport implements YamlSchema { for (YType defType : getDefinitionTypes()) { toplevelType.require(Constraints.uniqueDefinition(astTypes, defType, YamlSchemaProblems.problemType("BOSH_CC_DUPLICATE_"+defType))); } - } private YType createNetworkBlockSchema(BoshModels models) { diff --git a/headless-services/bosh-language-server/src/main/resources/cloud-config/CloudConfig/vm_extensions.md b/headless-services/bosh-language-server/src/main/resources/cloud-config/CloudConfig/vm_extensions.md new file mode 100644 index 000000000..18d4051ec --- /dev/null +++ b/headless-services/bosh-language-server/src/main/resources/cloud-config/CloudConfig/vm_extensions.md @@ -0,0 +1,10 @@ +Specifies the [VM extensions](https://bosh.io/docs/terminology.html#vm-extension) available to deployments. + +Example: + + vm_extensions: + - name: pub-lbs + cloud_properties: + elbs: [main] + +Any IaaS specific configuration could be placed into a VM extension’s `cloud_properties`. \ No newline at end of file diff --git a/headless-services/bosh-language-server/src/test/java/org/springframework/ide/vscode/bosh/BoshEditorTest.java b/headless-services/bosh-language-server/src/test/java/org/springframework/ide/vscode/bosh/BoshEditorTest.java index e87832bd1..24ed747b3 100644 --- a/headless-services/bosh-language-server/src/test/java/org/springframework/ide/vscode/bosh/BoshEditorTest.java +++ b/headless-services/bosh-language-server/src/test/java/org/springframework/ide/vscode/bosh/BoshEditorTest.java @@ -1900,6 +1900,7 @@ public class BoshEditorTest { Editor editor = harness.newEditor(LanguageId.BOSH_CLOUD_CONFIG, "azs: []\n" + "vm_types: []\n" + + "vm_extensions: []\n" + "disk_types: []\n" + "networks: []\n" + "compilation: {}\n" @@ -1909,6 +1910,7 @@ public class BoshEditorTest { editor.assertHoverContains("vm_types", "Specifies the [VM types](https://bosh.io/docs/terminology.html#vm-type) available to deployments."); editor.assertHoverContains("disk_types", "Specifies the [disk types](https://bosh.io/docs/terminology.html#disk-types) available to deployments."); editor.assertHoverContains("compilation", "A compilation definition allows to specify VM characteristics."); + editor.assertHoverContains("vm_extensions", "Specifies the [VM extensions](https://bosh.io/docs/terminology.html#vm-extension) available to deployments."); } @Test public void cloudconfig_compilation_subproperties() throws Exception {