Spring/spring-tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Refactor / simplify how Yaml schema Constraints work:

Browse Source 
- simplify access to DynamicSchemaContext.
 - allow constraints on non-map type nodes.

These changes pave the way to checking inertaction constraint on job-name
used in 'passed' attribute.
This commit is contained in:
Kris De Volder
2017-04-21 12:16:37 -07:00
parent 2181130e78
commit da66be7aec
9 changed files with 188 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files

102
headless-services/concourse-language-server/src/test/java/org/springframework/ide/vscode/concourse/ConcourseEditorTest.java
View File

@@ -3116,6 +3116,108 @@ public class ConcourseEditorTest {
);
}
@Ignore @Test public void reconcilerJobFromPassedAttributeMustInteractWithResource() throws Exception {
Editor editor;
editor = harness.newEditor(
"resources:\n" +
"- name: version\n" +
" type: semver\n" +
"- name: source-repo\n" +
" type: git\n" +
"jobs:\n" +
"- name: build-it\n" +
" plan:\n" +
" - aggregate:\n" +
" # - put: version\n" +
" - get: source-repo\n" +
"- name: test-it\n" +
" plan:\n" +
" - get: source-repo\n" +
" passed:\n" +
" - build-it # <- good\n" +
" - get: version\n" +
" passed:\n" +
" - build-it # <- bad\n"
);
editor.assertProblems(
"build-it^ # <- bad|Job 'build-it' doesn't interact with the resource 'version'"
);
editor = harness.newEditor(
"resources:\n" +
"- name: version\n" +
" type: semver\n" +
"- name: source-repo\n" +
" type: git\n" +
"jobs:\n" +
"- name: build-it\n" +
" plan:\n" +
" - aggregate:\n" +
" - put: version\n" +
" # - get: source-repo\n" +
"- name: test-it\n" +
" plan:\n" +
" - get: source-repo\n" +
" passed:\n" +
" - build-it # <- bad\n" +
" - get: version\n" +
" passed:\n" +
" - build-it # <- good\n"
);
editor.assertProblems(
"build-it^ # <- bad|Job 'build-it' doesn't interact with the resource 'source-repo'"
);
//Check that we find interactions in steps that are at the top-level of the plan:
editor = harness.newEditor(
"resources:\n" +
"- name: version\n" +
" type: semver\n" +
"- name: source-repo\n" +
" type: git\n" +
"jobs:\n" +
"- name: build-it\n" +
" plan:\n" +
" - aggregate:\n" +
" - put: version\n" +
" - get: source-repo\n" +
"- name: test-it\n" +
" plan:\n" +
" - get: source-repo\n" +
" passed:\n" +
" - build-it\n" +
" - get: version\n" +
" passed:\n" +
" - build-it\n"
);
editor.assertProblems(/*NONE*/);
//Check that we find interactions in steps that are nested in other steps
editor = harness.newEditor(
"resources:\n" +
"- name: version\n" +
" type: semver\n" +
"- name: source-repo\n" +
" type: git\n" +
"jobs:\n" +
"- name: build-it\n" +
" plan:\n" +
" - put: version\n" +
" - get: source-repo\n" +
"- name: test-it\n" +
" plan:\n" +
" - get: source-repo\n" +
" passed:\n" +
" - build-it\n" +
" - get: version\n" +
" passed:\n" +
" - build-it\n"
);
editor.assertProblems(/*NONE*/);
}
//////////////////////////////////////////////////////////////////////////////
private void assertContextualCompletions(String conText, String textBefore, String... textAfter) throws Exception {