diff --git a/headless-services/commons/commons-language-server/src/main/java/org/springframework/ide/vscode/commons/languageserver/completion/VscodeCompletionEngineAdapter.java b/headless-services/commons/commons-language-server/src/main/java/org/springframework/ide/vscode/commons/languageserver/completion/VscodeCompletionEngineAdapter.java index ec3c6d28b..2dd8ac408 100644 --- a/headless-services/commons/commons-language-server/src/main/java/org/springframework/ide/vscode/commons/languageserver/completion/VscodeCompletionEngineAdapter.java +++ b/headless-services/commons/commons-language-server/src/main/java/org/springframework/ide/vscode/commons/languageserver/completion/VscodeCompletionEngineAdapter.java @@ -29,9 +29,11 @@ import org.eclipse.lsp4j.TextEdit; import org.slf4j.Logger; import org.slf4j.LoggerFactory; import org.springframework.ide.vscode.commons.languageserver.completion.DocumentEdits.TextReplace; +import org.springframework.ide.vscode.commons.languageserver.util.LspClient; import org.springframework.ide.vscode.commons.languageserver.util.SimpleLanguageServer; import org.springframework.ide.vscode.commons.languageserver.util.SimpleTextDocumentService; import org.springframework.ide.vscode.commons.languageserver.util.SortKeys; +import org.springframework.ide.vscode.commons.languageserver.util.LspClient.Client; import org.springframework.ide.vscode.commons.util.BadLocationException; import org.springframework.ide.vscode.commons.util.Renderable; import org.springframework.ide.vscode.commons.util.StringUtil; @@ -160,6 +162,10 @@ public class VscodeCompletionEngineAdapter implements VscodeCompletionEngine { } } list.setItems(items); + if (LspClient.currentClient()==Client.ECLIPSE) { + list.setIsIncomplete(true); //This is a hack. It bypasses lsp4e filtering / sorting because it + // it behaves totally bonkers. See: https://bugs.eclipse.org/bugs/show_bug.cgi?id=535823 + } return list; }) .subscribeOn(Schedulers.elastic()); //!!! without this the mono will just be computed on the same thread that calls it. diff --git a/vscode-extensions/vscode-spring-boot/build.sh b/vscode-extensions/vscode-spring-boot/build.sh index d69d8b015..407149be5 100755 --- a/vscode-extensions/vscode-spring-boot/build.sh +++ b/vscode-extensions/vscode-spring-boot/build.sh @@ -28,5 +28,5 @@ cd $workdir npm install rm -fr *.vsix npm run vsce-package -rm -fr ${home}/.vscode/extensions/Pivotal.vscode-spring-boot-* +rm -fr ${home}/.vscode/extensions/*vscode-spring-boot-* code --install-extension *.vsix