From f93d5f513c3a7ff4929b6f0cae000361da68e8c2 Mon Sep 17 00:00:00 2001 From: Kris De Volder Date: Mon, 17 Jul 2017 09:59:37 -0700 Subject: [PATCH] Better test coverage around deprecated `director_uuid` attribute --- .../vscode/bosh/BoshDeploymentManifestSchema.java | 1 - .../ide/vscode/concourse/BoshEditorTest.java | 12 +++++++++++- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/headless-services/bosh-language-server/src/main/java/org/springframework/ide/vscode/bosh/BoshDeploymentManifestSchema.java b/headless-services/bosh-language-server/src/main/java/org/springframework/ide/vscode/bosh/BoshDeploymentManifestSchema.java index 6b4189514..26d4364cb 100644 --- a/headless-services/bosh-language-server/src/main/java/org/springframework/ide/vscode/bosh/BoshDeploymentManifestSchema.java +++ b/headless-services/bosh-language-server/src/main/java/org/springframework/ide/vscode/bosh/BoshDeploymentManifestSchema.java @@ -16,7 +16,6 @@ import java.util.UUID; import org.springframework.ide.vscode.commons.util.Assert; import org.springframework.ide.vscode.commons.util.Renderable; import org.springframework.ide.vscode.commons.util.Renderables; -import org.springframework.ide.vscode.commons.util.ValueParser; import org.springframework.ide.vscode.commons.util.ValueParsers; import org.springframework.ide.vscode.commons.yaml.schema.YType; import org.springframework.ide.vscode.commons.yaml.schema.YTypeFactory; diff --git a/headless-services/bosh-language-server/src/test/java/org/springframework/ide/vscode/concourse/BoshEditorTest.java b/headless-services/bosh-language-server/src/test/java/org/springframework/ide/vscode/concourse/BoshEditorTest.java index a968591b1..18d363498 100644 --- a/headless-services/bosh-language-server/src/test/java/org/springframework/ide/vscode/concourse/BoshEditorTest.java +++ b/headless-services/bosh-language-server/src/test/java/org/springframework/ide/vscode/concourse/BoshEditorTest.java @@ -13,7 +13,6 @@ package org.springframework.ide.vscode.concourse; import static org.springframework.ide.vscode.languageserver.testharness.Editor.PLAIN_COMPLETION; import org.junit.Before; -import org.junit.Ignore; import org.junit.Test; import org.springframework.ide.vscode.bosh.BoshLanguageServer; import org.springframework.ide.vscode.commons.util.text.LanguageId; @@ -633,5 +632,16 @@ public class BoshEditorTest { ); editor.ignoreProblem(YamlSchemaProblems.DEPRECATED_PROPERTY); editor.assertProblems(/*NONE*/); + + editor = harness.newEditor( + "name: foo\n" + + "director_uuid: dca5480a-6b0e-11e7-907b-a6006ad3dba0\n" + + "networks: {}" //This makes it a V1 schema + ); + editor.ignoreProblem(YamlSchemaProblems.MISSING_PROPERTY); + editor.assertProblems( + "director_uuid|bosh v2 CLI no longer checks or requires", + "networks|Deprecated: 'networks' is a V1 schema property" + ); } } \ No newline at end of file