From 5154e49b6a353b17626c9908e9a59d42bc7f8ec4 Mon Sep 17 00:00:00 2001
From: Mark Paluch <mpaluch@pivotal.io>
Date: Mon, 2 Dec 2019 09:14:48 +0100
Subject: [PATCH] Polishing

Add tests for write and delete.

Closes gh-503
Closes gh-511
---
 ...eVaultTemplateGenericIntegrationTests.java | 22 +++++++++++++++++++
 .../VaultTemplateGenericIntegrationTests.java |  7 ++++++
 2 files changed, 29 insertions(+)

diff --git a/spring-vault-core/src/test/java/org/springframework/vault/core/ReactiveVaultTemplateGenericIntegrationTests.java b/spring-vault-core/src/test/java/org/springframework/vault/core/ReactiveVaultTemplateGenericIntegrationTests.java
index 79db7f8e..18c03a0d 100644
--- a/spring-vault-core/src/test/java/org/springframework/vault/core/ReactiveVaultTemplateGenericIntegrationTests.java
+++ b/spring-vault-core/src/test/java/org/springframework/vault/core/ReactiveVaultTemplateGenericIntegrationTests.java
@@ -30,6 +30,7 @@ import reactor.test.StepVerifier;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.test.context.ContextConfiguration;
 import org.springframework.test.context.junit.jupiter.SpringExtension;
+import org.springframework.vault.VaultException;
 import org.springframework.vault.domain.Person;
 import org.springframework.vault.support.ObjectMapperSupplier;
 import org.springframework.vault.util.IntegrationTestSupport;
@@ -129,6 +130,13 @@ class ReactiveVaultTemplateGenericIntegrationTests extends IntegrationTestSuppor
 				}).verifyComplete();
 	}
 
+	@Test
+	void listShouldNotReturnAbsentKey() {
+
+		vaultOperations.list("foo").collectList().as(StepVerifier::create)
+				.consumeNextWith(actual -> assertThat(actual).isEmpty()).verifyComplete();
+	}
+
 	@Test
 	void listShouldReturnExistingKey() {
 
@@ -167,4 +175,18 @@ class ReactiveVaultTemplateGenericIntegrationTests extends IntegrationTestSuppor
 
 				}).verifyComplete();
 	}
+
+	@Test
+	void deleteUnknownPathShouldFail() {
+
+		vaultOperations.delete("foobar").as(StepVerifier::create)
+				.verifyError(VaultException.class);
+	}
+
+	@Test
+	void writeUnknownPathShouldFail() {
+
+		vaultOperations.write("foobar").as(StepVerifier::create)
+				.verifyError(VaultException.class);
+	}
 }
diff --git a/spring-vault-core/src/test/java/org/springframework/vault/core/VaultTemplateGenericIntegrationTests.java b/spring-vault-core/src/test/java/org/springframework/vault/core/VaultTemplateGenericIntegrationTests.java
index c8f2f2f0..89e7be3f 100644
--- a/spring-vault-core/src/test/java/org/springframework/vault/core/VaultTemplateGenericIntegrationTests.java
+++ b/spring-vault-core/src/test/java/org/springframework/vault/core/VaultTemplateGenericIntegrationTests.java
@@ -126,6 +126,13 @@ class VaultTemplateGenericIntegrationTests extends IntegrationTestSupport {
 		assertThat(keys).contains("mykey");
 	}
 
+	@Test
+	void listShouldNotReturnAbsentKey() {
+
+		List<String> keys = vaultOperations.list("foo");
+		assertThat(keys).isEmpty();
+	}
+
 	@Test
 	void deleteShouldRemoveKey() {