From 93384d6425d60116f67dae78df84d7c63020357c Mon Sep 17 00:00:00 2001 From: Mark Paluch Date: Sat, 28 Jul 2018 20:59:20 +0200 Subject: [PATCH] Guard tests against unsupported Vault versions. Closes gh-263. --- .../vault/core/VaultPkiTemplateIntegrationTests.java | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/spring-vault-core/src/test/java/org/springframework/vault/core/VaultPkiTemplateIntegrationTests.java b/spring-vault-core/src/test/java/org/springframework/vault/core/VaultPkiTemplateIntegrationTests.java index e4c2b993..51297e24 100644 --- a/spring-vault-core/src/test/java/org/springframework/vault/core/VaultPkiTemplateIntegrationTests.java +++ b/spring-vault-core/src/test/java/org/springframework/vault/core/VaultPkiTemplateIntegrationTests.java @@ -46,8 +46,10 @@ import org.springframework.vault.support.VaultCertificateRequest; import org.springframework.vault.support.VaultCertificateResponse; import org.springframework.vault.support.VaultSignCertificateRequestResponse; import org.springframework.vault.util.IntegrationTestSupport; +import org.springframework.vault.util.Version; import static org.assertj.core.api.Assertions.assertThat; +import static org.junit.Assume.assumeTrue; import static org.springframework.vault.util.Settings.findWorkDir; /** @@ -59,6 +61,8 @@ import static org.springframework.vault.util.Settings.findWorkDir; @ContextConfiguration(classes = VaultIntegrationTestConfiguration.class) public class VaultPkiTemplateIntegrationTests extends IntegrationTestSupport { + private static final Version NO_TTL_UNIT_REQUIRED_FROM = Version.parse("0.7.3"); + @Autowired private VaultOperations vaultOperations; @@ -116,6 +120,9 @@ public class VaultPkiTemplateIntegrationTests extends IntegrationTestSupport { @Test public void issueCertificateWithTtlShouldCreateCertificate() { + assumeTrue(prepare().getVersion().isGreaterThanOrEqualTo( + NO_TTL_UNIT_REQUIRED_FROM)); + VaultCertificateRequest request = VaultCertificateRequest.builder() .ttl(Duration.ofHours(48)).commonName("hello.example.com").build();