From ee23af8ba0ef20fa72060ae18b383ec22e6a4ab0 Mon Sep 17 00:00:00 2001 From: Mark Paluch Date: Fri, 25 Apr 2025 11:50:11 +0200 Subject: [PATCH] =?UTF-8?q?Log=20exception=20when=20`KeyValueDelegate.getM?= =?UTF-8?q?ountInfo(=E2=80=A6)`=20fails.?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Closes gh-888 --- .../vault/core/util/KeyValueDelegate.java | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/spring-vault-core/src/main/java/org/springframework/vault/core/util/KeyValueDelegate.java b/spring-vault-core/src/main/java/org/springframework/vault/core/util/KeyValueDelegate.java index a05552f7..caa3a559 100644 --- a/spring-vault-core/src/main/java/org/springframework/vault/core/util/KeyValueDelegate.java +++ b/spring-vault-core/src/main/java/org/springframework/vault/core/util/KeyValueDelegate.java @@ -20,6 +20,9 @@ import java.util.LinkedHashMap; import java.util.Map; import java.util.function.Supplier; +import org.apache.commons.logging.Log; +import org.apache.commons.logging.LogFactory; + import org.springframework.lang.Nullable; import org.springframework.util.ConcurrentReferenceHashMap; import org.springframework.util.StringUtils; @@ -40,6 +43,8 @@ import org.springframework.vault.support.VaultResponse; */ public class KeyValueDelegate { + private static final Log logger = LogFactory.getLog(KeyValueDelegate.class); + private final Map mountInfo; private final VaultOperations operations; @@ -125,13 +130,20 @@ public class KeyValueDelegate { if (mountInfo == null) { try { - mountInfo = doGetMountInfo(path); } catch (VaultException e) { + if (logger.isDebugEnabled()) { + logger.debug("Unable to determine mount information for [%s]. Returning unavailable MountInfo: %s" + .formatted(path, e.getMessage()), e); + } return MountInfo.unavailable(); } catch (RuntimeException e) { + if (logger.isDebugEnabled()) { + logger.debug("Unable to determine mount information for [%s]. Caching unavailable MountInfo: %s" + .formatted(path, e.getMessage()), e); + } mountInfo = MountInfo.unavailable(); }