From 1d9ac8edb5077e0f79b3a285f563dae89c158da1 Mon Sep 17 00:00:00 2001 From: Jeremy Grelle Date: Tue, 1 Apr 2008 15:21:59 +0000 Subject: [PATCH] Fix for SWF-656. Needed to call FacesContext.renderResponse from the FlowActionListener. --- .../org/springframework/faces/webflow/FlowActionListener.java | 1 + .../springframework/faces/webflow/FlowActionListenerTests.java | 2 ++ 2 files changed, 3 insertions(+) diff --git a/spring-faces/src/main/java/org/springframework/faces/webflow/FlowActionListener.java b/spring-faces/src/main/java/org/springframework/faces/webflow/FlowActionListener.java index 3095caa7..95c4bb8b 100644 --- a/spring-faces/src/main/java/org/springframework/faces/webflow/FlowActionListener.java +++ b/spring-faces/src/main/java/org/springframework/faces/webflow/FlowActionListener.java @@ -68,5 +68,6 @@ public class FlowActionListener implements ActionListener { logger.debug("No action event detected"); context.getExternalContext().getRequestMap().remove(JsfView.EVENT_KEY); } + context.renderResponse(); } } diff --git a/spring-faces/src/test/java/org/springframework/faces/webflow/FlowActionListenerTests.java b/spring-faces/src/test/java/org/springframework/faces/webflow/FlowActionListenerTests.java index 6a752157..198dc060 100644 --- a/spring-faces/src/test/java/org/springframework/faces/webflow/FlowActionListenerTests.java +++ b/spring-faces/src/test/java/org/springframework/faces/webflow/FlowActionListenerTests.java @@ -52,6 +52,7 @@ public class FlowActionListenerTests extends TestCase { JsfView.EVENT_KEY)); assertEquals("The event should be " + outcome, outcome, jsfMock.externalContext().getRequestMap().get( JsfView.EVENT_KEY)); + assertTrue("Render response flag should be set", jsfMock.facesContext().getRenderResponse()); } public final void testProcessAction_NullOutcome() { @@ -66,6 +67,7 @@ public class FlowActionListenerTests extends TestCase { assertFalse("An unexpected event was signaled", jsfMock.externalContext().getRequestMap().containsKey( JsfView.EVENT_KEY)); + assertTrue("Render response flag should be set", jsfMock.facesContext().getRenderResponse()); } private class MethodBindingStub extends MethodBinding {