diff --git a/spring-faces/src/main/java/META-INF/spring-faces/SpringFaces-Dojo.js b/spring-faces/src/main/java/META-INF/spring-faces/SpringFaces-Dojo.js new file mode 100644 index 00000000..f27d73a9 --- /dev/null +++ b/spring-faces/src/main/java/META-INF/spring-faces/SpringFaces-Dojo.js @@ -0,0 +1,21 @@ +SpringFaces.DojoGenericFieldAdvisor = function(config){ + + dojo.mixin(this, config); +}; + +SpringFaces.DojoGenericFieldAdvisor.prototype = { + + targetElId : "", + decoratorType : "", + decorator : null, + decoratorAttrs : "", + + apply : function(){ + + this.decorator = eval("new "+ this.decoratorType + "(" + this.decoratorAttrs +", dojo.byId('"+this.targetElId+"'));" ); + + this.decorator.startup(); + } +}; + +dojo.addOnLoad(SpringFaces.applyAdvisors); \ No newline at end of file diff --git a/spring-faces/src/main/java/META-INF/spring-faces/SpringFaces-Ext.js b/spring-faces/src/main/java/META-INF/spring-faces/SpringFaces-Ext.js new file mode 100644 index 00000000..dcee20e0 --- /dev/null +++ b/spring-faces/src/main/java/META-INF/spring-faces/SpringFaces-Ext.js @@ -0,0 +1,26 @@ +SpringFaces.ExtGenericFieldAdvisor = function(config){ + + Ext.apply(this, config); +}; + +SpringFaces.ExtGenericFieldAdvisor.prototype = { + + targetElId : "", + msgElId : "", + decoratorType : "", + decorator : null, + decoratorAttrs : "", + + apply : function(){ + + var target = document.getElementById(this.targetElId); + var msgEl = document.getElementById(this.msgElId); + + this.decorator = eval("new "+ this.decoratorType + "(" + this.decoratorAttrs +");" ); + + this.decorator.msgTarget=msgEl; + this.decorator.applyTo(target); + } +}; + +Ext.onReady(SpringFaces.applyAdvisors); \ No newline at end of file diff --git a/spring-faces/src/main/java/META-INF/spring-faces/SpringFaces.js b/spring-faces/src/main/java/META-INF/spring-faces/SpringFaces.js index a1f03fb3..3a665608 100644 --- a/spring-faces/src/main/java/META-INF/spring-faces/SpringFaces.js +++ b/spring-faces/src/main/java/META-INF/spring-faces/SpringFaces.js @@ -2,31 +2,6 @@ SpringFaces = {}; SpringFaces.advisors = []; -SpringFaces.ExtGenericFieldAdvisor = function(config){ - - Ext.apply(this, config); -}; - -SpringFaces.ExtGenericFieldAdvisor.prototype = { - - targetElId : "", - msgElId : "", - decoratorType : "", - decorator : null, - decoratorAttrs : "", - - apply : function(){ - - var target = document.getElementById(this.targetElId); - var msgEl = document.getElementById(this.msgElId); - - this.decorator = eval("new "+ this.decoratorType + "(" + this.decoratorAttrs +");" ); - - this.decorator.msgTarget=msgEl; - this.decorator.applyTo(target); - } -}; - SpringFaces.applyAdvisors = function(){ for (var x=0; x 0 && lastModified / 1000 <= ifModifiedSince / 1000) { response.setStatus(HttpServletResponse.SC_NOT_MODIFIED); diff --git a/spring-faces/src/test/java/org/springframework/faces/ui/resource/ResolveAndRenderResourceActionTests.java b/spring-faces/src/test/java/org/springframework/faces/ui/resource/ResolveAndRenderResourceActionTests.java index ddb0814c..7fc83ab4 100644 --- a/spring-faces/src/test/java/org/springframework/faces/ui/resource/ResolveAndRenderResourceActionTests.java +++ b/spring-faces/src/test/java/org/springframework/faces/ui/resource/ResolveAndRenderResourceActionTests.java @@ -22,7 +22,7 @@ public class ResolveAndRenderResourceActionTests extends TestCase { ExternalContext externalContext = createMock(ExternalContext.class); RequestContext requestContext = createMock(RequestContext.class); - ServletContext servletContext = new MimeAwareMockServletContext(); + ServletContext servletContext = new ResourceTestMockServletContext(); MockHttpServletResponse response = new MockHttpServletResponse(); MockHttpServletRequest request = new MockHttpServletRequest(); @@ -52,10 +52,24 @@ public class ResolveAndRenderResourceActionTests extends TestCase { action.execute(requestContext); } - private class MimeAwareMockServletContext extends MockServletContext { + public final void testExecute_ResourceNotFound() throws Exception { + + requestPath = new RequestPath("/xxx/xxx.js"); + + expect(externalContext.getRequestPath()).andStubReturn(requestPath); + + replay(new Object[] { requestContext, externalContext }); + + action.execute(requestContext); + + assertEquals(404, response.getStatus()); + } + + private class ResourceTestMockServletContext extends MockServletContext { public String getMimeType(String filePath) { return null; } + } }