Spring/spring-webflow
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

code review

Browse Source
This commit is contained in:
Keith Donald
2008-03-25 23:36:13 +00:00
parent 5ba34a8321
commit 565e34a1eb
38 changed files with 108 additions and 118 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
spring-binding/src/test/java/org/springframework/binding/convert/support/ConversionExecutorImplTests.java → spring-binding/src/test/java/org/springframework/binding/convert/service/ConversionExecutorImplTests.java
View File

@@ -13,23 +13,25 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.springframework.binding.convert.support;
package org.springframework.binding.convert.service;
import java.util.Date;
import junit.framework.TestCase;
import org.springframework.binding.convert.ConversionException;
import org.springframework.binding.convert.converters.AbstractConverter;
import org.springframework.binding.convert.service.StaticConversionExecutor;
/**
* Test case for {@link ConversionExecutorImpl}.
* Test case for {@link StaticConversionExecutor}.
*/
public class ConversionExecutorImplTests extends TestCase {
private ConversionExecutorImpl conversionExecutor;
private StaticConversionExecutor conversionExecutor;
protected void setUp() throws Exception {
conversionExecutor = new ConversionExecutorImpl(String.class, Date.class, new TestTextToDate());
conversionExecutor = new StaticConversionExecutor(String.class, Date.class, new TestTextToDate());
}
public void testTypeConversion() {

9
spring-binding/src/test/java/org/springframework/binding/convert/support/DefaultConversionServiceTests.java → spring-binding/src/test/java/org/springframework/binding/convert/service/DefaultConversionServiceTests.java
View File

@@ -13,7 +13,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.springframework.binding.convert.support;
package org.springframework.binding.convert.service;
import java.util.ArrayList;
import java.util.HashMap;
@@ -24,6 +24,9 @@ import junit.framework.TestCase;
import org.springframework.binding.convert.ConversionException;
import org.springframework.binding.convert.ConversionExecutor;
import org.springframework.binding.convert.Converter;
import org.springframework.binding.convert.converters.TextToBoolean;
import org.springframework.binding.convert.service.DefaultConversionService;
import org.springframework.binding.convert.service.StaticConversionExecutor;
/**
* Test case for the default conversion service.
@@ -51,7 +54,7 @@ public class DefaultConversionServiceTests extends TestCase {
DefaultConversionService service = new DefaultConversionService();
ConversionExecutorImpl executor = (ConversionExecutorImpl) service.getConversionExecutor(String.class,
StaticConversionExecutor executor = (StaticConversionExecutor) service.getConversionExecutor(String.class,
Boolean.class);
assertNotSame(customConverter, executor.getConverter());
try {
@@ -63,7 +66,7 @@ public class DefaultConversionServiceTests extends TestCase {
service.addConverter(customConverter);
executor = (ConversionExecutorImpl) service.getConversionExecutor(String.class, Boolean.class);
executor = (StaticConversionExecutor) service.getConversionExecutor(String.class, Boolean.class);
assertSame(customConverter, executor.getConverter());
assertTrue(((Boolean) executor.execute("ja")).booleanValue());
}