Code polishing after analysis with FindBugs and PMD.

spring-binding/src/main/java/org/springframework/binding/convert/ConversionExecutor.java

@@ -15,8 +15,6 @@
  */
 package org.springframework.binding.convert;
 
-import java.io.Serializable;
-
 import org.springframework.core.style.ToStringCreator;
 import org.springframework.util.Assert;
 
@@ -29,7 +27,7 @@ import org.springframework.util.Assert;
  * 
  * @author Keith Donald
  */
-public class ConversionExecutor implements Serializable {
+public class ConversionExecutor {
 
 	/**
 	 * The source value type this executor will attempt to convert from.

spring-binding/src/main/java/org/springframework/binding/expression/EvaluationAttempt.java

@@ -15,8 +15,6 @@
  */
 package org.springframework.binding.expression;
 
-import java.io.Serializable;
-
 import org.springframework.core.style.ToStringCreator;
 
 /**
@@ -24,7 +22,7 @@ import org.springframework.core.style.ToStringCreator;
  * 
  * @author Keith Donald
  */
-public class EvaluationAttempt implements Serializable {
+public class EvaluationAttempt {
 
 	/**
 	 * The expression that attempted to evaluate.

spring-binding/src/main/java/org/springframework/binding/format/FormatterFactory.java

@@ -15,8 +15,6 @@
  */
 package org.springframework.binding.format;
 
-import java.text.Format;
-
 /**
  * Source for shared and commonly used <code>Formatters</code>.
  * <p>
@@ -24,7 +22,7 @@ import java.text.Format;
  * aren't thread safe: so implementations of this service should take care to
  * synchronize them as neccessary.
  * 
- * @see Format
+ * @see java.text.Format
  * 
  * @author Keith Donald
  */

spring-binding/src/main/java/org/springframework/binding/method/MethodInvocationException.java

@@ -46,6 +46,8 @@ public class MethodInvocationException extends NestedRuntimeException {
 	 */
 	public MethodInvocationException(MethodSignature methodSignature, Object[] arguments, Exception cause) {
 		super("Unable to invoke method " + methodSignature + " with arguments " + StylerUtils.style(arguments), cause);
+		this.methodSignature = methodSignature;
+		this.arguments = arguments;
 	}
 
 	/**

spring-binding/src/main/java/org/springframework/binding/method/MethodSignature.java

@@ -15,8 +15,6 @@
  */
 package org.springframework.binding.method;
 
-import java.io.Serializable;
-
 import org.springframework.core.style.ToStringCreator;
 import org.springframework.util.Assert;
 
@@ -28,7 +26,7 @@ import org.springframework.util.Assert;
  * 
  * @author Keith Donald
  */
-public class MethodSignature implements Serializable {
+public class MethodSignature {
 
 	/**
 	 * The name of the method, e.g "execute".
@@ -88,7 +86,7 @@ public class MethodSignature implements Serializable {
 			return false;
 		}
 		MethodSignature other = (MethodSignature) obj;
-		return methodName.equals(methodName) && parameters.equals(other.parameters);
+		return methodName.equals(other.methodName) && parameters.equals(other.parameters);
 	}
 
 	public int hashCode() {

spring-binding/src/main/java/org/springframework/binding/method/Parameter.java

@@ -15,8 +15,6 @@
  */
 package org.springframework.binding.method;
 
-import java.io.Serializable;
-
 import org.springframework.binding.expression.EvaluationContext;
 import org.springframework.binding.expression.Expression;
 import org.springframework.core.style.ToStringCreator;
@@ -29,7 +27,7 @@ import org.springframework.util.ObjectUtils;
  * 
  * @author Keith Donald
  */
-public class Parameter implements Serializable {
+public class Parameter {
 
 	/**
 	 * The class of the parameter, e.g "springbank.AccountNumber".

spring-binding/src/main/java/org/springframework/binding/method/Parameters.java

@@ -15,7 +15,6 @@
  */
 package org.springframework.binding.method;
 
-import java.io.Serializable;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.Iterator;
@@ -26,7 +25,7 @@ import java.util.List;
  * 
  * @author Keith
  */
-public class Parameters implements Serializable {
+public class Parameters {
 
 	/**
 	 * Canonical instance for an empty parameters list.