From ab69df656d872b0b57bd7f297d1360bbe22942e7 Mon Sep 17 00:00:00 2001 From: Lars Grefer Date: Tue, 27 Aug 2019 02:07:44 +0200 Subject: [PATCH] Java 5: Unnecessary boxing --- .../binding/convert/converters/StringToCharacter.java | 2 +- .../config/FacesFlowBuilderServicesBeanDefinitionParser.java | 2 +- .../org/springframework/webflow/test/MockExternalContext.java | 2 +- .../webflow/core/collection/LocalAttributeMapTests.java | 4 ++-- .../org/springframework/webflow/persistence/TestBean.java | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/spring-binding/src/main/java/org/springframework/binding/convert/converters/StringToCharacter.java b/spring-binding/src/main/java/org/springframework/binding/convert/converters/StringToCharacter.java index aba90d9e..db456e04 100644 --- a/spring-binding/src/main/java/org/springframework/binding/convert/converters/StringToCharacter.java +++ b/spring-binding/src/main/java/org/springframework/binding/convert/converters/StringToCharacter.java @@ -22,7 +22,7 @@ public class StringToCharacter extends StringToObject { } protected Object toObject(String string, Class targetClass) { - return new Character(string.charAt(0)); + return string.charAt(0); } protected String toString(Object object) { diff --git a/spring-faces/src/main/java/org/springframework/faces/config/FacesFlowBuilderServicesBeanDefinitionParser.java b/spring-faces/src/main/java/org/springframework/faces/config/FacesFlowBuilderServicesBeanDefinitionParser.java index f3291744..956a160e 100644 --- a/spring-faces/src/main/java/org/springframework/faces/config/FacesFlowBuilderServicesBeanDefinitionParser.java +++ b/spring-faces/src/main/java/org/springframework/faces/config/FacesFlowBuilderServicesBeanDefinitionParser.java @@ -82,7 +82,7 @@ public class FacesFlowBuilderServicesBeanDefinitionParser extends AbstractSingle private boolean parseEnableManagedBeans(Element element, BeanDefinitionBuilder definitionBuilder) { String enableManagedBeans = element.getAttribute(ENABLE_MANAGED_BEANS_ATTR); if (StringUtils.hasText(enableManagedBeans)) { - return Boolean.valueOf(enableManagedBeans); + return Boolean.parseBoolean(enableManagedBeans); } else { return false; } diff --git a/spring-webflow/src/main/java/org/springframework/webflow/test/MockExternalContext.java b/spring-webflow/src/main/java/org/springframework/webflow/test/MockExternalContext.java index 0dd0c3e0..d8a71ac4 100644 --- a/spring-webflow/src/main/java/org/springframework/webflow/test/MockExternalContext.java +++ b/spring-webflow/src/main/java/org/springframework/webflow/test/MockExternalContext.java @@ -370,7 +370,7 @@ public class MockExternalContext implements ExternalContext { * @param responseAllowed true or false */ public void setResponseAllowed(boolean responseAllowed) { - this.responseAllowed = Boolean.valueOf(responseAllowed); + this.responseAllowed = responseAllowed; } /** diff --git a/spring-webflow/src/test/java/org/springframework/webflow/core/collection/LocalAttributeMapTests.java b/spring-webflow/src/test/java/org/springframework/webflow/core/collection/LocalAttributeMapTests.java index 2daa18b6..f5b7d4ca 100644 --- a/spring-webflow/src/test/java/org/springframework/webflow/core/collection/LocalAttributeMapTests.java +++ b/spring-webflow/src/test/java/org/springframework/webflow/core/collection/LocalAttributeMapTests.java @@ -45,8 +45,8 @@ public class LocalAttributeMapTests { attributeMap.put("integer", 12345); attributeMap.put("boolean", true); attributeMap.put("long", 12345L); - attributeMap.put("double", new Double(12345)); - attributeMap.put("float", new Float(12345)); + attributeMap.put("double", 12345d); + attributeMap.put("float", 12345f); attributeMap.put("bigDecimal", new BigDecimal("12345.67")); attributeMap.put("bean", new TestBean()); attributeMap.put("stringArray", new String[] { "1", "2", "3" }); diff --git a/spring-webflow/src/test/java/org/springframework/webflow/persistence/TestBean.java b/spring-webflow/src/test/java/org/springframework/webflow/persistence/TestBean.java index d7dd833b..d1f7152d 100644 --- a/spring-webflow/src/test/java/org/springframework/webflow/persistence/TestBean.java +++ b/spring-webflow/src/test/java/org/springframework/webflow/persistence/TestBean.java @@ -37,7 +37,7 @@ public class TestBean { } public TestBean(long id, String name) { - this.entityId = new Long(id); + this.entityId = id; this.name = name; }