From c2150e9b60657c3afc4b069bb744838975eb7d84 Mon Sep 17 00:00:00 2001
From: Erwin Vervaet <erwin.vervaet@ervacon.com>
Date: Fri, 30 Mar 2007 09:51:30 +0000
Subject: [PATCH] Minor Polishing.

---
 .../support/AbstractExpressionParser.java     |  1 +
 .../binding/method/MethodKey.java             | 52 +++++++++----------
 2 files changed, 26 insertions(+), 27 deletions(-)

diff --git a/spring-binding/src/main/java/org/springframework/binding/expression/support/AbstractExpressionParser.java b/spring-binding/src/main/java/org/springframework/binding/expression/support/AbstractExpressionParser.java
index 26bf9991..a5a21bb3 100644
--- a/spring-binding/src/main/java/org/springframework/binding/expression/support/AbstractExpressionParser.java
+++ b/spring-binding/src/main/java/org/springframework/binding/expression/support/AbstractExpressionParser.java
@@ -28,6 +28,7 @@ import org.springframework.util.StringUtils;
  * Abstract base class for expression parsers.
  * 
  * @author Keith Donald
+ * @author Erwin Vervaet
  */
 public abstract class AbstractExpressionParser implements ExpressionParser {
 
diff --git a/spring-binding/src/main/java/org/springframework/binding/method/MethodKey.java b/spring-binding/src/main/java/org/springframework/binding/method/MethodKey.java
index 01ee2b1f..29f6049e 100644
--- a/spring-binding/src/main/java/org/springframework/binding/method/MethodKey.java
+++ b/spring-binding/src/main/java/org/springframework/binding/method/MethodKey.java
@@ -197,14 +197,37 @@ public class MethodKey implements Serializable {
 		return hash;
 	}
 
+	public String toString() {
+		return methodName + "(" + parameterTypesString() + ")";
+	}
+
+	/**
+	 * Convenience method that returns the parameter types describing the
+	 * signature of the method as a string.
+	 */
+	private String parameterTypesString() {
+		StringBuffer parameterTypesString = new StringBuffer();
+		for (int i = 0; i < parameterTypes.length; i++) {
+			if (parameterTypes[i] == null) {
+				parameterTypesString.append("<any>");
+			}
+			else {
+				parameterTypesString.append(ClassUtils.getShortName(parameterTypes[i]));
+			}
+			if (i < parameterTypes.length - 1) {
+				parameterTypesString.append(',');
+			}
+		}
+		return parameterTypesString.toString();
+	}
+
 	// internal helpers
 
 	/**
 	 * Determine if the given target type is assignable from the given value
 	 * type, assuming setting by reflection. Considers primitive wrapper classes
 	 * as assignable to the corresponding primitive types. <p> NOTE: Pulled from
-	 * ClassUtils in Spring 2.0 for 1.2.8 compatability. Should be collapsed
-	 * when 1.2.9 is released.
+	 * ClassUtils in Spring 2.0 for 1.2.8 compatability.
 	 * @param targetType the target type
 	 * @param valueType the value type that should be assigned to the target
 	 * type
@@ -230,29 +253,4 @@ public class MethodKey implements Serializable {
 		primitiveWrapperTypeMap.put(Long.class, long.class);
 		primitiveWrapperTypeMap.put(Short.class, short.class);
 	}
-
-	public String toString() {
-		return methodName + "(" + parameterTypesString() + ")";
-	}
-
-	/**
-	 * Convenience method that returns the parameter types describing the
-	 * signature of the method as a string.
-	 */
-	private String parameterTypesString() {
-		StringBuffer parameterTypesString = new StringBuffer();
-		for (int i = 0; i < parameterTypes.length; i++) {
-			if (parameterTypes[i] == null) {
-				parameterTypesString.append("<any>");
-			}
-			else {
-				parameterTypesString.append(ClassUtils.getShortName(parameterTypes[i]));
-			}
-			if (i < parameterTypes.length - 1) {
-				parameterTypesString.append(',');
-			}
-		}
-		return parameterTypesString.toString();
-	}
-
 }
\ No newline at end of file