Spring/spring-webflow
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Skip iteration delivering PostRestoreStateEvent

Browse Source 
Recent updates to Mojarra added a SKIP_ITERATION hint when delivering
the PostRestoreStateEvent.  Web Flow should follow the same logic.

Issue: SWF-1549
This commit is contained in:
Phillip Webb
2012-11-14 17:44:12 -08:00
parent e2e5ee97d8
commit cd3d8be819
1 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
spring-faces/src/main/java/org/springframework/faces/webflow/JsfViewFactory.java
View File

@@ -17,6 +17,7 @@ package org.springframework.faces.webflow;
import static org.springframework.faces.webflow.JsfRuntimeInformation.isPortletRequest; import static org.springframework.faces.webflow.JsfRuntimeInformation.isPortletRequest;
import java.util.EnumSet;
import java.util.Iterator; import java.util.Iterator;
import javax.el.ValueExpression; import javax.el.ValueExpression;
@@ -25,6 +26,7 @@ import javax.faces.component.EditableValueHolder;
import javax.faces.component.UIComponent; import javax.faces.component.UIComponent;
import javax.faces.component.UIViewRoot; import javax.faces.component.UIViewRoot;
import javax.faces.component.visit.VisitContext; import javax.faces.component.visit.VisitContext;
import javax.faces.component.visit.VisitHint;
import javax.faces.context.FacesContext; import javax.faces.context.FacesContext;
import javax.faces.event.AbortProcessingException; import javax.faces.event.AbortProcessingException;
import javax.faces.event.ExceptionQueuedEvent; import javax.faces.event.ExceptionQueuedEvent;
@@ -44,12 +46,14 @@ import org.springframework.webflow.execution.ViewFactory;
* JSF-specific {@link ViewFactory} implementation. * JSF-specific {@link ViewFactory} implementation.
* <p> * <p>
* This factory is responsible for performing the duties of the RESTORE_VIEW phase of the JSF lifecycle. * This factory is responsible for performing the duties of the RESTORE_VIEW phase of the JSF lifecycle.
* *
* @author Jeremy Grelle * @author Jeremy Grelle
* @author Phillip Webb * @author Phillip Webb
*/ */
public class JsfViewFactory implements ViewFactory { public class JsfViewFactory implements ViewFactory {
private static String SKIP_ITERATION_HINT = "javax.faces.visit.SKIP_ITERATION";
private static final Log logger = LogFactory.getLog(JsfViewFactory.class); private static final Log logger = LogFactory.getLog(JsfViewFactory.class);
private final Expression viewIdExpression; private final Expression viewIdExpression;
@@ -155,7 +159,7 @@ public class JsfViewFactory implements ViewFactory {
/** /**
* Walk the component tree to perform any required per-component operations. * Walk the component tree to perform any required per-component operations.
* *
* @param context * @param context
* @param component * @param component
*/ */
@@ -177,11 +181,15 @@ public class JsfViewFactory implements ViewFactory {
private void publishPostRestoreStateEvent(FacesContext facesContext) { private void publishPostRestoreStateEvent(FacesContext facesContext) {
try { try {
facesContext.getViewRoot().visitTree(VisitContext.createVisitContext(facesContext), facesContext.getAttributes().put(SKIP_ITERATION_HINT, true);
VisitContext visitContext = VisitContext.createVisitContext(facesContext, null, EnumSet.of(VisitHint.SKIP_ITERATION));
facesContext.getViewRoot().visitTree(visitContext,
new PostRestoreStateEventVisitCallback()); new PostRestoreStateEventVisitCallback());
} catch (AbortProcessingException e) { } catch (AbortProcessingException e) {
facesContext.getApplication().publishEvent(facesContext, ExceptionQueuedEvent.class, facesContext.getApplication().publishEvent(facesContext, ExceptionQueuedEvent.class,
new ExceptionQueuedEventContext(facesContext, e, null, facesContext.getCurrentPhaseId())); new ExceptionQueuedEventContext(facesContext, e, null, facesContext.getCurrentPhaseId()));
} finally {
facesContext.getAttributes().remove(SKIP_ITERATION_HINT);
} }
} }