157 Commits

Author SHA1 Message Date
rstoyanchev
85565a050b Upgrade dependencies
4.0.2 -> 4.0.6 Jakarta Faces
4.0.0 -> 4.0.2 Apache MyFaces
3.1.0 -> 3.1.1 Jakarta Servlet JSP

Closes gh-1817, gh 1818
2024-11-01 14:56:21 +00:00
rstoyanchev
2584aadef3 Polishing contribution
Closes gh-1794
2023-03-24 12:34:00 +01:00
rstoyanchev
5b27250c70 Update dependencies
See gh-1794
2023-03-23 12:34:00 +01:00
Gabor Liptak
bce7f0cc91 Update spring-faces to Jakarta EE
FlowResourceResolver.java is removed, since it was deprecated, see
https://github.com/jakartaee/faces/issues/1583

See gh-1794
2023-01-31 23:58:07 +01:00
Ian Young
b441adecfe Per CONTRIBUTING, convert text files to use LF instead of CRLF
It is easier to standardise this now in one commit rather than
during later bulk changes where it would complicate the review process.

This is literally the result of running "dos2unix" on appropriate files.

There is no attempt here to likewise standardise the spaces/tabs
conventions in the codebase.
2022-07-14 14:25:19 +01:00
Rossen Stoyanchev
84170260ef All tests are executing again
Following the upgrade to JUnit 5 in gh-99, only the few remaining older
style tests extending from TestCase were being executed. This change
ensures JUnit 5 tests are executing as well.
2020-04-28 18:12:59 +01:00
Etienne Dysli Metref
cadaaad605 Upgrade Web Flow tests from JUnit 4 to 5
Replace imports:
org.junit.Assert.* -> org.junit.jupiter.api.Assertions.*
org.junit.After    -> org.junit.jupiter.api.AfterEach
org.junit.Before   -> org.junit.jupiter.api.BeforeEach

Move the `message` argument to last position.

Issue: SWF-1739
2019-10-16 14:55:42 +01:00
Etienne Dysli Metref
ceb44a6634 Upgrade Web Flow tests from JUnit 3 to 4
Remove `extends TestCase` from all test classes and add `@Before`,
`@After`, and `@Test` method annotations.

Note that class `JsfUtilsTests` still indirectly inherits from
`TestCase` via `org.apache.myfaces.test.base.AbstractJsfTestCase`.

Issue: SWF-1739
2019-10-16 14:55:15 +01:00
Spring Operator
7edadce7bf URL Cleanup
This commit updates URLs to prefer the https protocol. Redirects are not followed to avoid accidentally expanding intentionally shortened URLs (i.e. if using a URL shortener).

# Fixed URLs

## Fixed Success
These URLs were switched to an https URL with a 2xx status. While the status was successful, your review is still recommended.

* [ ] http://www.apache.org/licenses/ with 1 occurrences migrated to:
  https://www.apache.org/licenses/ ([https](https://www.apache.org/licenses/) result 200).
* [ ] http://www.apache.org/licenses/LICENSE-2.0 with 639 occurrences migrated to:
  https://www.apache.org/licenses/LICENSE-2.0 ([https](https://www.apache.org/licenses/LICENSE-2.0) result 200).
2019-06-04 08:43:29 -04:00
Spring Operator
d4a8ea9c47 URL Cleanup
This commit updates URLs to prefer the https protocol. Redirects are not followed to avoid accidentally expanding intentionally shortened URLs (i.e. if using a URL shortener).

# HTTP URLs that Could Not Be Fixed
These URLs were unable to be fixed. Please review them to see if they can be manually resolved.

* http://joda-time.sourceforge.net/ (200) with 1 occurrences could not be migrated:
   ([https](https://joda-time.sourceforge.net/) result AnnotatedConnectException).
* http://www.jjg.net/ia/visvocab/ (200) with 1 occurrences could not be migrated:
   ([https](https://www.jjg.net/ia/visvocab/) result AnnotatedConnectException).

# Fixed URLs

## Fixed But Review Recommended
These URLs were fixed, but the https status was not OK. However, the https status was the same as the http request or http redirected to an https URL, so they were migrated. Your review is recommended.

* http://xmlns.jcp.org/xml/ns/persistence/orm_2_1.xsd (301) with 1 occurrences migrated to:
  https://www.oracle.com/webfolder/technetwork/jsc/xml/ns/persistence/orm_2_1.xsd ([https](https://xmlns.jcp.org/xml/ns/persistence/orm_2_1.xsd) result InvalidMediaTypeException).
* http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd (ReadTimeoutException) with 2 occurrences migrated to:
  https://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd ([https](https://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd) result ReadTimeoutException).
* http://www.springframework.org/schema/webflow/spring-webflow-1.0.xsd (404) with 2 occurrences migrated to:
  https://www.springframework.org/schema/webflow/spring-webflow-1.0.xsd ([https](https://www.springframework.org/schema/webflow/spring-webflow-1.0.xsd) result 404).

## Fixed Success
These URLs were switched to an https URL with a 2xx status. While the status was successful, your review is still recommended.

* http://static.springframework.org/spring-security/site/reference.html (301) with 2 occurrences migrated to:
  https://docs.spring.io/spring-security/site/reference.html ([https](https://static.springframework.org/spring-security/site/reference.html) result 200).
* http://static.springsource.org/spring/docs/2.5.x/reference/mvc.html (301) with 1 occurrences migrated to:
  https://docs.spring.io/spring/docs/2.5.x/reference/mvc.html ([https](https://static.springsource.org/spring/docs/2.5.x/reference/mvc.html) result 200).
* http://static.springsource.org/spring/docs/3.0.x/spring-framework-reference/html/expressions.html (301) with 1 occurrences migrated to:
  https://docs.spring.io/spring/docs/3.0.x/spring-framework-reference/html/expressions.html ([https](https://static.springsource.org/spring/docs/3.0.x/spring-framework-reference/html/expressions.html) result 200).
* http://static.springsource.org/spring/docs/3.0.x/spring-framework-reference/html/index.html (301) with 1 occurrences migrated to:
  https://docs.spring.io/spring/docs/3.0.x/spring-framework-reference/html/index.html ([https](https://static.springsource.org/spring/docs/3.0.x/spring-framework-reference/html/index.html) result 200).
* http://static.springsource.org/spring/docs/3.0.x/spring-framework-reference/html/mvc.html (301) with 1 occurrences migrated to:
  https://docs.spring.io/spring/docs/3.0.x/spring-framework-reference/html/mvc.html ([https](https://static.springsource.org/spring/docs/3.0.x/spring-framework-reference/html/mvc.html) result 200).
* http://static.springsource.org/spring/docs/3.0.x/spring-framework-reference/html/validation.html (301) with 2 occurrences migrated to:
  https://docs.spring.io/spring/docs/3.0.x/spring-framework-reference/html/validation.html ([https](https://static.springsource.org/spring/docs/3.0.x/spring-framework-reference/html/validation.html) result 200).
* http://en.wikipedia.org/wiki/Unified_Expression_Language with 1 occurrences migrated to:
  https://en.wikipedia.org/wiki/Unified_Expression_Language ([https](https://en.wikipedia.org/wiki/Unified_Expression_Language) result 200).
* http://hibernate.sourceforge.net/hibernate-mapping-3.0.dtd (301) with 2 occurrences migrated to:
  https://hibernate.org/dtd/hibernate-mapping-3.0.dtd ([https](https://hibernate.sourceforge.net/hibernate-mapping-3.0.dtd) result 200).
* http://jira.spring.io with 1 occurrences migrated to:
  https://jira.spring.io ([https](https://jira.spring.io) result 200).
* http://primefaces.org/documentation.html with 1 occurrences migrated to:
  https://primefaces.org/documentation.html ([https](https://primefaces.org/documentation.html) result 200).
* http://search.maven.org with 1 occurrences migrated to:
  https://search.maven.org ([https](https://search.maven.org) result 200).
* http://tiles.apache.org/dtds/tiles-config_3_0.dtd with 1 occurrences migrated to:
  https://tiles.apache.org/dtds/tiles-config_3_0.dtd ([https](https://tiles.apache.org/dtds/tiles-config_3_0.dtd) result 200).
* http://www.springframework.org/schema/beans/spring-beans.xsd with 15 occurrences migrated to:
  https://www.springframework.org/schema/beans/spring-beans.xsd ([https](https://www.springframework.org/schema/beans/spring-beans.xsd) result 200).
* http://www.springframework.org/schema/faces/spring-faces.xsd with 4 occurrences migrated to:
  https://www.springframework.org/schema/faces/spring-faces.xsd ([https](https://www.springframework.org/schema/faces/spring-faces.xsd) result 200).
* http://www.springframework.org/schema/mvc/spring-mvc.xsd with 4 occurrences migrated to:
  https://www.springframework.org/schema/mvc/spring-mvc.xsd ([https](https://www.springframework.org/schema/mvc/spring-mvc.xsd) result 200).
* http://www.springframework.org/schema/webflow-config/spring-webflow-config.xsd with 6 occurrences migrated to:
  https://www.springframework.org/schema/webflow-config/spring-webflow-config.xsd ([https](https://www.springframework.org/schema/webflow-config/spring-webflow-config.xsd) result 200).
* http://www.springframework.org/schema/webflow/spring-webflow.xsd with 45 occurrences migrated to:
  https://www.springframework.org/schema/webflow/spring-webflow.xsd ([https](https://www.springframework.org/schema/webflow/spring-webflow.xsd) result 200).
* http://docs.spring.io/spring/docs/current/spring-framework-reference/html/expressions.html with 1 occurrences migrated to:
  https://docs.spring.io/spring/docs/current/spring-framework-reference/html/expressions.html ([https](https://docs.spring.io/spring/docs/current/spring-framework-reference/html/expressions.html) result 301).
* http://springframework.org with 1 occurrences migrated to:
  https://springframework.org ([https](https://springframework.org) result 301).
* http://www.docbook.org/xml/5.0/xsd/docbook.xsd with 16 occurrences migrated to:
  https://www.docbook.org/xml/5.0/xsd/docbook.xsd ([https](https://www.docbook.org/xml/5.0/xsd/docbook.xsd) result 301).
* http://www.docbook.org/xml/5.0/xsd/xlink.xsd with 15 occurrences migrated to:
  https://www.docbook.org/xml/5.0/xsd/xlink.xsd ([https](https://www.docbook.org/xml/5.0/xsd/xlink.xsd) result 301).
* http://java.sun.com/dtd/facelet-taglib_1_0.dtd with 1 occurrences migrated to:
  https://java.sun.com/dtd/facelet-taglib_1_0.dtd ([https](https://java.sun.com/dtd/facelet-taglib_1_0.dtd) result 302).
* http://java.sun.com/xml/ns/javaee/web-facesconfig_2_0.xsd with 1 occurrences migrated to:
  https://java.sun.com/xml/ns/javaee/web-facesconfig_2_0.xsd ([https](https://java.sun.com/xml/ns/javaee/web-facesconfig_2_0.xsd) result 302).
* http://java.sun.com/xml/ns/persistence/persistence_1_0.xsd with 1 occurrences migrated to:
  https://java.sun.com/xml/ns/persistence/persistence_1_0.xsd ([https](https://java.sun.com/xml/ns/persistence/persistence_1_0.xsd) result 302).
* http://repo.spring.io/snapshot with 1 occurrences migrated to:
  https://repo.spring.io/snapshot ([https](https://repo.spring.io/snapshot) result 302).
* http://www.paypal.com?_callbackUrl= with 1 occurrences migrated to:
  https://www.paypal.com?_callbackUrl= ([https](https://www.paypal.com?_callbackUrl=) result 302).

# Ignored
These URLs were intentionally ignored.

* http://docbook.org/ns/docbook with 32 occurrences
* http://java.sun.com/jsf/facelets with 2 occurrences
* http://java.sun.com/jsf/html with 2 occurrences
* http://java.sun.com/xml/ns/javaee with 2 occurrences
* http://java.sun.com/xml/ns/persistence with 2 occurrences
* http://localhost/app/hotels/booking?hotelId=1 with 1 occurrences
* http://www.springframework.org/schema/beans with 30 occurrences
* http://www.springframework.org/schema/faces with 8 occurrences
* http://www.springframework.org/schema/mvc with 8 occurrences
* http://www.springframework.org/schema/webflow with 96 occurrences
* http://www.springframework.org/schema/webflow-config with 12 occurrences
* http://www.springframework.org/security/tags with 2 occurrences
* http://www.springframework.org/security/tags</namespace&gt with 1 occurrences
* http://www.w3.org/1999/xhtml with 2 occurrences
* http://www.w3.org/1999/xlink with 30 occurrences
* http://www.w3.org/2001/XInclude with 31 occurrences
* http://www.w3.org/2001/XMLSchema-instance with 81 occurrences
* http://xmlns.jcp.org/xml/ns/persistence/orm with 2 occurrences
2019-06-04 08:39:26 -04:00
Spring Operator
8c76ad9e0b URL Cleanup
This commit updates URLs to prefer the https protocol. Redirects are not followed to avoid accidentally expanding intentionally shortened URLs (i.e. if using a URL shortener).

# HTTP URLs that Could Not Be Fixed
These URLs were unable to be fixed. Please review them to see if they can be manually resolved.

* [ ] http://url.somewhereelse.com (200) with 2 occurrences could not be migrated:
   ([https](https://url.somewhereelse.com) result SSLHandshakeException).

# Fixed URLs

## Fixed But Review Recommended
These URLs were fixed, but the https status was not OK. However, the https status was the same as the http request or http redirected to an https URL, so they were migrated. Your review is recommended.

* [ ] http://progit.org/book/ch5-2.html (301) with 1 occurrences migrated to:
  https://progit.org/book/ch5-2.html ([https](https://progit.org/book/ch5-2.html) result SSLHandshakeException).
* [ ] http://<host>/ (UnknownHostException) with 2 occurrences migrated to:
  https://<host>/ ([https](https://<host>/) result UnknownHostException).
* [ ] http://someHost/someApp/someServlet/foo (UnknownHostException) with 1 occurrences migrated to:
  https://someHost/someApp/someServlet/foo ([https](https://someHost/someApp/someServlet/foo) result UnknownHostException).
* [ ] http://someHost/someApp/someServlet/nestedPath/bar (UnknownHostException) with 1 occurrences migrated to:
  https://someHost/someApp/someServlet/nestedPath/bar ([https](https://someHost/someApp/someServlet/nestedPath/bar) result UnknownHostException).
* [ ] http://someHost/someApp/someServlet/nestedPath/bar.html (UnknownHostException) with 1 occurrences migrated to:
  https://someHost/someApp/someServlet/nestedPath/bar.html ([https](https://someHost/someApp/someServlet/nestedPath/bar.html) result UnknownHostException).
* [ ] http://someHost/someApp/someServlet/nestedPath/foo (UnknownHostException) with 2 occurrences migrated to:
  https://someHost/someApp/someServlet/nestedPath/foo ([https](https://someHost/someApp/someServlet/nestedPath/foo) result UnknownHostException).
* [ ] http://someHost/someApp/someServlet/nestedPath/foo.html (UnknownHostException) with 2 occurrences migrated to:
  https://someHost/someApp/someServlet/nestedPath/foo.html ([https](https://someHost/someApp/someServlet/nestedPath/foo.html) result UnknownHostException).
* [ ] http://someOtherSystem?orderId= (UnknownHostException) with 2 occurrences migrated to:
  https://someOtherSystem?orderId= ([https](https://someOtherSystem?orderId=) result UnknownHostException).
* [ ] http://url.somewhere.com (UnknownHostException) with 2 occurrences migrated to:
  https://url.somewhere.com ([https](https://url.somewhere.com) result UnknownHostException).
* [ ] http://book.git-scm.com/4_interactive_rebasing.html (301) with 1 occurrences migrated to:
  https://book.git-scm.com/4_interactive_rebasing.html ([https](https://book.git-scm.com/4_interactive_rebasing.html) result 404).
* [ ] http://download.dojotoolkit.org/release- (301) with 1 occurrences migrated to:
  https://download.dojotoolkit.org/release- ([https](https://download.dojotoolkit.org/release-) result 404).
* [ ] http://help.github.com/send-pull-requests (404) with 2 occurrences migrated to:
  https://help.github.com/send-pull-requests ([https](https://help.github.com/send-pull-requests) result 404).
* [ ] http://svn.dojotoolkit.org/src/util/trunk/buildscripts/profiles/standard.profile.js (404) with 1 occurrences migrated to:
  https://svn.dojotoolkit.org/src/util/trunk/buildscripts/profiles/standard.profile.js ([https](https://svn.dojotoolkit.org/src/util/trunk/buildscripts/profiles/standard.profile.js) result 404).
* [ ] http://www.springframework.org/schema/webflow/spring-webflow-2.0.xsd (404) with 1 occurrences migrated to:
  https://www.springframework.org/schema/webflow/spring-webflow-2.0.xsd ([https](https://www.springframework.org/schema/webflow/spring-webflow-2.0.xsd) result 404).
* [ ] http://www.springframework.org/schema/webflow/spring-webflow-2.4.xsd (404) with 1 occurrences migrated to:
  https://www.springframework.org/schema/webflow/spring-webflow-2.4.xsd ([https](https://www.springframework.org/schema/webflow/spring-webflow-2.4.xsd) result 404).

## Fixed Success
These URLs were switched to an https URL with a 2xx status. While the status was successful, your review is still recommended.

* [ ] http://bugs.dojotoolkit.org/ticket/6849 with 1 occurrences migrated to:
  https://bugs.dojotoolkit.org/ticket/6849 ([https](https://bugs.dojotoolkit.org/ticket/6849) result 200).
* [ ] http://docs.spring.io/spring-webflow/docs/current/api/ with 1 occurrences migrated to:
  https://docs.spring.io/spring-webflow/docs/current/api/ ([https](https://docs.spring.io/spring-webflow/docs/current/api/) result 200).
* [ ] http://docs.spring.io/spring-webflow/docs/current/reference/html/ with 1 occurrences migrated to:
  https://docs.spring.io/spring-webflow/docs/current/reference/html/ ([https](https://docs.spring.io/spring-webflow/docs/current/reference/html/) result 200).
* [ ] http://static.springframework.org/spring-webflow/images/spring-webflow.jpg (301) with 1 occurrences migrated to:
  https://docs.spring.io/spring-webflow/images/spring-webflow.jpg ([https](https://static.springframework.org/spring-webflow/images/spring-webflow.jpg) result 200).
* [ ] http://projects.spring.io/spring-webflow/ with 1 occurrences migrated to:
  https://projects.spring.io/spring-webflow/ ([https](https://projects.spring.io/spring-webflow/) result 200).
* [ ] http://stackoverflow.com/questions/tagged/spring-webflow with 1 occurrences migrated to:
  https://stackoverflow.com/questions/tagged/spring-webflow ([https](https://stackoverflow.com/questions/tagged/spring-webflow) result 200).
* [ ] http://www.martinfowler.com/articles/mocksArentStubs.html with 2 occurrences migrated to:
  https://www.martinfowler.com/articles/mocksArentStubs.html ([https](https://www.martinfowler.com/articles/mocksArentStubs.html) result 200).
* [ ] http://www.springframework.org/schema/beans/spring-beans.xsd with 2 occurrences migrated to:
  https://www.springframework.org/schema/beans/spring-beans.xsd ([https](https://www.springframework.org/schema/beans/spring-beans.xsd) result 200).
* [ ] http://www.springframework.org/schema/tool/spring-tool-3.0.xsd with 1 occurrences migrated to:
  https://www.springframework.org/schema/tool/spring-tool-3.0.xsd ([https](https://www.springframework.org/schema/tool/spring-tool-3.0.xsd) result 200).
* [ ] http://www.springframework.org/schema/webflow/spring-webflow.xsd with 2 occurrences migrated to:
  https://www.springframework.org/schema/webflow/spring-webflow.xsd ([https](https://www.springframework.org/schema/webflow/spring-webflow.xsd) result 200).
* [ ] http://www.w3.org/XML/1998/namespace with 1 occurrences migrated to:
  https://www.w3.org/XML/1998/namespace ([https](https://www.w3.org/XML/1998/namespace) result 200).
* [ ] http://contributor-covenant.org with 1 occurrences migrated to:
  https://contributor-covenant.org ([https](https://contributor-covenant.org) result 301).
* [ ] http://contributor-covenant.org/version/1/3/0/ with 1 occurrences migrated to:
  https://contributor-covenant.org/version/1/3/0/ ([https](https://contributor-covenant.org/version/1/3/0/) result 301).
* [ ] http://forum.springsource.org/forumdisplay.php?36-Web-Flow (301) with 1 occurrences migrated to:
  https://forum.spring.io/forumdisplay.php?36-Web-Flow ([https](https://forum.springsource.org/forumdisplay.php?36-Web-Flow) result 301).
* [ ] http://jira.springsource.org/browse/SWF with 1 occurrences migrated to:
  https://jira.springsource.org/browse/SWF ([https](https://jira.springsource.org/browse/SWF) result 301).
* [ ] http://xml.apache.org/xalan with 1 occurrences migrated to:
  https://xml.apache.org/xalan ([https](https://xml.apache.org/xalan) result 301).
* [ ] http://java.sun.com/xml/jaxp/properties/schemaLanguage with 1 occurrences migrated to:
  https://java.sun.com/xml/jaxp/properties/schemaLanguage ([https](https://java.sun.com/xml/jaxp/properties/schemaLanguage) result 302).
* [ ] http://repo.spring.io/snapshot with 1 occurrences migrated to:
  https://repo.spring.io/snapshot ([https](https://repo.spring.io/snapshot) result 302).
* [ ] http://springsource.com/support/springsupport with 1 occurrences migrated to:
  https://springsource.com/support/springsupport ([https](https://springsource.com/support/springsupport) result 302).
* [ ] http://www.paypal.com with 4 occurrences migrated to:
  https://www.paypal.com ([https](https://www.paypal.com) result 302).
* [ ] http://www.paypal.com?_callbackUrl= with 1 occurrences migrated to:
  https://www.paypal.com?_callbackUrl= ([https](https://www.paypal.com?_callbackUrl=) result 302).

# Ignored
These URLs were intentionally ignored.

* http://localhost/springtravel/app/booking with 1 occurrences
* http://localhost/springtravel/app/flight/booking with 1 occurrences
* http://localhost/springtravel/app/hotel/booking with 1 occurrences
* http://localhost/springtravel/app/hotels/booking with 1 occurrences
* http://localhost/springtravel/app/hotels/booking?execution=e1s1 with 1 occurrences
* http://localhost/springtravel/hotels/booking.htm with 1 occurrences
* http://www.springframework.org/schema/beans with 4 occurrences
* http://www.springframework.org/schema/faces with 2 occurrences
* http://www.springframework.org/schema/tool with 2 occurrences
* http://www.springframework.org/schema/webflow with 39 occurrences
* http://www.springframework.org/schema/webflow-config with 2 occurrences
* http://www.springframework.org/schema/webflow/spring-webflow.xsd"&gt with 1 occurrences
* http://www.w3.org/1999/XSL/Transform with 1 occurrences
* http://www.w3.org/2001/XMLSchema with 4 occurrences
* http://www.w3.org/2001/XMLSchema-instance with 2 occurrences
2019-06-04 08:37:31 -04:00
Rossen Stoyanchev
8298e638e3 Fix remaining spring-faces test warnings 2018-02-09 11:52:38 -05:00
Phillip Webb
ed5ec37737 Fix warnings 2018-02-08 22:46:49 -08:00
Rossen Stoyanchev
da6d1492c1 Fix warnings 2018-02-08 18:50:40 -05:00
Rossen Stoyanchev
6d5a8debd5 Polish
Remove:
- auto-boxing
- unnecessary array creation
- public keyword on interface methods
- unnecessary throws clauses

Use lambda expressions
2018-02-08 15:47:21 -05:00
Rossen Stoyanchev
d66c25ffd0 Use diamond operator
Issue: SWF-1718
2018-02-08 13:06:46 -05:00
Rossen Stoyanchev
0a618b0791 Streamline XML namespace support towards unversioned schemas
Issue: SWF-1701
2018-02-07 21:55:11 -05:00
Rossen Stoyanchev
3a165ea879 Remove dependency on internal MyFaces class
Issue: SWF-1712
2017-12-15 15:48:55 -05:00
Rossen Stoyanchev
4fb1b99a8b Dependency updates
Spring Security 4.1.0  -> 4.2.1
Commons Logging 1.1.1  -> 1.2
Log4j           1.7.22 -> 2.7
Servlet API     3.0.1  -> 3.1.0
Tiles           3.0.5  -> 3.0.7
JUnit           4.1.11 -> 4.1.12

Issue: SWF-1692
2017-01-06 16:47:19 -05:00
Rossen Stoyanchev
3a0857496e Remove remaining Portlet references
Issue: SWF-1692
2017-01-06 16:47:06 -05:00
Rossen Stoyanchev
5b0df65be4 Fold spring-js + spring-js-tiles3 into spring-webflow
Issue: SWF-1693
2017-01-06 16:46:46 -05:00
Rossen Stoyanchev
deeaeab894 Shortest path to tests running with Spring Framework 5
Upgrade to Java 8+

Remove Portlet, Tiles2, and Hibernate 3 + 4 support

Issue: SWF-1692
2017-01-06 16:44:58 -05:00
Rossen Stoyanchev
b51b30ed01 Upgrade to Spring Security 4 and Spring Framework 4.1
Issue: SWF-1657, SWF-1663
2015-06-04 15:18:28 -04:00
Andy Wilkinson
78e02ea6c1 Upgrade to Mojarra 2.2.10
Mojarra 2.2.10 generates responses that begin with an XML
declaration:

<?xml version='1.0' encoding='utf-8'?>

This change broke the expectation in JsfAjaxHandlerTests's
testSendAjaxRedirect. The test has been updated to expect the
XML declaration.

ResourcesBeanDefinitionParserTests has been updated to set up and
tear down the mock JDF infrastructure. This ensures that it does not
leave any side-effects that cause subsequent tests to fail on some
platforms.
2015-03-03 16:23:00 +00:00
Rossen Stoyanchev
1c67a0dc08 Revert "Prevent NPE in Mojarra when creating initial view"
This reverts commit d31900e5f9.

The fix for SWF-1571 reported against Mojarra 2.1.8 seems to be
problematic when Web Flow's ResponseStateManager is not used as
reported in SWF-1630.

Testing with Mojarra 2.1.20 I can no longer reproduce SWF-1571
and originally it was suspected to be a Mojarra issue. Hence
this revert.

Issue: SWF-1571, SWF-1630
2014-05-20 16:19:14 -04:00
Rossen Stoyanchev
cce1515a17 Support providing validator in faces builder serivces
Issue: SWF-1494
2014-03-31 17:28:31 -04:00
Rossen Stoyanchev
921220be27 Add Java config option for configuring Spring Web Flow
Issue: SWF-1548
2014-02-25 21:34:10 -05:00
Rossen Stoyanchev
217f838008 Upgrade Mojara to version 2.2.4
Issue: SWF-1613
2013-12-20 14:54:39 -05:00
Phillip Webb
787fb7dc89 Fix issue with RichFaces file upload
Change JsfView.userEventQueued() to check for 'javax.faces.ViewState'
via the FacesContext rather than the RequestContext. This allows
potential multi-part request submissions to be processed by JSF rather
than Spring.

Issue: SWF-1482
2013-01-29 09:55:56 -05:00
Rossen Stoyanchev
508d6a7dfb Add support for partial JSR-303 bean validation
This change makes it possible to use validation hints in conjunction
with declarative, JSR-303 validation. Such hints may be defined in an
attribute of the view state where the view state id itself is also
interpeted as a hint. A custom ValidationHintResolver can be plugged
in if necessary.

Issue: SWF-1453
2012-11-29 17:24:31 -05:00
Phillip Webb
d31900e5f9 Prevent NPE in Mojarra when creating initial view
Refactor JsfViewFactory to only attempt a restoreView when state is
available. This prevents a NullPointerException from being thrown
when using Mojarra with partial state saving disabled. This change
also makes Web Flow behave in a similar way to the standard
FacesServlet.

Issue: SWF-1571
2012-11-16 14:18:53 -08:00
Phillip Webb
2dea6c426a Remove legacy code following JSF 2.0 migration
- Remove JSF 1.2 components including ui package, faces-config.xml
  references and tld files
- Remove AjaxViewRoot class
- Polish JavaDocs

Issues: SWF-1536
2012-06-27 14:07:44 -07:00
Phillip Webb
d904786083 Modify <faces:resources> to add portlet variant
The ResourcesBeanDefinitionParser will now automatically register an
additional portlet resource resolver when a portlet environment and
and relevant Spring portlet classes are detected.

Issues: SWF-1500
2012-06-18 19:08:58 -04:00
Phillip Webb
706490c4dc Upgrade spring-faces to JSF 2 as a minimum requirement
* Rework all state handling, removed FlowSerializedView class and save
state as opaque object
* Use FacesWrapper classes instead of custom delegates
* Deprecate isAtLeastJSFXXX() methods and removed all internal use
* Remove all Jsf2XXX versions of classes
* Refactor all calls to deprecated JSF methods
* Removed older VariableResolver and PropertyResolver classes
* Deprecate Jsf2FlowResourceResolver and log warning if used
* Create new FlowELResolver to replace removed VariableResolvers and
PropertyResolvers
* Update faces-config.xml to use newer xsd
* Significantly rework FlowFacesContext to remove the message delegate
and generally improve the code
* Added "provided" dependency to MyFaces and fixed partial state saving
on MyFaces
* Fixed FlowResourceResolver to delegate to both MyFaces or Mojarra
depending on availability
* Add JsfUtils.findFactory method and rework existing code to replace
FactoryFinder calls and casts
* Refactor JsfViewFactory to improve code readability
* Rename FlowViewStateManager and FlowViewResponseStateManager to
FlowStateManager and FlowResponseStateManager
* Ensure ResponseContextHolder is reset after each test
* Update JSF portlet support to function with JSF 2.0

Issue: SWF-1536, SWF-1540, SWF-1550
2012-06-13 19:39:10 -04:00
Rossen Stoyanchev
a770fa3492 Rename a couple of test classes to match convention 2012-05-25 16:54:15 -04:00
Rossen Stoyanchev
4e81930b72 Add Gradle build
- Add gradle build script
- Remove spring-build/
- Remove build-spring-webflow/
- Remove ivy.xml, pom.xml, template.mf
- Remove eclipse  metadata
- Remove RichFacesAjaxHandler.java
- Create src/dist and add changelog.txt, readme.txt

Dependency changes:
- EBR dependency -> Maven-central dependencies
- el-api 1.0 -> 2.2.0
- ognl 2.6.9 -> 2.6.11
- org.jboss.el -> tomcat-jasper-el 7.0.27
2012-05-25 16:54:15 -04:00
Phillip Webb
54a300e009 Change signatures to make use of Java 5 varargs
Issues: SWF-1532
2012-04-05 16:23:38 -07:00
Phillip Webb
22b018e95a Make use of Java 5 auto boxing
Reviewed and replaced when possible:
- new Integer
- intValue()
- new Boolean
- booleanValue()
- Boolean.TRUE
- Boolean.FALSE
- new Long
- longValue()

Issues: SWF-1532
2012-04-05 14:07:58 -07:00
Phillip Webb
3f1c40188c Update dates in copyright notice to 2004-2012
Issues: SWF-1532
2012-04-05 10:39:26 -07:00
Phil Webb
4d008f3f09 Refactor code to use Java 5 features
- Apply and use Generics
- Remove JdkVersion.isAtLeastJava15() conditionals
- Replace iterator loops with foreach syntax
- Switch on warning in eclipse

Issues: SWF-1532
2012-03-29 21:02:07 -07:00
Phil Webb
27cd5cca31 Add support for PostRestoreStateEvent
A PostRestoreStateEvent should be delivered whenever a JSF view is
restored. Typically we rely on JSF to generate required events but
in this case since WebFlow handles the RESTORE_VIEW phase itself,
we need to deliver this event ourselves.

Issues: SWF-1500
2012-03-06 17:20:55 -05:00
Rossen Stoyanchev
63151acb8d Minor fix in FlowPartialViewContext
The fix ensures that getRenderIds returns a mutable collection as
stated in the contract for the method in PartialViewContext.

Issues: SWF-1480
2012-02-29 12:21:07 -05:00
Rossen Stoyanchev
df649084ab Fix for bean validation messages in BindingResult
Previously Web Flow's BindingResult implementation distinguished
object from field-level errors by checking if the source of the
error is null or otherwise a String. However, class-level bean
validation errors have a field source represented by an empty
String. After this change object and field-level errors are
recognized by checking for String-based field source that is
neither null nor empty.

This commit also contains a fix for spring-faces tests where
in JSF 2.1 the presence of an unreleased FacesContext may
cause some tests to fail.
2012-02-28 13:27:16 -05:00
Rossen Stoyanchev
85d8d73c1d Update Jsf2FlowFacesContext.isValidationFailed()
Previously isValidationFailed() merely delegated to the wrapped
FacesContext ignoring any errors that may have been added to
Web Flow's MessageContext. After the change isValidationFailed()
checks and returns true if the MessageContext contains errors
or otherwise it delegates.

Issues: SWF-1490
2012-02-28 10:47:47 -05:00
Phil Webb
962b123d73 Ensure required test directory is created in GIT and remove javadoc refs to missing home dir 2012-01-18 17:57:36 -05:00
Rossen Stoyanchev
ed76ec0485 SWF-1424 Add Web Flow implementation of PartialViewContext to support render action in JSF 2 applications. 2011-02-20 21:32:19 +00:00
Rossen Stoyanchev
1683f8c891 SWF-1435 Add top level pom.xml and Maven settings for verifying Maven configuration 2010-12-07 16:09:18 +00:00
Rossen Stoyanchev
8a4038ac13 SWF-1432 Make sure content type is set when sending a redirect instruction during JSF Ajax request 2010-12-03 14:51:45 +00:00
Rossen Stoyanchev
df7f3406a0 SWF-1419 Add ability to plug in custom Spring Validator via FlowBuilderServices to support JSR-303 validation 2010-12-02 13:54:00 +00:00
Rossen Stoyanchev
e70bca23fb SWF-1406 Fix regression in iterating faces messages 2010-10-27 08:01:40 +00:00